From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A88C433EF for ; Wed, 10 Nov 2021 20:28:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C09DA61178 for ; Wed, 10 Nov 2021 20:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C09DA61178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=je1C2kRa+u364Eez4XLWZMrLpF6xA45wiuu1me6Z1Qg=; b=zh3pVvOj7207+i DfZcge6D+0Y8HZE0wFeR1V1HhCZLWCDy8QAnJxhsLKcT5f8a8tlpbd/3hy0ZTAf5BCHlOzHq3R83x UlUqgsWocLg/jlTd8aUvh75g2rkW2y8NNb/1YteX+JkOVxxDFh/rT3Ndhv+Ae2weiwBHoAjzVQTAP /M5kvJUYLa1xZ0u0Z1f0GDMdLgUioBtFkSrCDCYO8IUGwBRA83ly+0IONX63iwTnXNeWQ+WBXhemf HI1l/Ehsm39SbupKD5wOajw4CvNYiNAh+pgx7ZyawKcxt5MppSGs9L38ANPDnlb0AxeRG1HpTL7g7 aR1sscXgAzO9bg+ItsYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkuBy-006LB9-Ks; Wed, 10 Nov 2021 20:27:34 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkuBu-006LA9-RM for linux-arm-kernel@lists.infradead.org; Wed, 10 Nov 2021 20:27:32 +0000 Received: by mail-wm1-x330.google.com with SMTP id o29so3296576wms.2 for ; Wed, 10 Nov 2021 12:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VCO5uvUOcT27e+DRykZRIen3xP0SFPGTd6Mp1JZTAsY=; b=HThajDrDc6kB1OnizIXhqzZNZZvMfdEHMWtMO4M30i37Pl73wkt59s0uAsKI/RdkPF 1wk6JxgmAhSrbRsPWAIvz6B3dIzTqP1/gcXhrAg3Kw18a7B2hIY3mE0EgiG057B8KZUy 2r4dyL/l4YIrur+Kn5hq7L8zexNdXLUoevOaZRRL88bHNDHY//iJvBd2HxSsP/+sevHM tY78m10uixmloXgSMDKdn29FiasKIn3plMw6EOexg0Mz5o2pMLWAK4GZFdnnyT0Wr1xo 31pw1Ol0dCl/18DjBGfMtfvKMD+VkFS36tRt/sMqI0UGRF8tV70VpN2eqyLFtlwLzfWL U+nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VCO5uvUOcT27e+DRykZRIen3xP0SFPGTd6Mp1JZTAsY=; b=7J+Las8kBEtPyAohoPhs3R1/ZjlFShWpUjyZjfPVMpb2jBaxLp6Givxq32L7pkhdF0 0XZ1bJG9wDyAgNHrCbYIqrH/JenmFwJ8BQFcLfv/TTz4Vij5NltmmLk0MC1F/h9w1aTN fj8CM+FVufMXfK+NrcQG9pJY9aQpzD/RONV8dRiMRwYk22H5yj+lBJ2HfoBIGHpz0UIg QQMqGVEJgqRL3VYwKIHItXLT2OqGKcHhikn8yhSoAPWpETmqMh3GtEVy9ZNe2ScL3QJH aaLs5XcprefeFnOjIdaFFQ4uVsI4z9VhEgM3cy3Aw6Yt6i2keLkZOl3XDdtGo4ykJeRI z4ig== X-Gm-Message-State: AOAM530NnxHZ3rbtf7rbRIu/i0ouy8W8KZOLMQBn5YS9+lZdrFNCA6lb 6iXY3OCkE8kCjolItQfKFW3yWF5Qm6l7hw== X-Google-Smtp-Source: ABdhPJw4KjDz2RofXLwp2G67jkwH49HdpJCT6V9QEt9aux7cGkvEY9V4DGLIjaCPxROLcjclfo3KDw== X-Received: by 2002:a1c:4d13:: with SMTP id o19mr2192192wmh.164.1636576049474; Wed, 10 Nov 2021 12:27:29 -0800 (PST) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id q123sm6506007wma.30.2021.11.10.12.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 12:27:29 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-sunxi@lists.linux.dev, Roman Stratiienko Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, wens@csie.org, mripard@kernel.org, b-liu@ti.com, megous@megous.com, Roman Stratiienko Subject: Re: [PATCH] usb: musb: sunxi: Don't print error on MUSB_ULPI_BUSCONTROL access Date: Wed, 10 Nov 2021 21:27:23 +0100 Message-ID: <7984413.T7Z3S40VBb@kista> In-Reply-To: <20211019131244.1568560-1-r.stratiienko@gmail.com> References: <20211019131244.1568560-1-r.stratiienko@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_122730_940317_5C506815 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Roman, sorry for late reply. Dne torek, 19. oktober 2021 ob 15:12:44 CET je Roman Stratiienko napisal(a): > Error message appears during suspend, where musb driver is storing > the register state in musb_save_context(): > ``` > musb-sunxi 1c19000.usb: Error unknown readb offset 112 > ``` > > Print warning instead to avoid confusion. > > Signed-off-by: Roman Stratiienko > --- > drivers/usb/musb/sunxi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c > index f3f76f2ac63f9b..961c858fb349e1 100644 > --- a/drivers/usb/musb/sunxi.c > +++ b/drivers/usb/musb/sunxi.c > @@ -440,6 +440,10 @@ static u8 sunxi_musb_readb(void __iomem *addr, u32 offset) > return 0xde; > > return readb(addr + SUNXI_MUSB_CONFIGDATA); > + case MUSB_ULPI_BUSCONTROL: > + dev_warn(sunxi_musb->controller->parent, > + "sunxi-musb does not have ULPI bus control register\n"); Since this register doesn't exist, wouldn't be better to print only debug message? Warning would imply something that's out of the ordinary, but in this case it's benign. > + return 0; > /* Offset for these is fixed by sunxi_musb_busctl_offset() */ > case SUNXI_MUSB_TXFUNCADDR: > case SUNXI_MUSB_TXHUBADDR: > @@ -494,6 +498,10 @@ static void sunxi_musb_writeb(void __iomem *addr, unsigned offset, u8 data) > return writeb(data, addr + SUNXI_MUSB_TXFIFOSZ); > case MUSB_RXFIFOSZ: > return writeb(data, addr + SUNXI_MUSB_RXFIFOSZ); > + case MUSB_ULPI_BUSCONTROL: > + dev_warn(sunxi_musb->controller->parent, > + "sunxi-musb does not have ULPI bus control register\n"); > + return; > /* Offset for these is fixed by sunxi_musb_busctl_offset() */ Same here. Best regards, Jernej > case SUNXI_MUSB_TXFUNCADDR: > case SUNXI_MUSB_TXHUBADDR: > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel