[PATCH v2 0/3] arm64: dts: rockchip: update Radxa E52C support

[PATCH v2 0/3] arm64: dts: rockchip: update Radxa E52C support

[Chukun Pan]

Changed from v2:
  Remove merged patches
  Remove VCC_3V3_PMU for Radxa E52C (new)
  Update pinctrl names for Radxa E52C (new)
  Update commit message for disabling display subsystem

Chukun Pan (3):
  arm64: dts: rockchip: disable display subsystem for Radxa E52C
  arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C
  arm64: dts: rockchip: update pinctrl names for Radxa E52C

 .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 30 ++++++++-----------
 1 file changed, 12 insertions(+), 18 deletions(-)

-- 
2.25.1

[PATCH v2 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

[Chukun Pan]

The Radxa E52C SBC do not have HDMI output, so disable
the display subsystem to avoid the following error log:

*ERROR* No available vop found for display-subsystem.

Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 48ddc43e2ab5..1883bd183396 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -207,6 +207,10 @@ &cpu_l3 {
 	cpu-supply = <&vdd_cpu_lit_s0>;
 };
 
+&display_subsystem {
+	status = "disabled";
+};
+
 &i2c0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0m2_xfer>;
-- 
2.25.1

[PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[Chukun Pan]

According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
The vcc_3v3_pmu is not a new regulator, so remove it.

[1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 1883bd183396..4a3ae95f122f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
 		vin-supply = <&vcc_sysin>;
 	};
 
-	vcc_3v3_pmu: regulator-3v3-0 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_3v3_pmu";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		vin-supply = <&vcc_3v3_s3>;
-	};
-
 	vcc_3v3_s0: regulator-3v3-1 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_3v3_s0";
@@ -255,7 +245,7 @@ eeprom@50 {
 		reg = <0x50>;
 		pagesize = <16>;
 		read-only;
-		vcc-supply = <&vcc_3v3_pmu>;
+		vcc-supply = <&vcc_3v3_s3>;
 	};
 };
 
-- 
2.25.1

Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[FUKAUMI Naoki]

Hi Chukun,

On 8/16/25 17:00, Chukun Pan wrote:
> According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
> is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
> The vcc_3v3_pmu is not a new regulator, so remove it.
> 
> [1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 1883bd183396..4a3ae95f122f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
>   		vin-supply = <&vcc_sysin>;
>   	};
>   
> -	vcc_3v3_pmu: regulator-3v3-0 {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vcc_3v3_pmu";
> -		regulator-always-on;
> -		regulator-boot-on;
> -		regulator-min-microvolt = <3300000>;
> -		regulator-max-microvolt = <3300000>;
> -		vin-supply = <&vcc_3v3_s3>;
> -	};
> -
>   	vcc_3v3_s0: regulator-3v3-1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc_3v3_s0";
> @@ -255,7 +245,7 @@ eeprom@50 {
>   		reg = <0x50>;
>   		pagesize = <16>;
>   		read-only;
> -		vcc-supply = <&vcc_3v3_pmu>;
> +		vcc-supply = <&vcc_3v3_s3>;

How about the following instead?

@@ -538,7 +538,7 @@ regulator-state-mem {
  				};
  			};

-			vcc_3v3_s3: dcdc-reg8 {
+			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
  				regulator-name = "vcc_3v3_s3";
  				regulator-always-on;
  				regulator-boot-on;

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   	};
>   };
>   

Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[Chukun Pan]

Hi,

> How about the following instead?
>
> @@ -538,7 +538,7 @@ regulator-state-mem {
> 				};
> 			};
>
> -			vcc_3v3_s3: dcdc-reg8 {
> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> 				regulator-name = "vcc_3v3_s3";
> 				regulator-always-on;
> 				regulator-boot-on;

On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
is also connected through a 0 ohm resistor, so I didn't write like
this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19

Thanks,
Chukun

--
2.25.1

Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[FUKAUMI Naoki]

Hi Chukun,

On 8/19/25 22:40, Chukun Pan wrote:
> Hi,
> 
>> How about the following instead?
>>
>> @@ -538,7 +538,7 @@ regulator-state-mem {
>> 				};
>> 			};
>>
>> -			vcc_3v3_s3: dcdc-reg8 {
>> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
>> 				regulator-name = "vcc_3v3_s3";
>> 				regulator-always-on;
>> 				regulator-boot-on;
> 
> On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> is also connected through a 0 ohm resistor, so I didn't write like
> this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19

I think it should match the schematic, i.e. it should be "vcc-supply = 
<&vccio_flash>;".

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Thanks,
> Chukun
> 
> --
> 2.25.1
> 
> 
> 

Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[Heiko Stuebner]

Am Mittwoch, 20. August 2025, 04:10:24 Mitteleuropäische Sommerzeit schrieb FUKAUMI Naoki:
> Hi Chukun,
> 
> On 8/19/25 22:40, Chukun Pan wrote:
> > Hi,
> > 
> >> How about the following instead?
> >>
> >> @@ -538,7 +538,7 @@ regulator-state-mem {
> >> 				};
> >> 			};
> >>
> >> -			vcc_3v3_s3: dcdc-reg8 {
> >> +			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
> >> 				regulator-name = "vcc_3v3_s3";
> >> 				regulator-always-on;
> >> 				regulator-boot-on;
> > 
> > On rk356x, the Flash chip is usually powered by VCCIO_FLASH, which
> > is also connected through a 0 ohm resistor, so I didn't write like
> > this. e.g. https://github.com/torvalds/linux/commit/a706a593cb19
> 
> I think it should match the schematic, i.e. it should be "vcc-supply = 
> <&vccio_flash>;".

I very much agree :-) .

Having at least the phandle match the schematics nameing is very helpful
when someone tries to look something up between those two.


Heiko

[PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C

[Chukun Pan]

Updated the pinctrl names of the user key and power LED according
to the schematic. Also updated the nodenames of other pinctrls.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 4a3ae95f122f..f93b129a0032 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -42,7 +42,7 @@ button-0 {
 	keys-1 {
 		compatible = "gpio-keys";
 		pinctrl-names = "default";
-		pinctrl-0 = <&btn_0>;
+		pinctrl-0 = <&pwm15_ir_m1>;
 
 		button-1 {
 			label = "User";
@@ -55,7 +55,7 @@ button-1 {
 	leds-0 {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
-		pinctrl-0 = <&led_0>;
+		pinctrl-0 = <&power_led>;
 
 		led-0 {
 			color = <LED_COLOR_ID_GREEN>;
@@ -306,13 +306,13 @@ &pcie2x1l2 {
 
 &pinctrl {
 	keys {
-		btn_0: button-0 {
+		pwm15_ir_m1: pwm15-ir-m1 {
 			rockchip,pins = <4 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
 
 	leds {
-		led_0: led-0 {
+		power_led: power-led {
 			rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
@@ -328,19 +328,19 @@ pcie20x1_2_perstn_m0: pcie-2 {
 	};
 
 	regulators {
-		vcc_5v0_pwren_h: regulator-5v0-1 {
+		vcc_5v0_pwren_h: vcc-5v0-pwren-h {
 			rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
 
 	rtc {
-		rtc_int_l: rtc-0 {
+		rtc_int_l: rtc-int-l {
 			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
 
 	usb {
-		usb_otg_pwren_h: regulator-5v0-0 {
+		usb_otg_pwren_h: usb-otg-pwren-h {
 			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
 	};
-- 
2.25.1

Re: [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C

[FUKAUMI Naoki]

Hi Chukun,

On 8/16/25 17:00, Chukun Pan wrote:
> Updated the pinctrl names of the user key and power LED according
> to the schematic. Also updated the nodenames of other pinctrls.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 4a3ae95f122f..f93b129a0032 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -42,7 +42,7 @@ button-0 {
>   	keys-1 {
>   		compatible = "gpio-keys";
>   		pinctrl-names = "default";
> -		pinctrl-0 = <&btn_0>;
> +		pinctrl-0 = <&pwm15_ir_m1>;
>   
>   		button-1 {
>   			label = "User";
> @@ -55,7 +55,7 @@ button-1 {
>   	leds-0 {
>   		compatible = "gpio-leds";
>   		pinctrl-names = "default";
> -		pinctrl-0 = <&led_0>;
> +		pinctrl-0 = <&power_led>;
>   
>   		led-0 {
>   			color = <LED_COLOR_ID_GREEN>;
> @@ -306,13 +306,13 @@ &pcie2x1l2 {
>   
>   &pinctrl {
>   	keys {
> -		btn_0: button-0 {
> +		pwm15_ir_m1: pwm15-ir-m1 {

"The name of a node should be somewhat generic".

  https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst?plain=1#L193
  https://lore.kernel.org/all/20241216113052.15696-1-naoki@radxa.com/T/#u

(I don't understand why this only applies to me...)

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   			rockchip,pins = <4 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
>   		};
>   	};
>   
>   	leds {
> -		led_0: led-0 {
> +		power_led: power-led {
>   			rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
>   		};
>   	};
> @@ -328,19 +328,19 @@ pcie20x1_2_perstn_m0: pcie-2 {
>   	};
>   
>   	regulators {
> -		vcc_5v0_pwren_h: regulator-5v0-1 {
> +		vcc_5v0_pwren_h: vcc-5v0-pwren-h {
>   			rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
>   		};
>   	};
>   
>   	rtc {
> -		rtc_int_l: rtc-0 {
> +		rtc_int_l: rtc-int-l {
>   			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
>   		};
>   	};
>   
>   	usb {
> -		usb_otg_pwren_h: regulator-5v0-0 {
> +		usb_otg_pwren_h: usb-otg-pwren-h {
>   			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
>   		};
>   	};

Re: [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C

[Chukun Pan]

Hi,

> "The name of a node should be somewhat generic".
>
>   https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst?plain=1#L193

Usually we use the name on the schematic. For example, the patch for e24c:

https://lore.kernel.org/lkml/20250727144409.327740-4-jonas@kwiboo.se/

```
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&gpio0_a0_user>;
```

If this is incorrect, I will abandon the pinctrl changes for
the user key and power LED.

> > -		vcc_5v0_pwren_h: regulator-5v0-1 {
> > -		usb_otg_pwren_h: regulator-5v0-0 {

But I don't think the above is correct.

>   https://lore.kernel.org/all/20241216113052.15696-1-naoki@radxa.com/T/#u
>
> (I don't understand why this only applies to me...)

I don't know this. I thought the nodenames of pinctrl and regulator
were a bit weird, so I changed the pinctrl's.

Thanks,
Chukun

--
2.25.1

Re: [PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C

[FUKAUMI Naoki]

Hi Chukun,

On 8/20/25 00:00, Chukun Pan wrote:
> Hi,
> 
>> "The name of a node should be somewhat generic".
>>
>>    https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst?plain=1#L193
> 
> Usually we use the name on the schematic. For example, the patch for e24c:

I don't mind using names that match the schematic, as long as the device 
tree maintainer doesn't object.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> https://lore.kernel.org/lkml/20250727144409.327740-4-jonas@kwiboo.se/
> 
> ```
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio0_a0_user>;
> ```
> 
> If this is incorrect, I will abandon the pinctrl changes for
> the user key and power LED.
> 
>>> -		vcc_5v0_pwren_h: regulator-5v0-1 {
>>> -		usb_otg_pwren_h: regulator-5v0-0 {
> 
> But I don't think the above is correct.
> 
>>    https://lore.kernel.org/all/20241216113052.15696-1-naoki@radxa.com/T/#u
>>
>> (I don't understand why this only applies to me...)
> 
> I don't know this. I thought the nodenames of pinctrl and regulator
> were a bit weird, so I changed the pinctrl's.
> 
> Thanks,
> Chukun
> 
> --
> 2.25.1
> 
> 
>