From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3649C48BF6 for ; Mon, 26 Feb 2024 17:03:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74BscvMN5cYsTQuE4Ftnu1AkWMnFbuWtgcy7Q9hVGq8=; b=sCvzyVJNHscpk2 M7aon+KB1I4aAbJWZ44Ny8jWU3FsWJLh0rq7PDfwpLJe7z1zM5x8GJ42aiYJes6AQIOqpwHRDJqrS J/bXbS7a5X9CuYjTYzrwQuTtHZjVp/YCHZvyZu4NG/LuErFiqTiNzR+XZ9jwwkKl7HMS81u6NNrn8 jkb0aHg1YRsz+9McjJNQuGykIAz+I414of3DKPvQYN/KvWULq4eK84k99k8HICMpVY1peplLzSFrc pk9N3xWe82x3GJOl8QV3gKeVG1nkIfkENZnYlynvPoebYm3lY1YGr2PDmQoq/hFTMBR/hZqQ7PCiV DVqxVemBeIeEyX70Epag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reeNQ-00000001oJH-2FfG; Mon, 26 Feb 2024 17:02:52 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reeNO-00000001oIJ-0yHo for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 17:02:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1708966970; x=1740502970; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PtOqPsnVzJ1VY1JY7qLS12ZY7lQ1eJRkNRobbhPJDEY=; b=iuR2Ahi0hrCB119jJZisnl2hGZSwM3dafWAy8Ix/kugo8P4qStqXfl2s 3c+al/Yrd2cpRj/qXjwXyYxd3+EuqLkx9OjoJoRr0Kdmz8sh6Csep2Lq+ 9zg0j+h4TxnI0cAOrVLpD7pTUzmedRvYMHLhUb5iPsDP8magYwzR7DKXg TAlL3LjsYPXYNA2MJR6MSDYuaJYgGO/X1eVBfbi3vGNw9mvXXYD7z6qJJ G5+W945+0qb3kfupVBQGzm3UCQAswXLnYA6E9zinVPZp72UEKQDM5Uvno tPmg2aiODER6CVMuAl3w44qCJolSsmTL1bXw57nIuIyYQBNJyW+8fXXjI Q==; X-CSE-ConnectionGUID: +usMHQQ3RByG3mwbmXRohw== X-CSE-MsgGUID: Coq3DASSR1qrFD28x3eO4g== X-IronPort-AV: E=Sophos;i="6.06,186,1705388400"; d="scan'208";a="16839304" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Feb 2024 10:02:45 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 26 Feb 2024 10:02:37 -0700 Received: from [10.159.245.205] (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 26 Feb 2024 10:02:36 -0700 Message-ID: <798ca59b-5d91-41b4-a49f-1f11af14e7ee@microchip.com> Date: Mon, 26 Feb 2024 18:01:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7 Content-Language: en-US, fr-FR To: Varshini Rajendran , , , , CC: Claudiu Beznea References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172722.672592-1-varshini.rajendran@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: <20240223172722.672592-1-varshini.rajendran@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_090250_433775_5AE34296 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/02/2024 at 18:27, Varshini Rajendran - I67070 wrote: > Add support for SAM9X7 SoC in the SoC driver. > > Signed-off-by: Varshini Rajendran > Reviewed-by: Claudiu Beznea > --- > Changes in v4: > - Sorted the entries alphabetically as per comment from Claudiu > - Updated EXID > Note: Did not remove the Reviewed-by tag since the changes were only > cosmetic and did not affect functionality > --- > drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++ > drivers/soc/atmel/soc.h | 9 +++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > index cc9a3e107479..cae3452cbc60 100644 > --- a/drivers/soc/atmel/soc.c > +++ b/drivers/soc/atmel/soc.c > @@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = { > AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH, > "sam9x60 8MiB SDRAM SiP", "sam9x60"), > #endif > +#ifdef CONFIG_SOC_SAM9X7 > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH, > + "sam9x72", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH, > + "sam9x70", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 1Gb DDR3L SiP ", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 512Mb DDR2 SiP", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 128Mb DDR2 SiP", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 2Gb DDR3L SiP", "sam9x7"), (as highlighted in previous review of this patch): https://lore.kernel.org/linux-arm-kernel/20230728102905.267131-1-varshini.rajendran@microchip.com/T/#m2dac0ce9e1991c3d714785062a76ccdce11a02a6 I want RAM size in Bytes. Sorry but NACK. Best regards, Nicolas > +#endif > #ifdef CONFIG_SOC_SAMA5 > AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH, > diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h > index 7a9f47ce85fb..fc4157c5f6e3 100644 > --- a/drivers/soc/atmel/soc.h > +++ b/drivers/soc/atmel/soc.h > @@ -44,6 +44,7 @@ at91_soc_init(const struct at91_soc *socs); > #define AT91SAM9X5_CIDR_MATCH 0x019a05a0 > #define AT91SAM9N12_CIDR_MATCH 0x019a07a0 > #define SAM9X60_CIDR_MATCH 0x019b35a0 > +#define SAM9X7_CIDR_MATCH 0x09750020 > #define SAMA7G5_CIDR_MATCH 0x00162100 > > #define AT91SAM9M11_EXID_MATCH 0x00000001 > @@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs); > #define SAMA7G54_D2G_EXID_MATCH 0x00000020 > #define SAMA7G54_D4G_EXID_MATCH 0x00000028 > > +#define SAM9X70_EXID_MATCH 0x00000005 > +#define SAM9X72_EXID_MATCH 0x00000004 > +#define SAM9X75_D1G_EXID_MATCH 0x00000018 > +#define SAM9X75_D2G_EXID_MATCH 0x00000020 > +#define SAM9X75_D1M_EXID_MATCH 0x00000003 > +#define SAM9X75_D5M_EXID_MATCH 0x00000010 > +#define SAM9X75_EXID_MATCH 0x00000000 > + > #define AT91SAM9XE128_CIDR_MATCH 0x329973a0 > #define AT91SAM9XE256_CIDR_MATCH 0x329a93a0 > #define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel