From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 25 Nov 2014 21:59:11 +0100 Subject: [PATCH] ARM: orion: convert the irq_reg_{readl, writel} calls to the new API In-Reply-To: References: <1416928752-24529-1-git-send-email-gregory.clement@free-electrons.com> Message-ID: <7996382.czGPtzUmj4@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 25 November 2014 12:24:16 Olof Johansson wrote: > On Tue, Nov 25, 2014 at 7:19 AM, Gregory CLEMENT > wrote: > > The commit "genirq: Generic chip: Change irq_reg_{readl,writel} > > arguments" modified the API. In the same tome the > > arch/arm/plat-orion/gpio.c file received a fix with the use of the old > > API: "ARM: orion: Fix for certain sequence of request_irq can cause > > irq storm". This commit fixes the use of the API. > > > > Signed-off-by: Gregory CLEMENT > > --- > > Hi Jason, > > > > This patch fix a build error in linux-next: > > > > arch/arm/plat-orion/gpio.c:509:12: error: too few arguments to function 'irq_reg_readl' > > arch/arm/plat-orion/gpio.c:511:2: error: too few arguments to function 'irq_reg_writel' > > arch/arm/plat-orion/gpio.c:523:12: error: too few arguments to function 'irq_reg_readl' > > arch/arm/plat-orion/gpio.c:525:2: error: too few arguments to function 'irq_reg_writel' > > > > But if we want to apply it on the mvebu branch we need to add a > > dependecy to "332fd7c4fef5 genirq: Generic chip: Change > > irq_reg_{readl,writel} arguments" > > Please take this through the same repo as the change in the prototype: > > Acked-by: Olof Johansson > As mentioned before, the problem here is that the prototype gets changed in the irqchip repo, while the gpio driver only starts using this interface in the mvebu repo. Both trees are owned by Jason, so he should be able to find a solution though. Arnd