From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dhruva Gole <d-gole@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kendall Willis <k-willis@ti.com>,
Sebin Francis <sebin.francis@ti.com>, Bryan Brattlof <bb@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] cpufreq: ti-cpufreq: add support for AM62L3 SoC
Date: Fri, 16 Jan 2026 10:16:55 +0100 [thread overview]
Message-ID: <79d0f072-80f9-4757-b25d-84260551e217@kernel.org> (raw)
In-Reply-To: <20260116-am62l-cpufreq-v1-2-63d062317ae9@ti.com>
On 16/01/2026 10:01, Dhruva Gole wrote:
> Add CPUFreq support for the AM62L3 SoC with the appropriate
> AM62L3 speed grade constants according to the datasheet [1].
>
> This follows the same architecture-specific implementation pattern
> as other TI SoCs in the AM6x family.
>
> [1] https://www.ti.com/lit/pdf/SPRSPA1
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> drivers/cpufreq/ti-cpufreq.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 6ee76f5fe9c567b0b88797ddb51764a2a5606b16..8d8fdb068dcdc2caa0b656405f38a072c0700f71 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -48,6 +48,12 @@
> #define AM625_SUPPORT_S_MPU_OPP BIT(1)
> #define AM625_SUPPORT_T_MPU_OPP BIT(2)
>
> +#define AM62L3_EFUSE_E_MPU_OPP 5
> +#define AM62L3_EFUSE_O_MPU_OPP 15
> +
> +#define AM62L3_SUPPORT_E_MPU_OPP BIT(0)
> +#define AM62L3_SUPPORT_O_MPU_OPP BIT(1)
> +
> enum {
> AM62A7_EFUSE_M_MPU_OPP = 13,
> AM62A7_EFUSE_N_MPU_OPP,
> @@ -213,6 +219,22 @@ static unsigned long am625_efuse_xlate(struct ti_cpufreq_data *opp_data,
> return calculated_efuse;
> }
>
> +static unsigned long am62l3_efuse_xlate(struct ti_cpufreq_data *opp_data,
> + unsigned long efuse)
> +{
> + unsigned long calculated_efuse = AM62L3_SUPPORT_E_MPU_OPP;
> +
> + switch (efuse) {
> + case AM62L3_EFUSE_O_MPU_OPP:
> + calculated_efuse |= AM62L3_SUPPORT_O_MPU_OPP;
> + fallthrough;
> + case AM62L3_EFUSE_E_MPU_OPP:
> + calculated_efuse |= AM62L3_SUPPORT_E_MPU_OPP;
> + }
> +
> + return calculated_efuse;
> +}
> +
> static struct ti_cpufreq_soc_data am3x_soc_data = {
> .efuse_xlate = amx3_efuse_xlate,
> .efuse_fallback = AM33XX_800M_ARM_MPU_MAX_FREQ,
> @@ -315,6 +337,7 @@ static const struct soc_device_attribute k3_cpufreq_soc[] = {
> { .family = "AM62AX", },
> { .family = "AM62PX", },
> { .family = "AM62DX", },
> + { .family = "AM62LX", },
So you just stuff at the end in every commit leading to unnecessary risk
of conflicts.
> { /* sentinel */ }
> };
>
> @@ -327,6 +350,14 @@ static struct ti_cpufreq_soc_data am625_soc_data = {
> .quirks = TI_QUIRK_SYSCON_IS_SINGLE_REG,
> };
>
> +static struct ti_cpufreq_soc_data am62l3_soc_data = {
> + .efuse_xlate = am62l3_efuse_xlate,
> + .efuse_offset = 0x0,
> + .efuse_mask = 0x07c0,
> + .efuse_shift = 0x6,
> + .multi_regulator = false,
> +};
> +
> static struct ti_cpufreq_soc_data am62a7_soc_data = {
> .efuse_xlate = am62a7_efuse_xlate,
> .efuse_offset = 0x0,
> @@ -463,6 +494,7 @@ static const struct of_device_id ti_cpufreq_of_match[] __maybe_unused = {
> { .compatible = "ti,am625", .data = &am625_soc_data, },
> { .compatible = "ti,am62a7", .data = &am62a7_soc_data, },
> { .compatible = "ti,am62d2", .data = &am62a7_soc_data, },
> + { .compatible = "ti,am62l3", .data = &am62l3_soc_data, },
Oh no, here it is correct. Random choices?
> { .compatible = "ti,am62p5", .data = &am62p5_soc_data, },
> /* legacy */
> { .compatible = "ti,omap3430", .data = &omap34xx_soc_data, },
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 9:01 [PATCH 0/3] cpufreq: ti: Add support for AM62L3 SoC Dhruva Gole
2026-01-16 9:01 ` [PATCH 1/3] cpufreq: dt-platdev: Add ti,am62l3 to blocklist Dhruva Gole
2026-01-16 9:16 ` Krzysztof Kozlowski
2026-01-16 10:06 ` Dhruva Gole
2026-01-16 10:22 ` Krzysztof Kozlowski
2026-01-16 9:01 ` [PATCH 2/3] cpufreq: ti-cpufreq: add support for AM62L3 SoC Dhruva Gole
2026-01-16 9:16 ` Krzysztof Kozlowski [this message]
2026-01-16 10:08 ` Dhruva Gole
2026-01-16 9:01 ` [PATCH 3/3] arm64: dts: ti: k3-am62l: support cpufreq Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d0f072-80f9-4757-b25d-84260551e217@kernel.org \
--to=krzk@kernel.org \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sebin.francis@ti.com \
--cc=vigneshr@ti.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox