From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D361C7EE23 for ; Mon, 5 Jun 2023 15:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TtZEfgPgx1Tmgh+xqp4HGSHh6//nnHO4P+50LnmFxMc=; b=jSzPt6n4vCjjxQ /vSwgbVv7b0DaIAFtu0YR5s0lpAfeZbpgZ9YZ2+jZzyCUEkMU/g4N0/wwR+3B/fhi652CgNVyi29P Sj7NqSygb0FWcDmHXlCZcs1Ie2QT7MxEVmuFX5+BKCkvxDW5nc+rSeK6lrn18LOsPVTRpGLcPZR88 k8xs2IEGBl7+Evl+ZY9knO8TosdU6YvVauzO2xnHzLsFt/Y4WuOfnpqYWGF/DywdoXugZmHcNcLOe WZuURN7QPx7LxfI0EEOmPreUrqkHNkPYsCK6TJLjT+p4AXXuwBVDAweRczYXAqtiOTjnjsbbuG3mz VYqq81v0n0WpzqCLTElQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6Bnr-00Fu4C-07; Mon, 05 Jun 2023 15:07:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6Bnn-00Fu34-0O for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 15:07:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60B7FD75; Mon, 5 Jun 2023 08:08:03 -0700 (PDT) Received: from [10.57.85.135] (unknown [10.57.85.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BED333F663; Mon, 5 Jun 2023 08:07:14 -0700 (PDT) Message-ID: <79f43d6b-7407-56c5-3c7d-c8fc48625e95@arm.com> Date: Mon, 5 Jun 2023 16:07:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/3] arm64: Add a capability for FEAT_BBM level 2 Content-Language: en-GB To: Colton Lewis , kvm@vger.kernel.org Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Ricardo Koller References: <20230602170147.1541355-1-coltonlewis@google.com> <20230602170147.1541355-2-coltonlewis@google.com> From: Robin Murphy In-Reply-To: <20230602170147.1541355-2-coltonlewis@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_080723_206391_9E8D344F X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-06-02 18:01, Colton Lewis wrote: > From: Ricardo Koller > > Add a new capability to detect "Stage-2 Translation table > break-before-make" (FEAT_BBM) level 2. Why does this patch invent spurious "stage 2" references everywhere? The full name of FEAT_BBM is "Translation table break-before-make levels", and it is not specific to one stage of translation. Thanks, Robin. > Signed-off-by: Ricardo Koller > --- > arch/arm64/kernel/cpufeature.c | 11 +++++++++++ > arch/arm64/tools/cpucaps | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index c331c49a7d19c..c538060f7f66b 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2455,6 +2455,17 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .min_field_value = 1, > .matches = has_cpuid_feature, > }, > + { > + .desc = "Stage-2 Translation table break-before-make level 2", > + .type = ARM64_CPUCAP_SYSTEM_FEATURE, > + .capability = ARM64_HAS_STAGE2_BBM2, > + .sys_reg = SYS_ID_AA64MMFR2_EL1, > + .sign = FTR_UNSIGNED, > + .field_pos = ID_AA64MMFR2_EL1_BBM_SHIFT, > + .field_width = 4, > + .min_field_value = 2, > + .matches = has_cpuid_feature, > + }, > { > .desc = "TLB range maintenance instructions", > .capability = ARM64_HAS_TLB_RANGE, > diff --git a/arch/arm64/tools/cpucaps b/arch/arm64/tools/cpucaps > index 40ba95472594d..010aca1892642 100644 > --- a/arch/arm64/tools/cpucaps > +++ b/arch/arm64/tools/cpucaps > @@ -41,6 +41,7 @@ HAS_PAN > HAS_RAS_EXTN > HAS_RNG > HAS_SB > +HAS_STAGE2_BBM2 > HAS_STAGE2_FWB > HAS_TIDCP1 > HAS_TLB_RANGE > -- > 2.41.0.rc0.172.g3f132b7071-goog > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel