From: Eric Sandeen <sandeen@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig
Date: Mon, 24 Feb 2020 16:58:20 -0800 [thread overview]
Message-ID: <79faa339-d6b8-d8eb-0857-7d755a780805@redhat.com> (raw)
In-Reply-To: <20200225005553.GD6740@magnolia>
On 2/24/20 4:55 PM, Darrick J. Wong wrote:
> On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote:
>> The old ARM OABI's structure alignment quirks break xfs disk structures,
>> let's just move on and disallow it rather than playing whack-a-mole
>> for the infrequent times someone selects this old config, which is
>> usually during "make randconfig" tests.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
>> index e685299eb3d2..043624bd4ab2 100644
>> --- a/fs/xfs/Kconfig
>> +++ b/fs/xfs/Kconfig
>> @@ -2,6 +2,8 @@
>> config XFS_FS
>> tristate "XFS filesystem support"
>> depends on BLOCK
>> + # We don't support OABI structure alignment on ARM
>
> Should this limitation be documented in the help screen?
Yeah probably.
But now looking at
aa2dd0ad4d6d xfs: remove __arch_pack
hch indicates that some non-arm architectures have similar problems,
so is there any point to excluding this one config on this one arch?
-Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-25 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 0:49 [PATCH] xfs: mark ARM OABI as incompatible in Kconfig Eric Sandeen
2020-02-25 0:55 ` Darrick J. Wong
2020-02-25 0:58 ` Eric Sandeen [this message]
2020-02-25 17:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79faa339-d6b8-d8eb-0857-7d755a780805@redhat.com \
--to=sandeen@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox