From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 230CDC433EF for ; Tue, 26 Apr 2022 07:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JP+gZ3zbxMt8Z90xNf2Fk3Uw9C/kMD+fZFvbdYQ680Q=; b=UFkvQnw3VTobgz UCdilq1v/HIMb+aXnAiK9YHDgA39XiKt6LREaOF0+8+9l6E8+LH10Yiq4xFSpe21bM+UwR6xt5uBy yoUXupDjLkjXADjDSrN95CfeTp30v//zXt0wumEJx0U8t0R3RSsqLX/e6i9Htzhf7p1+edjl5JU/w l9P6iZ63J2RYgcWuay4g7Ri+dAh2UTDgrJC87ySHaBG732PXF7xDoTVwdWS1TvEcAzYMLN02fzHcC wAaeAB9sbfmUAZhp6zsbrdZI72d/W3YmZuwWW5dXSy1eRwsmintxeu0HAfvquPYxD7+SKBfXbrwV+ H/oQQBFeQJOmdMN71VsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njFkt-00D0QX-3k; Tue, 26 Apr 2022 07:37:03 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njFk0-00CzyF-Jj for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 07:36:12 +0000 Received: from kwepemi500013.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KnYTw3jHmzCsQV; Tue, 26 Apr 2022 15:31:32 +0800 (CST) Received: from [10.67.111.192] (10.67.111.192) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 15:36:02 +0800 Message-ID: <79fe5bb5-c55c-7ddc-640f-50bf8bea7f0b@huawei.com> Date: Tue, 26 Apr 2022 15:36:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH bpf-next v3 2/7] ftrace: Fix deadloop caused by direct call in ftrace selftest Content-Language: en-US To: Steven Rostedt CC: , , , , , Catalin Marinas , Will Deacon , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , , , Shuah Khan , Jakub Kicinski , Jesper Dangaard Brouer , Mark Rutland , Pasha Tatashin , Ard Biesheuvel , Daniel Kiss , Steven Price , Sudeep Holla , Marc Zyngier , Peter Collingbourne , Mark Brown , Delyan Kratunov , Kumar Kartikeya Dwivedi References: <20220424154028.1698685-1-xukuohai@huawei.com> <20220424154028.1698685-3-xukuohai@huawei.com> <20220425110512.538ce0bf@gandalf.local.home> From: Xu Kuohai In-Reply-To: <20220425110512.538ce0bf@gandalf.local.home> X-Originating-IP: [10.67.111.192] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500013.china.huawei.com (7.221.188.120) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_003609_118089_719B3849 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/25/2022 11:05 PM, Steven Rostedt wrote: > On Sun, 24 Apr 2022 11:40:23 -0400 > Xu Kuohai wrote: > >> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c >> index abcadbe933bb..d2eff2b1d743 100644 >> --- a/kernel/trace/trace_selftest.c >> +++ b/kernel/trace/trace_selftest.c >> @@ -785,8 +785,24 @@ static struct fgraph_ops fgraph_ops __initdata = { >> }; >> >> #ifdef CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS >> +#ifdef CONFIG_ARM64 > > Please find a way to add this in arm specific code. Do not add architecture > defines in generic code. > > You could add: > > #ifndef ARCH_HAVE_FTRACE_DIRECT_TEST_FUNC > noinline __noclone static void trace_direct_tramp(void) { } > #endif > > here, and in arch/arm64/include/ftrace.h > > #define ARCH_HAVE_FTRACE_DIRECT_TEST_FUNC > > and define your test function in the arm64 specific code. > > -- Steve > > will move this to arch/arm64/ in v4, thanks. > > >> +extern void trace_direct_tramp(void); >> + >> +asm ( >> +" .pushsection .text, \"ax\", @progbits\n" >> +" .type trace_direct_tramp, %function\n" >> +" .global trace_direct_tramp\n" >> +"trace_direct_tramp:" >> +" mov x10, x30\n" >> +" mov x30, x9\n" >> +" ret x10\n" >> +" .size trace_direct_tramp, .-trace_direct_tramp\n" >> +" .popsection\n" >> +); >> +#else >> noinline __noclone static void trace_direct_tramp(void) { } >> #endif >> +#endif >> >> /* >> * Pretty much the same than for the function tracer from which the selftest > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel