From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3BFC43381 for ; Tue, 5 Mar 2019 16:35:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17F622082C for ; Tue, 5 Mar 2019 16:35:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F/dW97+j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F622082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=osukl.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=doekJtK+n6jfbv3MJVJsftybycBX1xGUCDfU263VoKc=; b=F/dW97+jZ9dryB w5kGZt+qqxcpN3s2qFpj+3qi2g1Yd5zANbr/J1XgmRHZvNdFYnXjMtPr3rELtly+jXamFu3sUIp/O 8X6HfM1y0XXnomazGE3K2sPgPhm3QGc/syDbOniEP2w5wpHrPKC0sXZL8drKSuO4Lrj7NNuaD+Ubs CJmit6KpElO06HXhgaCalFjFtGDUUnWCjfPrwMqv6M3ZXSU6RgKoCyVnCPX1snmbc1sjE6s26qU++ FhG5g3+215MMnh7wtZzkhF/d7avZ/i7z/A4BTIDBbkpbyQepJq1VrNjbDpbIROuIS8ub4nb98yDwx p1FRq8Jyr0c4gd+xbMHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1D2V-0004um-1j; Tue, 05 Mar 2019 16:35:35 +0000 Received: from mail.osukl.com ([81.134.89.156]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1D2K-0004tx-II for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 16:35:32 +0000 Received: from OS01.os.local ([fe80::dd48:92d6:34f3:22da]) by OS01.os.local ([fe80::dd48:92d6:34f3:22da%16]) with mapi id 14.03.0389.001; Tue, 5 Mar 2019 16:35:07 +0000 From: Ryan Pannell To: Jagan Teki , Maxime Ripard Subject: RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Thread-Topic: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Thread-Index: AQHUzZj1PzRBqQmkXEOapWN/my/XQKXzyHUAgAAMv4CAAw3CAIAAIXsAgAY5JYCAAAJsgIAABYNg Date: Tue, 5 Mar 2019 16:35:04 +0000 Message-ID: <7AB137701821F94BAF7B06C1747BA691011A3FE123@OS01.os.local> References: <20190226060240.8783-1-jagan@amarulasolutions.com> <20190226060240.8783-2-jagan@amarulasolutions.com> <20190227153346.dwd3stsbsvf7rwly@flea> <20190301145724.vhvyoqkkxdflg2g7@flea> <20190305155919.cm3yrve3vqp7jimh@flea> In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.16.61] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_083524_932512_2DC60209 X-CRM114-Status: GOOD ( 28.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-kernel , Chen-Yu Tsai , Rob Herring , Michael Trimarchi , "linux-amarula@amarulasolutions.com" , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org We don't mind if it has to be: compatible = "oceanic,5inmfd", "allwinner,sun50i-a64"; However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become: compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64"; Perhaps this solves the issue. Please let me know thoughts. Ryan Pannell Development Team Lead Oceanic Systems (UK) Ltd -----Original Message----- From: Jagan Teki Sent: 05 March 2019 16:08 To: Maxime Ripard Cc: Chen-Yu Tsai ; Rob Herring ; Mark Rutland ; Ryan Pannell ; Michael Trimarchi ; linux-arm-kernel ; devicetree ; linux-kernel ; linux-amarula@amarulasolutions.com Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support On Tue, Mar 5, 2019 at 9:29 PM Maxime Ripard wrote: > > On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote: > > On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard wrote: > > > > > > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote: > > > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote: > > > > > > Oceanic A64-5inMFD is a 5 inch Multi function display > > > > > > baseboard designed to mount SoPine SOM. > > > > > > > > > > > > Key features: > > > > > > - Allwinner A64 Cortex-A53 > > > > > > - Mali-400MP2 GPU > > > > > > - AXP803 PMIC > > > > > > - 2GB DDR3 RAM > > > > > > - SD Slot > > > > > > - SPI-NOR flash > > > > > > - EMAC, RTL8211E > > > > > > - MCP2515 CAN > > > > > > - MIPI-DSI > > > > > > - Goodix 911 CTP > > > > > > - USB Host > > > > > > - 12V DC power supply > > > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > > --- > > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++ > > > > > > 2 files changed, 47 insertions(+) create mode 100644 > > > > > > arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > > > > > > b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > index a5fb1eaa8acf..ec39fe856117 100644 > > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > @@ -2,6 +2,7 @@ > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb > > > > > > sun50i-a64-bananapi-m64-icn6211.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb > > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb diff > > > > > > --git > > > > > > a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt > > > > > > s > > > > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt > > > > > > s > > > > > > new file mode 100644 > > > > > > index 000000000000..d73d1f55acb9 > > > > > > --- /dev/null > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf > > > > > > +++ d.dts > > > > > > @@ -0,0 +1,46 @@ > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > > +/* > > > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd. > > > > > > + * Copyright (C) 2019 Amarula Solutions B.V. > > > > > > + * Author: Jagan Teki */ > > > > > > + > > > > > > +/dts-v1/; > > > > > > + > > > > > > +#include "sun50i-a64-sopine.dtsi" > > > > > > + > > > > > > +/ { > > > > > > + model = "Oceanic A64-5inMFD"; > > > > > > + compatible = "oceanic,a64-5inmfd", > > > > > > +"allwinner,sun50i-a64"; > > > > > > > > > > The name of the DT is Oceanic 5inMFD, while you call the board > > > > > A64-5inMFD here, which name is the actual name? > > > > > > > > Yes, this is something that we discussed during "Amarula A64-Relic" > > > > naming convention. > > > > > > > > Since these boards are not famous like teres-i we agreed to add > > > > vendor name after sun50i-a64- followed by real board name. > > > > > > > > Here A64 already covered during sun50i-a64- so the dts name > > > > simply the - > > > > > > For the DT name, yeah, we want that pattern. > > > > > > For the compatible and model, we want to use the model name. > > > > Entire model name after , ? > > > > model = "Oceanic A64-5inMFD"; > > compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64"; > > > > is this not sufficient? > > > > Let me understand with respective few existing stuff. > > > > model = "Amarula A64-Relic"; > > compatible = "amarula,a64-relic", "allwinner,sun50i-a64"; > > > > model = "Olimex A64 Teres-I" > > compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64"; > > This one is called the TERES-A64: > https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-s > ource-hardware > > The laptop is the Teres-I, it can have an A64 > > > model = "FriendlyARM NanoPi A64"; > > compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64"; > > NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html > > > model = "Olimex A64-Olinuxino"; > > compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64" > > A64-Olinuxino is the name of the board too: > https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-sourc > e-hardware > > > Would you comment, what is the different with respect to my change? > > If the name of the product is 5inMFD, then the model should be Oceanic > 5inMFD, and its compatible oceanic,5inmfd Oceanic seems to have some multiple Multi Function Devices, ie reason we prefer the product as 'A64-5inMFD' since it is A64 based. In this case the model and compatible should be fine I think? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel