From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F51C3DA79 for ; Mon, 15 Jan 2024 08:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OaDh7S6feJt1O+FpT7FSiil7/QydLdAN8PoaEfWcrFs=; b=xJE8KadWwbP34u BQaCiyW3POM6ZZX/ZIkxbWZhOPi2NvfVjw+/UE73ZKj4QbQVHIbwgq5WBKuIt0jc+SQQwzLyn0iyH tMpc2KR5Jfn8Qz5hH++9IHj2mcXt3+EBUJyFfc45+HSQVQDBfFZTmxHzsuwV3D5FJzO+vc+eJRs/H XAhcpCi9vo+UfPxzf/wJBVchhvZmMECvMKa1gskLq2HmLYdhCzaVf3eAQ/bR0R4VxfO6br9HNzg90 KXAMs+pXu6Cdo1ybxPNJSuFCDXBwRlEIMpXutUStcy6lRnrVDByhC+3QtJu7mOTKWUf54lue8+y4d ZsBRs59YdGrqbuBbw+Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPIky-008KE8-09; Mon, 15 Jan 2024 08:55:44 +0000 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPIku-008KCI-1b for linux-arm-kernel@lists.infradead.org; Mon, 15 Jan 2024 08:55:43 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1705308912; cv=none; d=strato.com; s=strato-dkim-0002; b=qjzfTZXIn8ULyATbJ8kYws4bzV++on2FpfW1SqbtHT2ZnlgpuuvjMFc9zWdYkSUb1P pflMhVIuUbCfLuoxbfOdW/zf8sM4TwYDjmW3ythMRZUO8lnVMlOM+QZSMHstRbG8VtiX 5pwr2BiVJ8tdtG3poAmvrV+xsIuYkRT1GgmC8BDbXpdWsN0ctXi7pD4TNEpj/lq2pZtL k5pdszBql0UT/kPieggXIZvTKJN+RftG6PAfZYMvuyDyo1qhrOsV6EbbV3/PajMnlMUp 1YUs2dJHnFqWnbil9Jo1DCF5ZxyOlev+0ttwdR9LtJTWIkOeqAavF9AGa1aW9v9FJ8+r UYYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1705308912; s=strato-dkim-0002; d=strato.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=yHFJRaGiqBFJv2kzsrvLiyk/a/j3+Epn1Hl4IwAPpOQ=; b=FczWUnwFJvS7KFS7oNsI/m5tBh2F7SkhYobWhH96170UEzMMHAY7/a2uyfmRbvRKow XxzFEyTyBSOpP3cF9pfgWkeza1nyq9zf9oi94YsTKyXshRdfn0d2e1F+xcLv8awnUM+t 23KGqjcyo8asdDAHzV7uXyl/kvjTh+b7fZuuWlVKtZu1rjuGlDcrRzDinWOIgoWMA5Wj BjA/4lR6aUUN4OyCAwPXkzDxTN3a2Q2m2k5Q1wNMeAa9JuH9RN0wdEAwdz/qZhjKuvPI 3BU/3b5PpiRq+EPUwQ3qjVOGVG+kh3rXnC5BHkVFSwaAoihtAP+/XoV4p90kDDcSAdoh GEiA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1705308912; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=yHFJRaGiqBFJv2kzsrvLiyk/a/j3+Epn1Hl4IwAPpOQ=; b=eSo9RdXWhAdoaMENfvhNPTzvKpEwOCUl0YycnoU2xzRMAOQMB9qGX0yeiCQFmhzBUq wtqDF7H9q9nFpN3AhXoAtzXmn353mljOaUrGVy5EQHo30O7NtvmPjMuX37RJgZbC6sND fRtz6wn5n3MdFHaakYwZD88U4bjAkBC5emYMKMDFoqqzbgcrbDVGevUornxZP935h3Cu tv41U+52zsH5KQm3PgvBNVFAjwQ7rqiUTmOaI152R9JDBW8y9aOthnrXVhPSOrkEfVnn LjPFWcJGYSWQ9UEoWZWcV1FktKs5lSlXM1XvdZO0b1hLY5YrsGsr5UvkO108hZlxyai4 634A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1705308912; s=strato-dkim-0003; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=yHFJRaGiqBFJv2kzsrvLiyk/a/j3+Epn1Hl4IwAPpOQ=; b=pFlSZHjwt8Te0l07++VZwoZT0mvrVr31djwxtUJKVo9l8cKGGgl9Ds9Oo6Q5eOqrsf 5kYGQb7B3DxK7iUUj3Bw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Apz9PSN6LgsXcGZhzY=" Received: from smtpclient.apple by smtp.strato.de (RZmta 49.10.2 DYNA|AUTH) with ESMTPSA id dbe64400F8tBUDl (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 15 Jan 2024 09:55:11 +0100 (CET) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 15 Jan 2024 09:55:00 +0100 Cc: Andrew Davis , Frank Binns , Donald Robson , Matt Coster , Adam Ford , Ivaylo Dimitrov , Maarten Lankhorst , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Paul Cercueil , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mips@vger.kernel.org Message-Id: <7BC64F03-A4DF-411F-9B6F-6BCA436D9B50@goldelico.com> References: <20240108183302.255055-1-afd@ti.com> <20240108183302.255055-5-afd@ti.com> <122DC5ED-2AA7-46A0-845F-083922458385@goldelico.com> To: Maxime Ripard X-Mailer: Apple Mail (2.3774.300.61.1.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240115_005540_865063_BA8BE234 X-CRM114-Status: GOOD ( 26.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > Am 15.01.2024 um 09:25 schrieb Maxime Ripard : > > Hi, > > On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote: >>> Am 08.01.2024 um 19:32 schrieb Andrew Davis : >>> >>> Add SGX GPU device entry to base OMAP4 dtsi file. >>> >>> Signed-off-by: Andrew Davis >>> --- >>> arch/arm/boot/dts/ti/omap/omap4.dtsi | 9 +++++---- >>> 1 file changed, 5 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/ti/omap/omap4.dtsi b/arch/arm/boot/dts/ti/omap/omap4.dtsi >>> index 2bbff9032be3e..559b2bfe4ca7c 100644 >>> --- a/arch/arm/boot/dts/ti/omap/omap4.dtsi >>> +++ b/arch/arm/boot/dts/ti/omap/omap4.dtsi >>> @@ -501,10 +501,11 @@ sgx_module: target-module@56000000 { >>> #size-cells = <1>; >>> ranges = <0 0x56000000 0x2000000>; >>> >>> - /* >>> - * Closed source PowerVR driver, no child device >>> - * binding or driver in mainline >>> - */ >>> + gpu@0 { >> >> I wonder why we don't add a "gpu:" label here. >> >> Almost all other subsystem nodes have one (e.g. emif:, aes:, dss:, dsi:, hdmi:, etc.), >> obviously for convenience when using a .dtsi file. >> >> It would allow a board-specific DTS to easily add status = "disabled" to avoid driver >> probing or disabling the GPU (e.g. if there is no display). > > There's no reason to disable it in the DT: the hardware block would > still be there and it's rendering to memory so it still could be useful. Well, if you know that the board does not have a dm3730 but a dm3725 without GPU it is better to disable the GPU completely instead of loading the driver and make it detect by some internal bits that it has no GPU on the SoC. > If there's no display on the board and you really don't want the GPU > driver, then you can disable the driver or block the module loading, but > it should be a distro / package / user decision, not a DT / kernel one > still. The same holds for aes: dss: dsi: hdmi: etc. If they are not used by some board file, they don't change a single bit of the DTB [1] which IMHO would be of reasonable concern to question additional labels. BR and thanks, Nikolaus [1] https://devicetree-specification.readthedocs.io/en/stable/source-language.html "Labels are only used in the devicetree source format and are not encoded into the DTB binary." _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel