From: Artur Weber <aweber.kernel@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Christian Daudt <bcm@fixthebug.org>,
Sherman Yin <syin@broadcom.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stanislav Jakubek <stano.jakubek@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/7] pinctrl: bcm281xx: Fix incorrect regmap max_registers value
Date: Fri, 14 Feb 2025 19:32:56 +0100 [thread overview]
Message-ID: <7a055e68-e72a-407b-bcf0-5f2ac43929f7@gmail.com> (raw)
In-Reply-To: <CACRpkdbwVdEa_xgR=wRfkPN2_tpYGnbdpQkTtvgDMRSKPT-GEQ@mail.gmail.com>
On 14.02.2025 10:03, Linus Walleij wrote:
> On Fri, Feb 7, 2025 at 9:02 PM Artur Weber <aweber.kernel@gmail.com> wrote:
>
>> The max_registers value does not take into consideration the stride;
>> currently, it's set to the number of the last pin, but this does not
>> accurately represent the final register.
>>
>> Fix this by multiplying the current value by 4.
>>
>> Fixes: 54b1aa5a5b16 ("ARM: pinctrl: Add Broadcom Capri pinctrl driver")
>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
>
> This looks like it could be causing regressions so I pulled this patch out
> and applied it for fixes.
Thanks. I assume this means this patch can be dropped from the next version
of this patchset now? If so, which branch contains the patch so that I can
rebase the next version of this patchset on it? I've checked the "fixes",
"devel" and "for-next" branches of linux-pinctrl.git[1] but did not see it
in any of them.
Best regards
Artur
[1] https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=fixes
next prev parent reply other threads:[~2025-02-14 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 20:02 [PATCH 0/7] pinctrl: bcm281xx: Add support for BCM21664 pinmux Artur Weber
2025-02-07 20:02 ` [PATCH 1/7] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller Artur Weber
2025-02-12 18:17 ` Rob Herring
2025-02-07 20:02 ` [PATCH 2/7] pinctrl: bcm281xx: Fix incorrect regmap max_registers value Artur Weber
2025-02-14 9:03 ` Linus Walleij
2025-02-14 18:32 ` Artur Weber [this message]
2025-02-07 20:02 ` [PATCH 3/7] pinctrl: bcm281xx: Use "unsigned int" instead of bare "unsigned" Artur Weber
2025-02-07 20:02 ` [PATCH 4/7] pinctrl: bcm281xx: Provide pinctrl device info as OF platform data Artur Weber
2025-02-09 5:36 ` kernel test robot
2025-02-07 20:02 ` [PATCH 5/7] pinctrl: bcm281xx: Add support for BCM21664 pinmux Artur Weber
2025-02-07 20:02 ` [PATCH 6/7] ARM: dts: bcm2166x-common: Add pinctrl node Artur Weber
2025-02-07 20:02 ` [PATCH 7/7] ARM: dts: bcm2166x: Add bcm2166x-pinctrl DTSI Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a055e68-e72a-407b-bcf0-5f2ac43929f7@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=syin@broadcom.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).