From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8139CCFA13 for ; Thu, 26 Sep 2024 09:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8n4f/MNU6PdyrqjwwNR0UezilcDUrUATtxP6Vw3eAXQ=; b=Z6NZb0eQnP9oWW7LXZh3kNA7Q8 stJvPloHmIotbNdUtr7RlLx22BvyIlb7RaTOp5xJz04V8sHBdJilAorm4Fb0f3ot7VVx522hmAINn Irq9nut3XR/ljGyVlb3E+G99Vbi76L71kYn7tmf2HNFETP+BjX6DYH4EHUFz6XGzc59UOB9VMALoS ogqG/yI1Bhp9paK1JGvMxcwMbVE248fK2MdbIllSZUVdJ9fToOUd0k1Hik3eNU8ztFndfaRf2KfO+ 7vuIj0A/nVnSnYyXCWvvMum0uBSKHADmCEH4js8wLs+JfUhjZxQBGHtxRn+LlWO+nzaSBxF4M8RTY 4EZYXIGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stl7L-00000007x1G-2BFt; Thu, 26 Sep 2024 09:48:59 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stkx6-00000007ui1-3ei8; Thu, 26 Sep 2024 09:38:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1727343503; bh=7p82Z+0K/eh4XfuDiQGpTvGvbH3Kqj994es0zyo9h2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HZGLDGGcTzSqmFrsD6xl58A2Yj+XdU/wYAjesI8ExXUhHFBFFPXDYHLguwq/Qmh9j zhw+ZoLkrcGpwTWsV9LzzD0CUaZUKZI+6V4BbdiaAj0pKYa1PiFfBmgliB8/c74O0C j468Yl+8mDdbBU9b0OsZcPfwd5/CqnNCfp91OauB6YwsUc486MARmTYQPeIoweIgWU 5oG7xbgOX0pwfO0n2eJlL8gBwpwQKqaOZwoyWuaYbig1wcFpPn16FEGhIkSmsNqJgV qbopcnutnivTro5SNGl4CssyrbK3dO7XkhLD3qL+K1BvLqKxUpZW/jcUexE012XBoM elcSX6ScQOYFg== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 36D2117E10AF; Thu, 26 Sep 2024 11:38:22 +0200 (CEST) Message-ID: <7a1315ef-4be5-4528-858b-9f07c814636d@collabora.com> Date: Thu, 26 Sep 2024 11:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs To: Conor Dooley , Macpaul Lin Cc: moudy.ho@mediatek.com, macross.chen@mediatek.com, Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Alexandre Mergnat , Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , Chris-qj chen , MediaTek Chromebook Upstream , Chen-Yu Tsai References: <20240924103156.13119-1-macpaul.lin@mediatek.com> <20240924103156.13119-3-macpaul.lin@mediatek.com> <20240924-commute-collision-13ad39717d31@spud> <2821ef09-1b32-082d-69d1-e09a3a302447@mediatek.com> <20240925-satisfy-epidermal-bd414891479a@spud> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240925-satisfy-epidermal-bd414891479a@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_023825_134197_F17B86CE X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 25/09/24 16:34, Conor Dooley ha scritto: > On Wed, Sep 25, 2024 at 04:42:59PM +0800, Macpaul Lin wrote: >> >> On 9/25/24 00:00, Conor Dooley wrote: >>> On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del Regno wrote: >>>> Il 24/09/24 12:31, Macpaul Lin ha scritto: >>>>> The display node in mt8195.dtsi was triggering a CHECK_DTBS error due >>>>> to an excessively long 'clocks' property: >>>>> display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long >>>>> >>>>> To resolve this issue, add "maxItems: 3" to the 'clocks' property in >>>>> the DT schema. >>>>> >>>>> Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") >>>>> Signed-off-by: Macpaul Lin >>>>> --- >>>>> .../devicetree/bindings/display/mediatek/mediatek,split.yaml | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>>>> index e4affc854f3d..42d2d483cc29 100644 >>>>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>>>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>>>> @@ -57,6 +57,7 @@ properties: >>>>> clocks: >>>>> items: >>>>> - description: SPLIT Clock >>>> >>>> That's at least confusing (granted that it works) - either add a description for >>>> each clock and then set `minItems: 1` (preferred), or remove this "SPLIT Clock" >>>> description and allow a maximum of 3 clocks. >>>> >>>> Removing the description can be done - IMO - because "SPLIT Clock" is, well, >>>> saying that the SPLIT block gets a SPLIT clock ... stating the obvious, anyway. >>> >>> Right, but what are the other two new clocks? Are they as obvious? >>> There's no clock-names here to give any more information as to what the >>> other clocks are supposed to be. >>> >>> Kinda unrelated, but I think that "SPLIT Clock" probably isn't what the >>> name of the clock in the IP block is anyway, sounds more like the name >>> for it on the provider end.. >> >> Thanks for the suggestions. I think Moudy could help on the new fixes >> for both DT schem and mt8195.dtsi. This patch could be separated from >> origin patch set. > > Not sure what you mean about separating it, if you mean correcting the > description for the split clock sure. The other stuff I mentioned needs > to be resolved before I'm willing to ack this. He means separating this patch from the rest of the series that he pushed - which is okay, as it's a bit mixed anyway :-) Besides ... Moudy, can you please help to clarify the description of those clocks? Cheers, Angelo