From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22688EB64D9 for ; Mon, 10 Jul 2023 13:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=00W8s8TdOqmuFzJVxpU0xLxxTFAEjHBrXyWDyTPoCJc=; b=WJr4uNkdJSZQwS QI2ON7OmfDTZucSoSQ2+y7qWgy9H/dtTAK6K0bJ9Gm5oRlCiBZMEwmbdJNpAQBlOSa2mjanLKv73/ l2/ivwm14CN6xDDUI6qmBsxb/R0QVFXgv+G4FDuxQsCJJwU28J8OEJLCd4GKZcCPgQqHwo9ep8YiS yM/sKEejk+5l9sdIKITrIX2DJvFPXwCoKpv0QDDHyhkWECFx8BpHOFbmmlZeZK6+M/xQDY0dUyilj mJR/tWsI75Zb18z1kk38s0kVqkl0P2StF7/UMrmc177qEvuBYOOXoa310i1kx1utVvWewaAuyqnUr sz+/CpMjIZrfvCunhBJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIrDq-00BnFK-08; Mon, 10 Jul 2023 13:46:38 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIrDm-00BnEZ-0w for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 13:46:36 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E319286655; Mon, 10 Jul 2023 15:46:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1688996792; bh=Qlc3zZzq8dQ9cUEjb5aJKqAbARIkL5ACsA8xLeQzVpA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PVcy3gtRFT2E6fmy/7piUZru4p11r6ghrop85WAUKubG6RajhuXbU2u3FZHPieT+Q aakutPofWoYXlZMRMdPskpJEphTbQXHdT+JWf621tDSpWEcI/Uxr0q1timS2A4dxFi Fxlpr4qfhHLYkNUNm4M0OHd4vaNs3wpBHbjCTSYwlyRYqV6NIlNoFafIYZqaP+HlQH l5XYYy/+JpW1owP/jeIxl6DJNBSFFM8neCl6g7Cmes3BRiBBlhS9z37Wn1w2pKnbfK 6r9gCuC7/ciEqQYk2QfwoJ5W3O+cH0PFBbx+f11aybx2gnTZVg7y+A6+yQhKfFlQVI vw1uBVzxjoyGQ== Message-ID: <7a1d7a67-0a0c-8527-d430-30a1cb40de48@denx.de> Date: Mon, 10 Jul 2023 15:46:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Document fsl,startup-delay-ms Content-Language: en-US To: Krzysztof Kozlowski , linux-remoteproc@vger.kernel.org Cc: Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Mathieu Poirier , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230707232444.374431-1-marex@denx.de> <8f40484e-1721-a2bc-2344-f9e59e51a935@linaro.org> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_064634_615985_181A2E34 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/23 14:52, Krzysztof Kozlowski wrote: > On 10/07/2023 11:18, Marek Vasut wrote: >> On 7/10/23 10:12, Krzysztof Kozlowski wrote: >>> On 08/07/2023 01:24, Marek Vasut wrote: >>>> Document fsl,startup-delay-ms property which indicates how long >>>> the system software should wait until attempting to communicate >>>> with the CM firmware. This gives the CM firmware a bit of time >>>> to boot and get ready for communication. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Bjorn Andersson >>>> Cc: Conor Dooley >>>> Cc: Fabio Estevam >>>> Cc: Krzysztof Kozlowski >>>> Cc: Mathieu Poirier >>>> Cc: NXP Linux Team >>>> Cc: Peng Fan >>>> Cc: Pengutronix Kernel Team >>>> Cc: Rob Herring >>>> Cc: Sascha Hauer >>>> Cc: Shawn Guo >>>> Cc: devicetree@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-remoteproc@vger.kernel.org >>>> --- >>>> .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> index 0c3910f152d1d..c940199ce89df 100644 >>>> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml >>>> @@ -76,6 +76,11 @@ properties: >>>> This property is to specify the resource id of the remote processor in SoC >>>> which supports SCFW >>>> >>>> + fsl,startup-delay-ms: >>>> + default: 0 >>>> + description: >>>> + CM firmware start up delay. >>> >>> I don't see particular improvements from v2 and no responses addressing >>> my comment: >>> https://lore.kernel.org/all/20221102112451.128110-2-peng.fan@oss.nxp.com/ >> >> I wasn't aware of this being submitted before, esp. since I wrote the >> binding document from scratch. Which comment is not addressed, the type >> ref is not present and the sentence starts with caps, so what is missing ? > > > That the property looks like a hacky solution to some SW problem. Why > this delay should be different on different boards? It probably depends more on the CM4 firmware that is being launched. The ones I tested were fine with 50..500ms delay, but the delay was always needed. Sure, it is a defect of the NXP provided SDK firmware, but that may not be fixable in all cases. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel