From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Dharma Balasubiramani <dharma.b@microchip.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Arnd Bergmann <arnd@arndb.de>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Romain Sioen <romain.sioen@microchip.com>,
Ryan Wanner <Ryan.Wanner@microchip.com>,
Varshini Rajendran <Varshini.Rajendran@microchip.com>
Subject: Re: [PATCH] dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity
Date: Mon, 2 Sep 2024 17:10:05 +0200 [thread overview]
Message-ID: <7a4160cf-d170-4bbd-a4bc-da69c2c43d55@microchip.com> (raw)
In-Reply-To: <eb96bcf2-8bcd-4801-b381-96583d733b87@kernel.org>
On 31/08/2024 at 15:38, Krzysztof Kozlowski wrote:
> On 29/08/2024 11:57, Dharma Balasubiramani wrote:
>> From: Romain Sioen <romain.sioen@microchip.com>
>>
>> Document device tree binding of the Microchip SAMA7D65 Curiosity board.
>>
>> Signed-off-by: Romain Sioen <romain.sioen@microchip.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> ---
>> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> index 82f37328cc69..8e897680d43a 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
>> @@ -174,6 +174,13 @@ properties:
>> - const: atmel,sama5d4
>> - const: atmel,sama5
>>
>> + - description: Microchip SAMA7D65 Curiosity Board
>> + items:
>> + - const: microchip,sama7d65-curiosity
>> + - const: microchip,sama7d65
>> + - const: microchip,sama7d6
>> + - const: microchip,sama7
>> +
>
> No. This must go with the DTS.
>
> It's second patch you sent entirely split from the rest. That's not how
> upstreaming of DTS and drivers work.
Krzystof,
We have been upstreaming sam9x75 SoC and now are trying with sama7d65
SoC using a different approach.
It was mentioned to us to reduce the number of patches sent in a series,
convert the remaining DT bindings from txt to yaml (we had quite a few),
avoid generating new errors from the DT bot when sending new .dtsi/dts
files... So we're trying to comply to these (valid) requirements... But
well, it's not easy and I would like to emphasize that we are doing our
best to address most of the (sometimes contradictory) challenges.
So now, we're trying to be very minimal in what we're sending. Address
peripherals incrementally with trying to generate as few DT check errors
as possible. Trying this, we're facing chicken and eggs problems: How to
comply to a binding that is not yet accepted? How to organize
introduction of a new SoC with a limited number of patch in a series?
How to convert bindings to yaml and still be able to add new SoCs?
Be sure that we have been coordinating internally to be ready and send
these patch series together. We're a team and are splitting the
workload, I believe that it should be possible.
I feel that upstreaming a SoC is becoming overly difficult, and I added
quite a few to Mainline throughout the years.
Can you please let us post this minimal set of patch series, give you
the needed information and cross-reference links, but also understand
that we're adding pieces of a big puzzle that would require a bit of
flexibility?
Thanks for your understanding. Best regards,
Nicolas
next prev parent reply other threads:[~2024-09-02 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:57 [PATCH] dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity Dharma Balasubiramani
2024-08-29 16:14 ` Conor Dooley
2024-08-31 13:38 ` Krzysztof Kozlowski
2024-09-02 15:10 ` Nicolas Ferre [this message]
2024-09-02 16:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4160cf-d170-4bbd-a4bc-da69c2c43d55@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Ryan.Wanner@microchip.com \
--cc=Varshini.Rajendran@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romain.sioen@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).