From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE12AC46467 for ; Mon, 16 Jan 2023 10:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WoUnJBHJe5wm31DIFV5gywulJNAMIECXu1jjCXhHnlc=; b=YoaA1QLZyoqBYg mbJE4VszyA6f///srkTImyfkqogOEBUMI/TrGtn3ta6FJyK8nqgBr10rB9J0kALr4RhUZlVidzPZ2 SKM4sE9+Bj21/VgEXkRBsgZSKv6r/5yGej12pvIyI2SXkcjdGWC+SaI9pOMeDewaSbr/gn8byQzLL pwlbzcvxIcTnkmGHiziyOru2hxFl0A6vIAbdzmM3vrPwUXrUJOfwXAGPwrgHc8wFFd4GmBwUl2v1b 1J/lF39NT5T9Cn6SY/E/016+ee4qxb6dWcgEzX813XAnDMbsK2U+WbW2pjBMHZWsGNWyvCFUZ6FO8 6pMuKw5L4f6KQ5yPez5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHNAI-009oLv-NB; Mon, 16 Jan 2023 10:56:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHNAE-009oJR-3o for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 10:56:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9EE5AD7; Mon, 16 Jan 2023 02:57:08 -0800 (PST) Received: from [10.57.74.207] (unknown [10.57.74.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4E903F71A; Mon, 16 Jan 2023 02:56:25 -0800 (PST) Message-ID: <7a53ac6f-640b-436d-9bfa-3e49066b2460@arm.com> Date: Mon, 16 Jan 2023 10:56:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] iommu: Tidy up io-pgtable dependencies Content-Language: en-GB To: Conor Dooley Cc: joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, palmer@dabbelt.com References: <51d8c78e2ecc6696ac5907526580209ea6da167f.1673553587.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_025630_283853_F9CC45D2 X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-01-13 22:17, Conor Dooley wrote: > Hey Robin, > > On Thu, Jan 12, 2023 at 07:59:47PM +0000, Robin Murphy wrote: >> Some io-pgtable implementations, and thus their users too, carry a >> slightly odd dependency to get around the GENERIC_ATOMIC64 version of >> cmpxchg64() often failing to compile. Since this is a functional >> dependency, it's a bit misleading and untidy to tie it explicitly to >> COMPILE_TEST while assuming that it's also implied by the other >> platform/architecture options. Make things clearer by separating these >> functional dependencies into distinct statements from those controlling >> visibility, and since they do look a bit non-obvious to the uninitiated, >> also commenting them for good measure. >> >> Signed-off-by: Robin Murphy >> --- >> drivers/iommu/Kconfig | 18 ++++++++++++------ >> 1 file changed, 12 insertions(+), 6 deletions(-) > >> config IPMMU_VMSA >> bool "Renesas VMSA-compatible IPMMU" >> - depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) >> + depends on ARCH_RENESAS || COMPILE_TEST >> + depends on !GENERIC_ATOMIC64 # for IOMMU_IO_PGTABLE_LPAE >> select IOMMU_API >> select IOMMU_IO_PGTABLE_LPAE >> select ARM_DMA_USE_IOMMU > > This is a fix for the broken riscv32 allmodconfig stuff that Palmer > reported, right? Indirectly - that made it clear that the whole area was worth cleaning up in general, so I did this expecting to rebase it around one of the other fix patches, but none of those seem to have gone anywhere. In the meantime I guess it might now be simplest to apply Palmer's config workaround if you want something more expedient. Cheers, Robin. > https://lore.kernel.org/all/20221214180409.7354-1-palmer@rivosinc.com/ > > I did a dfn:drivers/iommu/Kconfig search on lore & saw this, but AFAICT > the patch was applied to next rather than fixes. > > Apologies if I'm off here, I have had that report in my follow-up-on > queue for a while & since Christmas happened in between I've lost track > of when the build failure was introduced. > > Last I remember, Guo Ren sent a patch that was not to your liking, but I > didn't see anything after that. > > Thanks, > Conor. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel