Re: [PATCH] drm: Drop ARCH_MULTIPLATFORM from dependencies

From: Javier Martinez Canillas <javierm@redhat.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Arnd Bergmann" <arnd@arndb.de>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	dri-devel@lists.freedesktop.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-samsung-soc@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Alain Volmat <alain.volmat@foss.st.com>,
	linux-arm-kernel@lists.infradead.org,
	Tomi Valkeinen <tomba@kernel.org>,
	Yannick Fertre <yannick.fertre@foss.st.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Philippe Cornu <philippe.cornu@foss.st.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] drm: Drop ARCH_MULTIPLATFORM from dependencies
Date: Tue, 10 Jan 2023 18:43:25 +0100	[thread overview]
Message-ID: <7a61ea5f-c6e0-1f6b-fc5c-40bdf2c6293e@redhat.com> (raw)
In-Reply-To: <20221210092155.elcuvcbb4ukktxjp@pengutronix.de>

On 12/10/22 10:21, Uwe Kleine-König wrote:
> Hello Arnd,
> 
> On Fri, Dec 09, 2022 at 11:53:49PM +0100, Arnd Bergmann wrote:
>> On Fri, Dec 9, 2022, at 23:05, Uwe Kleine-König wrote:
>>> Some of these dependencies used to be sensible when only a small part of
>>> the platforms supported by ARCH=arm could be compiled together in a
>>> single kernel image. Nowadays ARCH_MULTIPLATFORM is only used as a guard
>>> for kernel options incompatible with a multiplatform image. See commit
>>> 84fc86360623 ("ARM: make ARCH_MULTIPLATFORM user-visible") for some more
>>> details.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Makes sense,
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> Thanks. (But honestly I'm not surprised you agree to this patch after
> our conversation on irc :-)
>

This makes sense to me as well, but it would be great if someone else
from DRM can review/ack before pushing it.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

>>> diff --git a/drivers/gpu/drm/omapdrm/Kconfig 
>>> b/drivers/gpu/drm/omapdrm/Kconfig
>>> index 455e1a91f0e5..76ded1568bd0 100644
>>> --- a/drivers/gpu/drm/omapdrm/Kconfig
>>> +++ b/drivers/gpu/drm/omapdrm/Kconfig
>>> @@ -2,7 +2,7 @@
>>>  config DRM_OMAP
>>>  	tristate "OMAP DRM"
>>>  	depends on DRM && OF
>>> -	depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
>>> +	depends on ARCH_OMAP2PLUS
>>>  	select DRM_KMS_HELPER
>>>  	select VIDEOMODE_HELPERS
>>>  	select HDMI
>>
>> Since the original purpose of the ||ARCH_MULTIPLATFORM was to allow
>> building the driver on more targets, I wonder if we should instead
>> make that ||COMPILE_TEST, which would also allow building it on
>> x86 and others.
> 
> I wondered about that, too, but thought that would be a new patch.
>

Agreed that making it || COMPILE_TEST should be in a separate patch.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel