From: Josua Mayer <josua@solid-run.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/5] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings
Date: Sun, 24 Dec 2023 10:16:22 +0000 [thread overview]
Message-ID: <7a8f0c19-096c-4d29-a8b5-431f60601876@solid-run.com> (raw)
In-Reply-To: <44a1dab9-5fa9-4128-a5e5-c0deeeeebaab@linaro.org>
Am 24.12.23 um 10:10 schrieb Krzysztof Kozlowski:
> On 23/12/2023 22:29, Josua Mayer wrote:
>> Most arm board have a board-specific compatible string that allows e.g.
>> userspace to match specific firmware variants or apply specific
>> policies.
>>
>> Add board-specific properties to both variants of the Clearfog GTR:
>> - solidrun,clearfog-gtr-l8
>> - solidrun,clearfog-gtr-s4
>>
>> Introduction of a common parent (e.g. "solidrun,clearfog-gtr") is
>> omitted for brevity.
>> Since announcement of the two products no additional variants were added
>> it is assumed that there will always be just two.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>> arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts | 1 +
>> arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-s4.dts | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>> index 1990f7d0cc79..ae921a674c93 100644
>> --- a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>> +++ b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts
>> @@ -4,6 +4,7 @@
>>
>> / {
>> model = "SolidRun Clearfog GTR L8";
>> + compatible = "solidrun,clearfog-gtr-l8", "marvell,armada385", "marvell,armada380";
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
>
> I don't see them being documented.
Yes, checkpatch warned about that specifially, but I am not sure how to
proceed.
The armada-38x dt bindings documentation is stil in text format, and
doesn't document any board:
Documentation/devicetree/bindings/arm/marvell/armada-38x.txt
>
> Also, wrap at 80, as Linux coding style asks.
Will do.
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-24 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 21:29 [PATCH 0/5] arm: dts: marvell: clearfog-gtr: miscellaneous enhancements Josua Mayer
2023-12-23 21:29 ` [PATCH 1/5] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings Josua Mayer
2023-12-24 9:10 ` Krzysztof Kozlowski
2023-12-24 10:16 ` Josua Mayer [this message]
2023-12-24 10:52 ` Krzysztof Kozlowski
2023-12-24 12:39 ` Josua Mayer
2023-12-23 21:29 ` [PATCH 2/5] arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically Josua Mayer
2023-12-23 21:29 ` [PATCH 3/5] arm: dts: marvell: clearfog-gtr: fix various off-by-1 gpio numbers Josua Mayer
2023-12-24 10:11 ` Josua Mayer
2023-12-23 21:29 ` [PATCH 4/5] arm: dts: marvell: clearfog-gtr-l8: add support for second sfp connector Josua Mayer
2023-12-23 21:29 ` [PATCH 5/5] arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8f0c19-096c-4d29-a8b5-431f60601876@solid-run.com \
--to=josua@solid-run.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).