From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F029EC46CD3 for ; Sun, 24 Dec 2023 10:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qfEXmkabG2QW8GC6qoNphTlPn6Z/Jl8aZJEPRrX4ous=; b=CAucgcJ1UiwlVz +LCe3fBVhHmRx173CXHXtPjsLW+UQADeZawfrgsz+QZmB/Bbz/vVyqxw6t/KJWypUJd8AOegVO7Ig A03a3NEhlyOq2qy6ZdyiMu5FW0JodvEKUL1Mm7XSp1t940BIUvZLwZLnUXVzJeGYty7u4HslW7oyg KyiYm5EMkzfAx9GdWDngqfY5RAJF0dBg7sJhc5sMDnA7jictXbRHsZGP4nA82bxt4mhE162iOHKLW jGiRg7EUguhAUL5P1+HPanq7a+ypB1AhH7juKCBTQm3dcwQiayW6WoF4UxwO7JwXIbQj4UnB3INSB /iFl+rXhFZDXhv+C1j0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHLX9-0098xw-0T; Sun, 24 Dec 2023 10:16:35 +0000 Received: from mail-vi1eur04on0616.outbound.protection.outlook.com ([2a01:111:f400:fe0e::616] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHLX6-0098xU-19 for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2023 10:16:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D9HrPUa+lGgUxld88FF3n3gcsLNMY/XFA4c3fN6a6gEJvUqsjD9IlipEJFbxNY9O+nysGglFlDHm3Z4ZxeQi+8kDyFtxajIvfUUhPm3l0pd/C4/QyFo5sG5OlxQINmMTH/FcQ4aZmEVt1tuBB34ytOnKJfV3kqaDamCTaqROQPdo4LXvi//A3hKjK6l517Jxsw+GmVOAjIhYdZ5ylSNGw3KxkZBEyvG9lXmKohXCVxUn0+sio9vZ4Z5k/NQ+t+mZZuGCsR/6yUMlBXrABBcg5eXtFEHLykQKtjUf0l0m+CDd7OuKGIb3qhhGFKeSVS6ujV3h2GfPaiXAGdU4rmGf5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62I5sTQVGnevctiL0mKFLATYxdke7qg5Y5jmy3xbsV0=; b=Cfg/vzGdPJwnTjHgUOvfolvMTn60/oia+LcR7ay8abs3fxba+TrxHeW66k/qbejGOD1doP3GS29Js0CDxBSuHzacSsrSsh4PL0JobMZIKr9l7rB1Zqwy5m5/ykc/Neh7yrPYxiWdF/kXARGSWTziifhY68yt6UsadLJES9SsZAZn/8tzRSrLwh2jmN3BdPOjhRR5ERBGFzwza+CkCZhayF6/F/dZCTxtkBuK4bheuJaYysZw7qxLdhsK+ERsZpaRB/GYlbbuTBoElEYZRWoTNOh2hz1flY6mTox6T2qj8NOR3/KDKTe5G5O8Kfa+t4aVpMSf+iMLdcPT4ovL4RDq1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62I5sTQVGnevctiL0mKFLATYxdke7qg5Y5jmy3xbsV0=; b=EVtzrspOUZMBVv2eVTCUnLBcXDDnSeb10uwBA0u7cyMujG6vFvWc+9BNyx0s2oJB0aqd+3uHwL5oI9sXxcD9DRAkbRZeAnnzJvDkSgnxIMlNpV/RPdLrRir2Xpy70HkIYeS6wxxQHu466BNi7rhgl9bWfP6EDo1SV7Dr2jgU6IE= Received: from AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) by DB8PR04MB6811.eurprd04.prod.outlook.com (2603:10a6:10:fa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.24; Sun, 24 Dec 2023 10:16:22 +0000 Received: from AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::4db1:aae8:c643:2e73]) by AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::4db1:aae8:c643:2e73%6]) with mapi id 15.20.7113.023; Sun, 24 Dec 2023 10:16:22 +0000 From: Josua Mayer To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" CC: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH 1/5] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings Thread-Topic: [PATCH 1/5] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings Thread-Index: AQHaNeckWepWWarxsEuU4RY5/WiL2bC4JmKAgAASTAA= Date: Sun, 24 Dec 2023 10:16:22 +0000 Message-ID: <7a8f0c19-096c-4d29-a8b5-431f60601876@solid-run.com> References: <20231223212930.14624-1-josua@solid-run.com> <20231223212930.14624-2-josua@solid-run.com> <44a1dab9-5fa9-4128-a5e5-c0deeeeebaab@linaro.org> In-Reply-To: <44a1dab9-5fa9-4128-a5e5-c0deeeeebaab@linaro.org> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB8963:EE_|DB8PR04MB6811:EE_ x-ms-office365-filtering-correlation-id: 33f817a8-b3f0-4a84-fbdd-08dc04696122 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IbUTS5R/DmludS1Wy62sO0x20CXIk5yBw5sgmvPa81ZMXAFTbH8xEXiW9yrm2SZp9uMIVE0fLAoBISzhVSbcky6LtZ+0FjY7Nb4erFZK85rAylHiUde4Ptlj8PJAw7tlJF3/IBB1EQ2DAXp/h68nzuSHHHccsvGEDgnA4lgr4Xv5k2Jg3eHL3geVX8EkbSGYscHIuWMwiXtWwmxvD7u0gsEnyKDP++IDNaXiIYdqqVnIeNYlyuZEqPhTmzcwqHLFOfLl6uOXjfjZrEi2dvBws99vCVYEcMw5wYYax9lZrSSGAMeQB4VaA3sGkzZFq6eGGUwSDeJiQn7oQ5A61Ka0dbko8Au7KDYvTRbmPuBXeXnXfD5EEY6tIsHitID1+RBXocQ3Y6UbqLG4qnp1suxo12BJSpzQMsA2OaW8rhfjt0f54cjth5KrWsdD9iID/rstECtVZ6FDJBeoZJywT1tzLPya+EFFavFSfQIcEOVC30WREF1ALOFxERGOtdb3y2IBkrg760WGtTDN6aGPMM6r98ahjg7OmEYDWU34LpF2Nl7cRfH19/GNVOyX9tPn2kByxk/Ey4bjBCNr8nQRhH7bqlwc8bct76aERwhxJA11IlcDa1j1E5Xjwal4vMU5E0QBSRSmwcdBVVhE02Y6hiPvs0syivo7HYxlXlR8pqj8J6upkGfDlSLGpub1OZvhPYkn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8963.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(346002)(376002)(366004)(396003)(136003)(230922051799003)(230173577357003)(230273577357003)(1800799012)(64100799003)(451199024)(186009)(2906002)(71200400001)(6506007)(6486002)(478600001)(4326008)(8936002)(8676002)(66446008)(316002)(31696002)(91956017)(110136005)(64756008)(54906003)(76116006)(66556008)(66946007)(66476007)(5660300002)(86362001)(38070700009)(83380400001)(31686004)(36756003)(38100700002)(122000001)(41300700001)(2616005)(6512007)(26005)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWpEVlk1N09VYTJnVzRlL3l3dTZBVDlRd09PUlprbStUa0U4Smh6akROOC9w?= =?utf-8?B?WVl4R1o5ZDRod2hPdndCb1pwd3NRTVBEMFhDWVU1SlRKRXo3K0Q0TmRhQ3d6?= =?utf-8?B?Tk1Zbko3d2dJNlE5SW40eFJXQ3dBQ293ZEVkOUFSOHV2bUR1QTBhVzhqR3VM?= =?utf-8?B?YkxPVytUNHRiUUhqdFZ3azBKc2ozVVRyVzJpTmFoNHl6MDBmTWlXYVExVzRG?= =?utf-8?B?RlM3K1JZUEwrK01FWjVqVnhVQmdiQ3BtMjNEbjh3UkRTSFA4REV6TzFUZy8r?= =?utf-8?B?eDQveDJBcnp6R0V6U1lkRVBSaWNlUFRoZnRsc0NpSWQ0NDVhU2s4QUpHMDRh?= =?utf-8?B?TTZCMktNUDZ3RTBBSnJER0lJSXNtQUtxeUJnQlZzM2FoZHA1d1FpT3U4Mzk4?= =?utf-8?B?bW1lTjU5TUMwY2QwM0RWdGllUDRNY1djMXg0L3RiR20yREVUeHE0ZE10eEl5?= =?utf-8?B?NVU0TkpXV0lYSzFIaHUwQmxkS2Jqc08yaURqaDVLbmk0UmlRdEZ0RlFFckd4?= =?utf-8?B?b0E1TEVNTFVnTGU1R3ZiR3hjUUYrZjlJVGljWVZhMUFFVU90ZEpoOWE5RnFZ?= =?utf-8?B?QU0rZCsvQWRaK3c1cTNRNXphZmg2eFZ1aVZyWTQyalpmd0xIOGZ5QXFSS3RL?= =?utf-8?B?cFpVMGxyYjFWd1Y4R0lvYWhHWnBuZVdZaEJYN0Y2ZnpRZzNrMC9ZSWhIWmp3?= =?utf-8?B?ZElidTRQTVN3dWZjYXovc3ZZOHVVNWFaZWFMWVgvRTNZZ0hjakNKVzNkUGRR?= =?utf-8?B?dlF5dSswVHhLdW1NU3hpcXdhNGlqSzdqZGZKdlVsVkFLZ1JmUXdtWWZEUEpY?= =?utf-8?B?RWd6UkxZWHdRcUtCRm1zaFBFSGJTZFppUmVueERiRW5QNkhnYlpVR2ZRNlNn?= =?utf-8?B?U1JaMVg3WU93UkJTT1JTbndmRlM5TkRoSGk0Y3g3REI0WDBGYWJYd3R4ZTJL?= =?utf-8?B?Z0Z1dmIxWlBYcFJ1S3RBRGwzUkdRYUtaMER6bnhtb3NMTThZQSt6NWYyTHF4?= =?utf-8?B?RUx2WXZxdDFNV3BSdHdYcjYvakYwTktpRWlPK3BXUGFOTG45QWE5ZkFURlNi?= =?utf-8?B?RE9TWnZqOHdnY0g4eFlIcDY4TDBnVVUvcjdVQnE2c2xSdTlocTBPWnVYeGNv?= =?utf-8?B?LzdGK2ZwQXZoYkttVkhEa0tWcVJWYzRyclRSaDFGY054d3VPcUZrNjVneUpH?= =?utf-8?B?Uk9NaHpZclBhM2FKNmdXS2NuUG0vUEc5SllGVCtXaHZqVWpodlNHUVp3TmF2?= =?utf-8?B?cFhCdTJmSkN2ckZTdldIK3duTUtjWjdCRnI0eVplbGhqMmx0Z0RlYld5S2Iw?= =?utf-8?B?cmp6WkJBaGVySnoxaVNVdHdxYVBielNCTUgwWFhCQk0xQzltR2pjVEQvWmVD?= =?utf-8?B?RnR4cHI2eWQyczJGMWxDcEpnSEkxQlZtYTB3dmdZN3JHV1lZVFpBNktvTm8r?= =?utf-8?B?MTdKc2VxVithVlQvaXBJOURvM3FyVUxTbE8wN2w5eHFSWTJTRzRWNHhEK0tE?= =?utf-8?B?RHpQbnQ2RVd3YkpEMURsOWZmcG5UME0rU2xDbHFCK3l2Mmx4aEtOY1pRY01D?= =?utf-8?B?czU2VVl1djNORDE5Nk9hd3NWNWFZcXFIYVM0dnhXSmQrQks4QUpGTkphT2Qw?= =?utf-8?B?VjRKUHZHZFd2L3pYSHRvejZLTENzM1N0dDUvbGk5ZE0veEltZVRsK2ZTWTA3?= =?utf-8?B?M0pITW01ZmhKbjRvUmdLT1FYME55WHdzZjNvSVVtZkpsMFlxcEVDUVN0VERK?= =?utf-8?B?L2EzdVRtZnY4bzBEY0hHQVFKZS9CWHFzQldta0xydlg4dlBQSThyMlhyaFZV?= =?utf-8?B?THJYWnM4bGE3TUdoalZ0aktTelFOVnZHT25ES25SbnVDSUdDaUZNMWtOSGJV?= =?utf-8?B?YnhzR211UXpxdUxvQWNCTU1zeXZGY0FtSEYwdklHbDAyamFjMjhZQmRBZFJF?= =?utf-8?B?K3VESUdXcm1EUHNNRCtmYk9WOU9kekQvNmdHbFA3ekQxbFFDYzYyNDg2dGlT?= =?utf-8?B?UFM3M0xpelFmZnNuR1MrOEVYYUJTT1NDZTZRK1NQcEFZZTMrQzg2dlA2a3NK?= =?utf-8?B?RWpmUG1PRHFaWjEvRjQ5dExWcWtjb2o0OVMvWkxtY2JlRGpJL2NBUU5XS2Ux?= =?utf-8?Q?OdnA=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f817a8-b3f0-4a84-fbdd-08dc04696122 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2023 10:16:22.7418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3NckndjUVtSaEfb3AKiXCegmRRXMcRDxiyfkIdR+0dbMeHsEHLwfKoVd7zyEEPqD5uHgCfdcKNSJjijaAijwWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6811 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231224_021632_401796_7AF0C06D X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 24.12.23 um 10:10 schrieb Krzysztof Kozlowski: > On 23/12/2023 22:29, Josua Mayer wrote: >> Most arm board have a board-specific compatible string that allows e.g. >> userspace to match specific firmware variants or apply specific >> policies. >> >> Add board-specific properties to both variants of the Clearfog GTR: >> - solidrun,clearfog-gtr-l8 >> - solidrun,clearfog-gtr-s4 >> >> Introduction of a common parent (e.g. "solidrun,clearfog-gtr") is >> omitted for brevity. >> Since announcement of the two products no additional variants were added >> it is assumed that there will always be just two. >> >> Signed-off-by: Josua Mayer >> --- >> arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts | 1 + >> arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-s4.dts | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts >> index 1990f7d0cc79..ae921a674c93 100644 >> --- a/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts >> +++ b/arch/arm/boot/dts/marvell/armada-385-clearfog-gtr-l8.dts >> @@ -4,6 +4,7 @@ >> >> / { >> model = "SolidRun Clearfog GTR L8"; >> + compatible = "solidrun,clearfog-gtr-l8", "marvell,armada385", "marvell,armada380"; > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. > > I don't see them being documented. Yes, checkpatch warned about that specifially, but I am not sure how to proceed. The armada-38x dt bindings documentation is stil in text format, and doesn't document any board: Documentation/devicetree/bindings/arm/marvell/armada-38x.txt > > Also, wrap at 80, as Linux coding style asks. Will do. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel