Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/12/2025 16:05, Lukas Timmermann wrote:
> +
> +&pinctrl_1 {
> +	bh1721fvc_reset: bh1721fvc-reset-pins {
> +		samsung,pins = "gph1-2";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +	msense_rst: msense-rst-pins {
> +		samsung,pins = "gpg2-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +	};
> +	onewire_sleep: onewire-sleep-pins {
> +		samsung,pins = "gpg0-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
> +		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
> +	};


I really wonder what did you take as reference/starting point. None of
new files follow such syntax without blank lines. Neither do Google
devices for Exynos5250.

Please rewrite the DTS to match the latest used style from arm64. This
also includes sorting pin nodes - if there are not grouped, then by pin
name.

You also got some other comments. In general, if you took recent file as
the starting point then most of the nits would be gone.

Best regards,
Krzysztof