[PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus 10)

[PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Lukas Timmermann]

This patch series adds initial support for the google-manta board, known
as Google Nexus 10 to users. The device is powered by
the Exynos 5250 SoC. The bindings for the notification led are already 
in the kernel mailing list, got recently applied and can be found here:
https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/

The first two patches add the necessary device tree files and
bindings, while the last patch makes a small modification to
allow CPU1 to boot, as it requires a call to it's underlying firmware.

This first iteration only provides basic support to get the board
up and running and usable via UART and with WiFi support. We will upstream additional 
features in future patches. All patches have been tested on real hardware.

Changes in v3:
 - Added a better patch description for firmware patch. (@krzk)
 - Reorganized nodes in DT. (@krzk)
 - Fixed memory node to use separate entries. (@krzk)
 - Renamed pwrseq node. (@krzk)
 - Fixed firmware checking for old dt compatible string. (@pavel)
 - Link to v2: https://lore.kernel.org/all/20251125-google-manta-v2-0-0f097cfff39c@timmermann.space/
Changes in v2:
 - Renamed to google-manta (@krzk)
 - Link to v1: https://lore.kernel.org/all/20251120144018.961604-2-linux@timmermann.space/

Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
Alexandre Marquet (3):
      dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
      ARM: dts: exynos: Add Google Manta (Nexus 10)
      ARM: samsung: exynos5250: Allow CPU1 to boot

 .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
 arch/arm/boot/dts/samsung/Makefile                 |   1 +
 arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 511 +++++++++++++++++++++
 arch/arm/mach-exynos/firmware.c                    |   4 +-
 4 files changed, 515 insertions(+), 2 deletions(-)
---
base-commit: d5f0e9098499869354aacb5b080f602f0399d396
change-id: 20251215-lat3st-staging-d9c926d8a75f

Best regards,
-- 
Lukas Timmermann <linux@timmermann.space>

[PATCH v3 1/3] dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

Add the Google Nexus 10 board to documentation.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
index f8e20e602c20..13d97257f070 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
@@ -117,6 +117,7 @@ properties:
       - description: Exynos5250 based boards
         items:
           - enum:
+              - google,manta                    # Google Manta (Nexus 10)
               - google,snow-rev5                # Google Snow Rev 5+
               - google,spring                   # Google Spring
               - insignal,arndale                # Insignal Arndale

-- 
2.52.0

[PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

Manta is the code name for Google Nexus 10, and was manufactured by
Samsung with their Exynos5250 SoC.
This patch adds initial device-tree file for this board.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Co-developed-by: Lukas Timmermann <linux@timmermann.space>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 arch/arm/boot/dts/samsung/Makefile             |   1 +
 arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511 +++++++++++++++++++++++++
 2 files changed, 512 insertions(+)

diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile
index 7becf36656b1..e0143ee8c82d 100644
--- a/arch/arm/boot/dts/samsung/Makefile
+++ b/arch/arm/boot/dts/samsung/Makefile
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
 	exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
 	exynos5250-arndale.dtb \
+	exynos5250-manta.dtb \
 	exynos5250-smdk5250.dtb \
 	exynos5250-snow.dtb \
 	exynos5250-snow-rev5.dtb \
diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
new file mode 100644
index 000000000000..0f006590576c
--- /dev/null
+++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
@@ -0,0 +1,511 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Google Manta (Nexus 10) board device tree source
+ *
+ * Copyright (c) 2023-2025 Alexandre Marquet
+ * Copyright (c) 2025 Lukas Timmermann
+ */
+
+/dts-v1/;
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/maxim,max77686.h>
+#include <dt-bindings/input/linux-event-codes.h>
+#include "exynos-pinctrl.h"
+#include "exynos5250.dtsi"
+#include "exynos-mfc-reserved-memory.dtsi"
+
+/ {
+	model = "Google Nexus 10";
+	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
+
+	aliases {
+		mmc0 = &mmc_0; /* eMMC */
+		mmc1 = &mmc_1; /* WiFi */
+	};
+
+	bmp180_vdda_reg: regulator-bmp180-vdda {
+		compatible = "regulator-fixed";
+		regulator-name = "BMP180_VDDA";
+	};
+
+	bmp180_vddd_reg: regulator-bmp180-vddd {
+		compatible = "regulator-fixed";
+		regulator-name = "BMP180_VDDD";
+	};
+
+	chosen {
+		stdout-path = &serial_2;
+	};
+
+	fixed-rate-clocks {
+		xxti {
+			compatible = "samsung,clock-xxti";
+			clock-frequency = <24000000>;
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&gpio_keys>;
+
+		key-down {
+			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEDOWN>;
+			label = "volume down";
+			debounce-interval = <5>;
+		};
+
+		key-up {
+			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			label = "volume up";
+			debounce-interval = <5>;
+		};
+
+		key-power {
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_POWER>;
+			label = "power";
+			debounce-interval = <5>;
+			wakeup-source;
+		};
+
+		lid-switch {
+			label = "Lid";
+			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
+			linux,input-type = <5>; /* EV_SW */
+			linux,code = <0>; /* SW_LID */
+			debounce-interval = <10>;
+			wakeup-source;
+		};
+	};
+
+	multi-led {
+		compatible = "leds-group-multicolor";
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
+	};
+
+	pwrseq: mmc1-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>;
+		pinctrl-0 = <&wlan_pmena>;
+		pinctrl-names = "default";
+		clocks = <&max77686 MAX77686_CLK_PMIC>;
+		clock-names = "ext_clock";
+		post-power-on-delay-ms = <300>;
+		power-off-delay-us = <50>;
+	};
+
+	firmware@203f000 {
+		compatible = "samsung,secure-firmware";
+		reg = <0x0204efff 0x1000>;
+	};
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x20000000>,
+		      <0x60000000 0x20000000>,
+		      <0x80000000 0x20000000>,
+		      <0xa0000000 0x1ff00000>;
+	};
+};
+
+&clock {
+	assigned-clocks = <&clock CLK_FOUT_APLL>;
+	assigned-clock-rates = <1000000000>;
+};
+
+&cpu0 {
+	cpu0-supply = <&buck2_reg>;
+};
+
+&ehci {
+	status = "disabled";
+};
+
+&i2c_0 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-slave-addr = <0x10>;
+};
+
+&i2c_1 {
+	status = "okay";
+
+	pressure@77 {
+		compatible = "bosch,bmp180";
+		reg = <0x77>;
+		vddd-supply = <&bmp180_vddd_reg>;
+		vdda-supply = <&bmp180_vdda_reg>;
+	};
+
+	imu@68 {
+		compatible = "invensense,mpu6050";
+		reg = <0x68>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&acc_int>;
+		interrupt-parent = <&gpx1>;
+		interrupts = <4 IRQ_TYPE_EDGE_RISING>;
+		mount-matrix = "0",  "-1",  "0",
+				"-1",  "0",  "0",
+				"0",  "0", "-1";
+
+		i2c-gate {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			magnetometer@c {
+				compatible = "asahi-kasei,ak8963";
+				reg = <0x0c>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&msense_rst>;
+				mount-matrix = "-1",  "0",  "0",
+						"0",  "1",  "0",
+						"0",  "0", "-1";
+			};
+		};
+	};
+
+	led-controller@42 {
+		compatible = "ams,as3668";
+		reg = <0x42>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status_red: led@0 {
+			reg = <0x0>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		status_green: led@1 {
+			reg = <0x1>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		status_blue: led@2 {
+			reg = <0x2>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+
+		status_white: led@3 {
+			reg = <0x3>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
+&i2c_2 {
+	status = "okay";
+
+	light-sensor@23 {
+		compatible = "rohm,bh1721";
+		reg = <0x23>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&bh1721fvc_reset>;
+		reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>;
+	};
+
+	onewire@18 {
+		compatible = "maxim,ds2484";
+		reg = <0x18>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&onewire_sleep>;
+	};
+};
+
+&i2c_5 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+
+	max77686: pmic@9 {
+		compatible = "maxim,max77686";
+		reg = <0x09>;
+		interrupt-parent = <&gpx0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		#clock-cells = <1>;
+		wakeup-source;
+
+		voltage-regulators {
+			ldo3_reg: LDO3 {
+				regulator-name = "VCC_1.8V_AP";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo8_reg: LDO8 {
+				regulator-name = "VMIPI_1.0V";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo9_reg: LDO9 {
+				regulator-name = "TOUCH_VDD_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo10_reg: LDO10 {
+				regulator-name = "VMIPI_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo12_reg: LDO12 {
+				regulator-name = "VUOTG_3.0V";
+				regulator-min-microvolt = <3000000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo15_reg: LDO15 {
+				regulator-name = "VHSIC_1.0V";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo16_reg: LDO16 {
+				regulator-name = "VHSIC_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo17_reg: LDO17 {
+				regulator-name = "5M_CORE_1.5V";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <1500000>;
+			};
+			ldo18_reg: LDO18 {
+				regulator-name = "CAM_IO_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo19_reg: LDO19 {
+				regulator-name = "VT_CAM_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo20_reg: LDO20 {
+				regulator-name = "TA_CHECK_1.35V";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1350000>;
+			};
+			ldo23_reg: LDO23 {
+				regulator-name = "TSP_AVDD_2.8V";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+			};
+			ldo24_reg: LDO24 {
+				regulator-name = "CAM_AF_2.8V";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+			};
+			ldo25_reg: LDO25 {
+				regulator-name = "VADC_3.3V";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck1_reg: BUCK1 {
+				regulator-name = "vdd_mif";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck2_reg: BUCK2 {
+				regulator-name = "vdd_arm";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck3_reg: BUCK3 {
+				regulator-name = "vdd_int";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck4_reg: BUCK4 {
+				regulator-name = "vdd_g3d";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-boot-on;
+			};
+		};
+	};
+};
+
+&mali {
+	status = "okay";
+	mali-supply = <&buck4_reg>;
+};
+
+&mixer {
+	status = "okay";
+};
+
+/* eMMC */
+&mmc_0 {
+	status = "okay";
+	non-removable;
+	max-frequency = <200000000>;
+	sd-uhs-ddr50;
+	mmc-ddr-1_8v;
+	cap-mmc-hw-reset;
+	mmc-hs200-1_8v;
+	bus-width = <8>;
+	card-detect-delay = <200>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <1 2>;
+	samsung,dw-mshc-ddr-timing = <2 3>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>;
+};
+
+/* WiFi */
+&mmc_1 {
+	status = "okay";
+	non-removable;
+	max-frequency = <100000000>;
+	sd-uhs-sdr50;
+	cap-sd-highspeed;
+	keep-power-in-suspend;
+	bus-width = <4>;
+	card-detect-delay = <0>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <2 4>;
+	samsung,dw-mshc-ddr-timing = <2 3>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
+	mmc-pwrseq = <&pwrseq>;
+
+	wifi@1 {
+		compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
+		reg = <1>;
+		interrupt-parent = <&gpx2>;
+		interrupts = <5 IRQ_TYPE_NONE>;
+		interrupt-names = "host-wake";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wlan_irq>;
+	};
+};
+
+&ohci {
+	status = "disabled";
+};
+
+&pinctrl_0 {
+	acc_int: acc-int-pins {
+		samsung,pins = "gpx1-4";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+	};
+
+	max77686_irq: max77686-irq-pins {
+		samsung,pins = "gpx0-2";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+	};
+	gpio_keys: gpio-keys-pins-pins {
+		samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
+	wlan_irq: wlan-irq-pins {
+		samsung,pins = "gpx2-5";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
+	};
+};
+
+&pinctrl_1 {
+	bh1721fvc_reset: bh1721fvc-reset-pins {
+		samsung,pins = "gph1-2";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
+	msense_rst: msense-rst-pins {
+		samsung,pins = "gpg2-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+	};
+	onewire_sleep: onewire-sleep-pins {
+		samsung,pins = "gpg0-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+	};
+};
+
+&pinctrl_2 {
+	wlan_pmena: wlan-pmena-pins {
+		samsung,pins = "gpv1-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
+		samsung,pin-val = <0>;
+	};
+};
+
+&pmu_system_controller {
+	assigned-clocks = <&pmu_system_controller 0>;
+	assigned-clock-parents = <&clock CLK_FIN_PLL>;
+};
+
+&sd1_bus4 {
+	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+};
+
+&sd1_cmd {
+	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+};
+
+/* Bluetooth */
+&serial_0 {
+	status = "disabled";
+};
+
+&serial_1 {
+	pinctrl-names = "default", "flow-control";
+	pinctrl-0 = <&uart1_data>;
+	pinctrl-1 = <&uart1_data>, <&uart1_fctl>;
+};
+
+&serial_2 {
+	pinctrl-names = "default", "flow-control";
+	pinctrl-0 = <&uart2_data>;
+	pinctrl-1 = <&uart2_data>, <&uart2_fctl>;
+};
+
+&usbdrd {
+	status = "disabled";
+};
+
+&usbdrd_dwc3 {
+	status = "disabled";
+};
+
+&usbdrd_phy {
+	status = "disabled";
+};

-- 
2.52.0

[PATCH v3 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

The firmware trustzone needs a special call to bring up the secondary
cpu core on the Manta board. This seems to be not needed on other
exynos5 boards and comes down to the available firmware on
a particular board.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 arch/arm/mach-exynos/firmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index a5e22678e27b..e9b0ed07bb90 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
 	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
 	 * because Exynos3250 removes WFE in secure mode.
 	 *
-	 * On Exynos5 devices the call is ignored by trustzone firmware.
+	 * On most Exynos5 devices the call is ignored by trustzone firmware.
 	 */
 	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
-	    !soc_is_exynos4412())
+	    !soc_is_exynos4412() && !of_machine_is_compatible("google,manta"))
 		return 0;
 
 	/*

-- 
2.52.0

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[David Heidelberg]

Hello Lucas,

thanks for the sending Nexus 10 upstream, see few nitpicks below:

On 15/12/2025 16:05, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> Manta is the code name for Google Nexus 10, and was manufactured by
> Samsung with their Exynos5250 SoC.
> This patch adds initial device-tree file for this board.
> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Co-developed-by: Lukas Timmermann <linux@timmermann.space>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
>   arch/arm/boot/dts/samsung/Makefile             |   1 +
>   arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511 +++++++++++++++++++++++++
>   2 files changed, 512 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile
> index 7becf36656b1..e0143ee8c82d 100644
> --- a/arch/arm/boot/dts/samsung/Makefile
> +++ b/arch/arm/boot/dts/samsung/Makefile
> @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>   	exynos4412-trats2.dtb
>   dtb-$(CONFIG_ARCH_EXYNOS5) += \
>   	exynos5250-arndale.dtb \
> +	exynos5250-manta.dtb \
>   	exynos5250-smdk5250.dtb \
>   	exynos5250-snow.dtb \
>   	exynos5250-snow-rev5.dtb \
> diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
> new file mode 100644
> index 000000000000..0f006590576c
> --- /dev/null
> +++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
> @@ -0,0 +1,511 @@
> +// SPDX-License-Identifier: GPL-2.0

you could use here modern SPDX I guess (GPL-2.0-only)

> +/*
> + * Google Manta (Nexus 10) board device tree source
> + *
> + * Copyright (c) 2023-2025 Alexandre Marquet
> + * Copyright (c) 2025 Lukas Timmermann
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/maxim,max77686.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include "exynos-pinctrl.h"
> +#include "exynos5250.dtsi"
> +#include "exynos-mfc-reserved-memory.dtsi"
> +
> +/ {
> +	model = "Google Nexus 10";
> +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
> +
> +	aliases {
> +		mmc0 = &mmc_0; /* eMMC */
> +		mmc1 = &mmc_1; /* WiFi */
> +	};
> +
> +	bmp180_vdda_reg: regulator-bmp180-vdda {
> +		compatible = "regulator-fixed";
> +		regulator-name = "BMP180_VDDA";
> +	};
something-something-regulator (all occurences within the DTS)

> +
> +	bmp180_vddd_reg: regulator-bmp180-vddd {
> +		compatible = "regulator-fixed";
> +		regulator-name = "BMP180_VDDD";
> +	};
> +
> +	chosen {
> +		stdout-path = &serial_2;
> +	};
> +
> +	fixed-rate-clocks {
> +		xxti {
> +			compatible = "samsung,clock-xxti";
> +			clock-frequency = <24000000>;
> +		};
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio_keys>;
> +
> +		key-down {
> +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			label = "volume down";
> +			debounce-interval = <5>;
> +		};
> +
> +		key-up {
> +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			label = "volume up";
> +			debounce-interval = <5>;
> +		};
> +
> +		key-power {
> +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_POWER>;
> +			label = "power";
> +			debounce-interval = <5>;
> +			wakeup-source;
> +		};
> +
> +		lid-switch {
> +			label = "Lid";
> +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
> +			linux,input-type = <5>; /* EV_SW */
> +			linux,code = <0>; /* SW_LID */
> +			debounce-interval = <10>;
> +			wakeup-source;
> +		};
> +	};
> +
> +	multi-led {
> +		compatible = "leds-group-multicolor";
> +		color = <LED_COLOR_ID_RGB>;
> +		function = LED_FUNCTION_STATUS;
> +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
> +	};
> +
> +	pwrseq: mmc1-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>;
> +		pinctrl-0 = <&wlan_pmena>;
> +		pinctrl-names = "default";
> +		clocks = <&max77686 MAX77686_CLK_PMIC>;
> +		clock-names = "ext_clock";
> +		post-power-on-delay-ms = <300>;
> +		power-off-delay-us = <50>;
> +	};
> +
> +	firmware@203f000 {
> +		compatible = "samsung,secure-firmware";
> +		reg = <0x0204efff 0x1000>;
> +	};
> +
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0x40000000 0x20000000>,
> +		      <0x60000000 0x20000000>,
> +		      <0x80000000 0x20000000>,
> +		      <0xa0000000 0x1ff00000>;
> +	};
> +};
> +
> +&clock {
> +	assigned-clocks = <&clock CLK_FOUT_APLL>;
> +	assigned-clock-rates = <1000000000>;
> +};
> +
> +&cpu0 {
> +	cpu0-supply = <&buck2_reg>;
> +};
> +
> +&ehci {
> +	status = "disabled";
> +};
> +
> +&i2c_0 {
> +	status = "okay";

status should be before first sub-node (none in this case), with 
preceding newline, please change all occurences


> +	samsung,i2c-sda-delay = <100>;
> +	samsung,i2c-slave-addr = <0x10>;
> +};
> +
> +&i2c_1 {
> +	status = "okay";
> +
> +	pressure@77 {
> +		compatible = "bosch,bmp180";
> +		reg = <0x77>;
> +		vddd-supply = <&bmp180_vddd_reg>;
> +		vdda-supply = <&bmp180_vdda_reg>;
> +	};
> +
> +	imu@68 {
> +		compatible = "invensense,mpu6050";
> +		reg = <0x68>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&acc_int>;
> +		interrupt-parent = <&gpx1>;
> +		interrupts = <4 IRQ_TYPE_EDGE_RISING>;
> +		mount-matrix = "0",  "-1",  "0",
> +				"-1",  "0",  "0",
> +				"0",  "0", "-1";
> +
> +		i2c-gate {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			magnetometer@c {
> +				compatible = "asahi-kasei,ak8963";
> +				reg = <0x0c>;
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&msense_rst>;
> +				mount-matrix = "-1",  "0",  "0",
> +						"0",  "1",  "0",
> +						"0",  "0", "-1";
> +			};
> +		};
> +	};
> +
> +	led-controller@42 {
> +		compatible = "ams,as3668";
> +		reg = <0x42>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		status_red: led@0 {
> +			reg = <0x0>;
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_RED>;
> +		};
> +
> +		status_green: led@1 {
> +			reg = <0x1>;
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		status_blue: led@2 {
> +			reg = <0x2>;
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_BLUE>;
> +		};
> +
> +		status_white: led@3 {
> +			reg = <0x3>;
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_WHITE>;
> +		};
> +	};
> +};
> +
> +&i2c_2 {
> +	status = "okay";
> +
> +	light-sensor@23 {
> +		compatible = "rohm,bh1721";
> +		reg = <0x23>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bh1721fvc_reset>;
> +		reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>;
> +	};
> +
> +	onewire@18 {
> +		compatible = "maxim,ds2484";
> +		reg = <0x18>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&onewire_sleep>;
> +	};
> +};
> +
> +&i2c_5 {
> +	status = "okay";
> +	samsung,i2c-sda-delay = <100>;
> +
> +	max77686: pmic@9 {
> +		compatible = "maxim,max77686";
> +		reg = <0x09>;
> +		interrupt-parent = <&gpx0>;
> +		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&max77686_irq>;
> +		#clock-cells = <1>;
> +		wakeup-source;
> +
> +		voltage-regulators {
> +			ldo3_reg: LDO3 {
> +				regulator-name = "VCC_1.8V_AP";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo8_reg: LDO8 {
> +				regulator-name = "VMIPI_1.0V";
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <1000000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo9_reg: LDO9 {
> +				regulator-name = "TOUCH_VDD_1.8V";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +			ldo10_reg: LDO10 {
> +				regulator-name = "VMIPI_1.8V";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo12_reg: LDO12 {
> +				regulator-name = "VUOTG_3.0V";
> +				regulator-min-microvolt = <3000000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo15_reg: LDO15 {
> +				regulator-name = "VHSIC_1.0V";
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <1000000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo16_reg: LDO16 {
> +				regulator-name = "VHSIC_1.8V";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			ldo17_reg: LDO17 {
> +				regulator-name = "5M_CORE_1.5V";
> +				regulator-min-microvolt = <1500000>;
> +				regulator-max-microvolt = <1500000>;
> +			};
> +			ldo18_reg: LDO18 {
> +				regulator-name = "CAM_IO_1.8V";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +			ldo19_reg: LDO19 {
> +				regulator-name = "VT_CAM_1.8V";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +			ldo20_reg: LDO20 {
> +				regulator-name = "TA_CHECK_1.35V";
> +				regulator-min-microvolt = <1350000>;
> +				regulator-max-microvolt = <1350000>;
> +			};
> +			ldo23_reg: LDO23 {
> +				regulator-name = "TSP_AVDD_2.8V";
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
> +			};
> +			ldo24_reg: LDO24 {
> +				regulator-name = "CAM_AF_2.8V";
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
> +			};
> +			ldo25_reg: LDO25 {
> +				regulator-name = "VADC_3.3V";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			buck1_reg: BUCK1 {
> +				regulator-name = "vdd_mif";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <1200000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			buck2_reg: BUCK2 {
> +				regulator-name = "vdd_arm";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <1200000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			buck3_reg: BUCK3 {
> +				regulator-name = "vdd_int";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <1200000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +			buck4_reg: BUCK4 {
> +				regulator-name = "vdd_g3d";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <1200000>;
> +				regulator-boot-on;
> +			};
> +		};
> +	};
> +};
> +
> +&mali {
> +	status = "okay";
> +	mali-supply = <&buck4_reg>;
> +};
> +
> +&mixer {
> +	status = "okay";
> +};
> +
> +/* eMMC */
> +&mmc_0 {
> +	status = "okay";
> +	non-removable;
> +	max-frequency = <200000000>;
> +	sd-uhs-ddr50;
> +	mmc-ddr-1_8v;
> +	cap-mmc-hw-reset;
> +	mmc-hs200-1_8v;
> +	bus-width = <8>;
> +	card-detect-delay = <200>;
> +	samsung,dw-mshc-ciu-div = <3>;
> +	samsung,dw-mshc-sdr-timing = <1 2>;
> +	samsung,dw-mshc-ddr-timing = <2 3>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>;
> +};
> +
> +/* WiFi */
> +&mmc_1 {
> +	status = "okay";
> +	non-removable;
> +	max-frequency = <100000000>;
> +	sd-uhs-sdr50;
> +	cap-sd-highspeed;
> +	keep-power-in-suspend;
> +	bus-width = <4>;
> +	card-detect-delay = <0>;
> +	samsung,dw-mshc-ciu-div = <3>;
> +	samsung,dw-mshc-sdr-timing = <2 4>;
> +	samsung,dw-mshc-ddr-timing = <2 3>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
> +	mmc-pwrseq = <&pwrseq>;
> +
> +	wifi@1 {
> +		compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
> +		reg = <1>;
> +		interrupt-parent = <&gpx2>;
> +		interrupts = <5 IRQ_TYPE_NONE>;
> +		interrupt-names = "host-wake";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wlan_irq>;
> +	};
> +};
> +
> +&ohci {
> +	status = "disabled";
> +};
> +
> +&pinctrl_0 {
> +	acc_int: acc-int-pins {
> +		samsung,pins = "gpx1-4";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +	};
> +
> +	max77686_irq: max77686-irq-pins {
> +		samsung,pins = "gpx0-2";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> +	};

missing newlines (everywhere below)

> +	gpio_keys: gpio-keys-pins-pins {
> +		samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3";
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +	wlan_irq: wlan-irq-pins {
> +		samsung,pins = "gpx2-5";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
> +	};
> +};
> +
> +&pinctrl_1 {
> +	bh1721fvc_reset: bh1721fvc-reset-pins {
> +		samsung,pins = "gph1-2";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +	msense_rst: msense-rst-pins {
> +		samsung,pins = "gpg2-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +	};
> +	onewire_sleep: onewire-sleep-pins {
> +		samsung,pins = "gpg0-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
> +		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +};
> +
> +&pinctrl_2 {
> +	wlan_pmena: wlan-pmena-pins {
> +		samsung,pins = "gpv1-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
> +		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
> +		samsung,pin-val = <0>;
> +	};
> +};
> +
> +&pmu_system_controller {
> +	assigned-clocks = <&pmu_system_controller 0>;
> +	assigned-clock-parents = <&clock CLK_FIN_PLL>;
> +};
> +
> +&sd1_bus4 {
> +	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
> +	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
> +};
> +
> +&sd1_cmd {
> +	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
> +	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
> +};
> +
> +/* Bluetooth */
> +&serial_0 {
> +	status = "disabled";
> +};
> +
> +&serial_1 {
> +	pinctrl-names = "default", "flow-control";
> +	pinctrl-0 = <&uart1_data>;
> +	pinctrl-1 = <&uart1_data>, <&uart1_fctl>;

pinctrl-name follow after last pinctrl- entry.

> +};
> +
> +&serial_2 {
> +	pinctrl-names = "default", "flow-control";
> +	pinctrl-0 = <&uart2_data>;
> +	pinctrl-1 = <&uart2_data>, <&uart2_fctl>;

same

> +};
> +
> +&usbdrd {
> +	status = "disabled";
> +};
> +
> +&usbdrd_dwc3 {
> +	status = "disabled";
> +};
> +
> +&usbdrd_phy {
> +	status = "disabled";
> +};
> 

-- 
David Heidelberg

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 15/12/2025 19:53, David Heidelberg wrote:
> Hello Lucas,
> 
> thanks for the sending Nexus 10 upstream, see few nitpicks below:
> 
> On 15/12/2025 16:05, Lukas Timmermann wrote:
>> From: Alexandre Marquet <tb@a-marquet.fr>
>>
>> Manta is the code name for Google Nexus 10, and was manufactured by
>> Samsung with their Exynos5250 SoC.
>> This patch adds initial device-tree file for this board.
>>
>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
>> Co-developed-by: Lukas Timmermann <linux@timmermann.space>
>> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
>> ---
>>   arch/arm/boot/dts/samsung/Makefile             |   1 +
>>   arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511 +++++++++++++++++++++++++
>>   2 files changed, 512 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile
>> index 7becf36656b1..e0143ee8c82d 100644
>> --- a/arch/arm/boot/dts/samsung/Makefile
>> +++ b/arch/arm/boot/dts/samsung/Makefile
>> @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>>   	exynos4412-trats2.dtb
>>   dtb-$(CONFIG_ARCH_EXYNOS5) += \
>>   	exynos5250-arndale.dtb \
>> +	exynos5250-manta.dtb \
>>   	exynos5250-smdk5250.dtb \
>>   	exynos5250-snow.dtb \
>>   	exynos5250-snow-rev5.dtb \
>> diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
>> new file mode 100644
>> index 000000000000..0f006590576c
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
>> @@ -0,0 +1,511 @@
>> +// SPDX-License-Identifier: GPL-2.0
> 
> you could use here modern SPDX I guess (GPL-2.0-only)
> 
>> +/*
>> + * Google Manta (Nexus 10) board device tree source
>> + *
>> + * Copyright (c) 2023-2025 Alexandre Marquet
>> + * Copyright (c) 2025 Lukas Timmermann
>> + */
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/clock/maxim,max77686.h>
>> +#include <dt-bindings/input/linux-event-codes.h>
>> +#include "exynos-pinctrl.h"
>> +#include "exynos5250.dtsi"
>> +#include "exynos-mfc-reserved-memory.dtsi"
>> +
>> +/ {
>> +	model = "Google Nexus 10";
>> +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
>> +
>> +	aliases {
>> +		mmc0 = &mmc_0; /* eMMC */
>> +		mmc1 = &mmc_1; /* WiFi */
>> +	};
>> +
>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "BMP180_VDDA";
>> +	};
> something-something-regulator (all occurences within the DTS)
> 

I don't understand this suggestion.

>> +
>> +	bmp180_vddd_reg: regulator-bmp180-vddd {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "BMP180_VDDD";
>> +	};



>> +};
>> +
>> +&clock {
>> +	assigned-clocks = <&clock CLK_FOUT_APLL>;
>> +	assigned-clock-rates = <1000000000>;
>> +};
>> +
>> +&cpu0 {
>> +	cpu0-supply = <&buck2_reg>;
>> +};
>> +
>> +&ehci {
>> +	status = "disabled";
>> +};
>> +
>> +&i2c_0 {
>> +	status = "okay";
> 
> status should be before first sub-node (none in this case), with 
> preceding newline, please change all occurences
> 

Well yeah, but do you have actually any comment pointing real issues?


Best regards,
Krzysztof

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[David Heidelberg]

On 15/12/2025 20:33, Krzysztof Kozlowski wrote:
> On 15/12/2025 19:53, David Heidelberg wrote:
>> Hello Lucas,
>>
>> thanks for the sending Nexus 10 upstream, see few nitpicks below:
>>
>> On 15/12/2025 16:05, Lukas Timmermann wrote:
>>> From: Alexandre Marquet <tb@a-marquet.fr>
>>>
>>> Manta is the code name for Google Nexus 10, and was manufactured by
>>> Samsung with their Exynos5250 SoC.
>>> This patch adds initial device-tree file for this board.
>>>
>>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
>>> Co-developed-by: Lukas Timmermann <linux@timmermann.space>
>>> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
>>> ---
>>>    arch/arm/boot/dts/samsung/Makefile             |   1 +
>>>    arch/arm/boot/dts/samsung/exynos5250-manta.dts | 511 +++++++++++++++++++++++++
>>>    2 files changed, 512 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile
>>> index 7becf36656b1..e0143ee8c82d 100644
>>> --- a/arch/arm/boot/dts/samsung/Makefile
>>> +++ b/arch/arm/boot/dts/samsung/Makefile
>>> @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>>>    	exynos4412-trats2.dtb
>>>    dtb-$(CONFIG_ARCH_EXYNOS5) += \
>>>    	exynos5250-arndale.dtb \
>>> +	exynos5250-manta.dtb \
>>>    	exynos5250-smdk5250.dtb \
>>>    	exynos5250-snow.dtb \
>>>    	exynos5250-snow-rev5.dtb \
>>> diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
>>> new file mode 100644
>>> index 000000000000..0f006590576c
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
>>> @@ -0,0 +1,511 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>
>> you could use here modern SPDX I guess (GPL-2.0-only)
>>
>>> +/*
>>> + * Google Manta (Nexus 10) board device tree source
>>> + *
>>> + * Copyright (c) 2023-2025 Alexandre Marquet
>>> + * Copyright (c) 2025 Lukas Timmermann
>>> + */
>>> +
>>> +/dts-v1/;
>>> +#include <dt-bindings/leds/common.h>
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/clock/maxim,max77686.h>
>>> +#include <dt-bindings/input/linux-event-codes.h>
>>> +#include "exynos-pinctrl.h"
>>> +#include "exynos5250.dtsi"
>>> +#include "exynos-mfc-reserved-memory.dtsi"
>>> +
>>> +/ {
>>> +	model = "Google Nexus 10";
>>> +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
>>> +
>>> +	aliases {
>>> +		mmc0 = &mmc_0; /* eMMC */
>>> +		mmc1 = &mmc_1; /* WiFi */
>>> +	};
>>> +
>>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>>> +		compatible = "regulator-fixed";
>>> +		regulator-name = "BMP180_VDDA";
>>> +	};
>> something-something-regulator (all occurences within the DTS)
>>
> 
> I don't understand this suggestion.

oh right, let me clarify,

the regulator name should end with -regulator postfix.

> 
>>> +
>>> +	bmp180_vddd_reg: regulator-bmp180-vddd {
>>> +		compatible = "regulator-fixed";
>>> +		regulator-name = "BMP180_VDDD";
>>> +	};
> 
> 
> 
>>> +};
>>> +
>>> +&clock {
>>> +	assigned-clocks = <&clock CLK_FOUT_APLL>;
>>> +	assigned-clock-rates = <1000000000>;
>>> +};
>>> +
>>> +&cpu0 {
>>> +	cpu0-supply = <&buck2_reg>;
>>> +};
>>> +
>>> +&ehci {
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&i2c_0 {
>>> +	status = "okay";
>>
>> status should be before first sub-node (none in this case), with
>> preceding newline, please change all occurences
>>
> 
> Well yeah, but do you have actually any comment pointing real issues?

No I don't, just generic device-tree nitpicks.

David

> 
> 
> Best regards,
> Krzysztof

-- 
David Heidelberg

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 15/12/2025 21:06, David Heidelberg wrote:
>>>> +	aliases {
>>>> +		mmc0 = &mmc_0; /* eMMC */
>>>> +		mmc1 = &mmc_1; /* WiFi */
>>>> +	};
>>>> +
>>>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "BMP180_VDDA";
>>>> +	};
>>> something-something-regulator (all occurences within the DTS)
>>>
>>
>> I don't understand this suggestion.
> 
> oh right, let me clarify,
> 
> the regulator name should end with -regulator postfix.

That is not a correct suggestion for none of the SoC trees. If you
wanted to be consistent with old Exynos, then look at the sources - this
is voltage-regulator. But if we are nitpicking on that, this should be
either matching new code (regulator) or even the new style from DT bindings.

You have never reviewed anything on samsung-soc, so I wonder if this is
result of cc-ing this phone-devel. If that's the case, that list should
be just ignored.

Please do not nitpick on such stuff, especially on things not being
correct in terms of recommended style or bindings.


Best regards,
Krzysztof

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[David Heidelberg]

On 15/12/2025 21:33, Krzysztof Kozlowski wrote:
> On 15/12/2025 21:06, David Heidelberg wrote:
>>>>> +	aliases {
>>>>> +		mmc0 = &mmc_0; /* eMMC */
>>>>> +		mmc1 = &mmc_1; /* WiFi */
>>>>> +	};
>>>>> +
>>>>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>>>>> +		compatible = "regulator-fixed";
>>>>> +		regulator-name = "BMP180_VDDA";
>>>>> +	};
>>>> something-something-regulator (all occurences within the DTS)
>>>>
>>>
>>> I don't understand this suggestion.
>>
>> oh right, let me clarify,
>>
>> the regulator name should end with -regulator postfix.
> 
> That is not a correct suggestion for none of the SoC trees. If you
> wanted to be consistent with old Exynos, then look at the sources - this
> is voltage-regulator. But if we are nitpicking on that, this should be
> either matching new code (regulator) or even the new style from DT bindings.

Oh, sorry, my bad.

> 
> You have never reviewed anything on samsung-soc, so I wonder if this is
> result of cc-ing this phone-devel. If that's the case, that list should
> be just ignored.
> 
> Please do not nitpick on such stuff, especially on things not being
> correct in terms of recommended style or bindings.

Ok, sure.

Please ignore my review.

David

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Rob Herring]

On Mon, 15 Dec 2025 16:05:21 +0100, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The bindings for the notification led are already
> in the kernel mailing list, got recently applied and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 
> The first two patches add the necessary device tree files and
> bindings, while the last patch makes a small modification to
> allow CPU1 to boot, as it requires a call to it's underlying firmware.
> 
> This first iteration only provides basic support to get the board
> up and running and usable via UART and with WiFi support. We will upstream additional
> features in future patches. All patches have been tested on real hardware.
> 
> Changes in v3:
>  - Added a better patch description for firmware patch. (@krzk)
>  - Reorganized nodes in DT. (@krzk)
>  - Fixed memory node to use separate entries. (@krzk)
>  - Renamed pwrseq node. (@krzk)
>  - Fixed firmware checking for old dt compatible string. (@pavel)
>  - Link to v2: https://lore.kernel.org/all/20251125-google-manta-v2-0-0f097cfff39c@timmermann.space/
> Changes in v2:
>  - Renamed to google-manta (@krzk)
>  - Link to v1: https://lore.kernel.org/all/20251120144018.961604-2-linux@timmermann.space/
> 
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
> Alexandre Marquet (3):
>       dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
>       ARM: dts: exynos: Add Google Manta (Nexus 10)
>       ARM: samsung: exynos5250: Allow CPU1 to boot
> 
>  .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
>  arch/arm/boot/dts/samsung/Makefile                 |   1 +
>  arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 511 +++++++++++++++++++++
>  arch/arm/mach-exynos/firmware.c                    |   4 +-
>  4 files changed, 515 insertions(+), 2 deletions(-)
> ---
> base-commit: d5f0e9098499869354aacb5b080f602f0399d396
> change-id: 20251215-lat3st-staging-d9c926d8a75f
> 
> Best regards,
> --
> Lukas Timmermann <linux@timmermann.space>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: base-commit d5f0e9098499869354aacb5b080f602f0399d396 not known, ignoring
 Base: attempting to guess base-commit...
 Base: tags/next-20251215 (exact match)
 Base: tags/next-20251215 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/samsung/' for 20251215-lat3st-staging-v3-0-2e4914b64dd8@timmermann.space:

arch/arm/boot/dts/samsung/exynos5250-manta.dtb: /soc/i2c@12c70000/led-controller@42: failed to match any schema with compatible: ['ams,as3668']
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clock-names: ['rtc'] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clocks: [[2, 337]] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml

Re: [PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Krzysztof Kozlowski]

On Mon, Dec 15, 2025 at 04:05:21PM +0100, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The bindings for the notification led are already 
> in the kernel mailing list, got recently applied and can be found here:

$ git describe
next-20251217
$ git grep ams,as3668
Nothing.

> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/

That's the posting, if you wanted to convince me, you could link to
actual commits in maintainer's tree.

Please ping me when this reaches next.

Best regards,
Krzysztof

Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 15/12/2025 16:05, Lukas Timmermann wrote:
> +
> +&pinctrl_1 {
> +	bh1721fvc_reset: bh1721fvc-reset-pins {
> +		samsung,pins = "gph1-2";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +	msense_rst: msense-rst-pins {
> +		samsung,pins = "gpg2-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +	};
> +	onewire_sleep: onewire-sleep-pins {
> +		samsung,pins = "gpg0-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
> +		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
> +	};


I really wonder what did you take as reference/starting point. None of
new files follow such syntax without blank lines. Neither do Google
devices for Exynos5250.

Please rewrite the DTS to match the latest used style from arm64. This
also includes sorting pin nodes - if there are not grouped, then by pin
name.

You also got some other comments. In general, if you took recent file as
the starting point then most of the nits would be gone.

Best regards,
Krzysztof

Re: [PATCH v3 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Henrik Grimler]

Hi Lukas,

On Mon, Dec 15, 2025 at 04:05:24PM +0100, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> The firmware trustzone needs a special call to bring up the secondary
> cpu core on the Manta board. This seems to be not needed on other
> exynos5 boards and comes down to the available firmware on
> a particular board.
> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>

Reviewed-by: Henrik Grimler <henrik@grimler.se>

I had a look at the manta bootloader, but have not been able to
pinpoint where the smc calls are handled. Nevertheless, Seems like
manta might be the only Exynos 5 android device that needs CPU1BOOT. I
tried to track down exynos5250-arndale's tzsw to compare with, but
seems like it is no longer available anywhere unfortunately.

Here's a summary of my findings from looking at sboot/the tzsw from
various devices, where `CPU1BOOT SMC is handled == yes` means that the
device needs the SMC call.

.----------------------.--------------.--------------.--------------.
| Device (exynos-)     | Similar tzsw | CPU1BOOT SMC | sboot/tzsw   |
|                      | to odroidxu? | is handled?  |   source     |
.----------------------.--------------.--------------.--------------.
  4212-tab3            | yes          | yes          | T310XXSBQB2
  4412-i9300           | yes          | yes          | I9300XXUGPE1
  4412-i9305           | yes          | yes          | I9305XXUFPB1
  4412-odroid{x,x2,u3} | yes          | yes          | wiki.odroid.com/_media/en/boot.tar.gz
  4412-origen          | no           | don't know   | Linaro's origen hwpack 20130130
  5260-hllte (SM-N7505)| no           | don't know   | N7505XXSDRI2
  5410-odroidxu        | yes          | no           | github.com/hsnaves/exynos5410-firmware
  5410-ja3g            | no           | don't know   | I9500XXUHPK1
  5420-chagall-wifi    | no           | no           | T800XXU1CRJ1
  5420-arndale-octa    | yes          | no           | Linaro's arndale-octa hwpack 20140323
  5422-odroid-xu{3,4}  | yes          | no           | Hardkernel's u-boot 2020.01 branch
  5422-samsung-k3g     | no           | don't know   | G900HXXU1CVG7

As can be seen none of the Exynos 5 devices in the list have been
confirmed to need/handle CPU1BOOT.

Best regards,
Henrik Grimler


> ---
>  arch/arm/mach-exynos/firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index a5e22678e27b..e9b0ed07bb90 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
>  	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
>  	 * because Exynos3250 removes WFE in secure mode.
>  	 *
> -	 * On Exynos5 devices the call is ignored by trustzone firmware.
> +	 * On most Exynos5 devices the call is ignored by trustzone firmware.
>  	 */
>  	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
> -	    !soc_is_exynos4412())
> +	    !soc_is_exynos4412() && !of_machine_is_compatible("google,manta"))
>  		return 0;
>  
>  	/*
> 
> -- 
> 2.52.0
> 
>