From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C618CEBF76 for ; Fri, 27 Sep 2024 05:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lR8CM85Fsk5eJ3v/EmZG9zqhCtPYW4GlO6MdtlhMpMA=; b=uVVLqmPvu4DnJEyL13Ov33YQro PEsxfS7WAxw+a+oUQx7ow/cu1u8I3pilYJFOayJM8nOLKzyai8I+B1eZAZKTrLeV/zJO3Fn/8KeiN 1PjZkYgeI+wvqq2QjbSqz7iQpn7RkC7bMpZfMza6N6yvBWV9aIjkgzcSyyN8wZ96xIjICtRh5JEbI W0fQPfnFTWErOURxLWrXprTP8pp9wzQCUslSmeKk5Q2on1byPIcxL4QSDzBPYtHcuYsSw6d853zNL Ohp4SlIynpGToiIj+KsXHlQChyX0JuKjkaJzQah1QNQ8y9K3MEmmfNKA521bYqcteDheqDbPOj2A5 8Ix9C9EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su3p7-0000000A6AN-0R9Q; Fri, 27 Sep 2024 05:47:25 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su3nv-0000000A5t8-1XJH for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2024 05:46:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1727415969; bh=lR8CM85Fsk5eJ3v/EmZG9zqhCtPYW4GlO6MdtlhMpMA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RsMFxn+1eaz5Dmg6g4v32cjJXYgtYvMCKwIrjOZHe7HXrUGL/pYVBTWkkC0NNL76d SffmDO/0TS1XSFQwTxf971qlXDnC5Z7f+eHXZFpw41p/DJ2VWaLjBo0Otnf9Dl7BSS yUM6UwiRZthYPewTL05yDyhege6GorRtYnxe4Zo0Jihelwndyl/dI/yzg/KAY0a1Ny 7yHpM0rIpFr/66CkN26t+/MwU+jc0Rmt8jkhpTPU+gxg8yymdIrwVoULSx5c0loOHi 31i0gQhKl9lmVXvQDlNhw+3qZiHLh20UHw/qPoleYzbULpbJOa/+PxATqu1qY1UWYj jG3yKUX/qxFkg== Received: from [192.168.68.112] (ppp118-210-187-73.adl-adc-lon-bras34.tpg.internode.on.net [118.210.187.73]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 8919565029; Fri, 27 Sep 2024 13:46:08 +0800 (AWST) Message-ID: <7a97e482c01a32d40fd2a70a839acf239ef28608.camel@codeconstruct.com.au> Subject: Re: [PATCH v1 3/5] ARM: dts: aspeed: yosemite4: Change the address of Fan IC on fan boards From: Andrew Jeffery To: Delphine CC Chiu , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: Ricky CX Wu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 27 Sep 2024 15:16:06 +0930 In-Reply-To: <20240926032821.4171466-4-Delphine_CC_Chiu@wiwynn.com> References: <20240926032821.4171466-1-Delphine_CC_Chiu@wiwynn.com> <20240926032821.4171466-4-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_224611_632872_51DB2561 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu >=20 > Change the address of Fan IC: Max31790 on fan boards according to > schematic. >=20 > Signed-off-by: Ricky CX Wu > Signed-off-by: Delphine CC Chiu > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++------------ > 1 file changed, 8 insertions(+), 16 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b= /arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 430c28bdd314..a7e51725c595 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -496,10 +496,8 @@ adc@1f { > }; > =20 > pwm@20{ > - compatible =3D "max31790"; > + compatible =3D "maxim,max31790"; This isn't changing the address, it's fixing the compatible string. Please make this a separate patch with an appropriate Fixes: tag. > reg =3D <0x20>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; Maybe put this in the same patch as the compatible fix though, if it's correct. > }; > =20 > gpio@22{ > @@ -509,11 +507,9 @@ gpio@22{ > #gpio-cells =3D <2>; > }; > =20 > - pwm@23{ > - compatible =3D "max31790"; > - reg =3D <0x23>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; > + pwm@2f{ > + compatible =3D "maxim,max31790"; > + reg =3D <0x2f>; > }; > =20 > adc@33 { > @@ -539,10 +535,8 @@ adc@1f { > }; > =20 > pwm@20{ > - compatible =3D "max31790"; > + compatible =3D "maxim,max31790"; > reg =3D <0x20>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; As above for this diff hunk too. Andrew > }; > =20 > gpio@22{ > @@ -552,11 +546,9 @@ gpio@22{ > #gpio-cells =3D <2>; > }; > =20 > - pwm@23{ > - compatible =3D "max31790"; > - reg =3D <0x23>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; > + pwm@2f{ > + compatible =3D "maxim,max31790"; > + reg =3D <0x2f>; > }; > =20 > adc@33 {