From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org,
coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, linux-arm-kernel@lists.infradead.org,
mike.leach@linaro.org
Subject: Re: [PATCH] coresight: etm4x: Fix etm4_count race using atomic variable
Date: Mon, 27 Jul 2020 19:42:37 +0530 [thread overview]
Message-ID: <7a98dc32652731e7a795e150e7e8d14f@codeaurora.org> (raw)
In-Reply-To: <c98f0c27-7f0c-cf99-d52b-8a8b1e197ace@arm.com>
On 2020-07-27 15:09, Suzuki K Poulose wrote:
> On 07/27/2020 07:07 AM, Sai Prakash Ranjan wrote:
>> etm4_count keeps track of number of ETMv4 registered and on some
>> systems, a race is observed on etm4_count variable which can
>> lead to multiple calls to cpuhp_setup_state_nocalls_cpuslocked().
>> This function internally calls cpuhp_store_callbacks() which
>> prevents multiple registrations of callbacks for a given state
>> and due to this race, it returns -EBUSY leading to ETM probe
>> failures like below.
>>
>> coresight-etm4x: probe of 7040000.etm failed with error -16
>>
>> This race can easily be triggered with async probe by setting
>> probe type as PROBE_PREFER_ASYNCHRONOUS and with ETM power
>> management property "arm,coresight-loses-context-with-cpu".
>>
>> Prevent this race by converting etm4_count variable to atomic.
>>
>> Fixes: 9b6a3f3633a5 ("coresight: etmv4: Fix CPU power management setup
>> in probe() function")
>> Fixes: 58eb457be028 ("hwtracing/coresight-etm4x: Convert to hotplug
>> state machine")
>> Suggested-by: Mike Leach <mike.leach@linaro.org>
>> (Mike: Rootcause and context for commit message)
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>
> Please could we leave the hotplug notifier installed with the driver
> init and don't worry about this at all ? We bail out early in the
> notifier anyways, if the CPU is not registered with its ETM.
>
Sure thing, sorry for not taking the cue from earlier discussion.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-27 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 6:07 [PATCH] coresight: etm4x: Fix etm4_count race using atomic variable Sai Prakash Ranjan
2020-07-27 8:56 ` Sai Prakash Ranjan
2020-07-27 9:39 ` Suzuki K Poulose
2020-07-27 14:12 ` Sai Prakash Ranjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a98dc32652731e7a795e150e7e8d14f@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).