linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: mt76: add active-low property for led
@ 2023-02-07 13:35 Frank Wunderlich
  2023-02-07 13:36 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2023-02-07 13:35 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
	Shayne Chen, Sean Wang, Kalle Valo, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Matthias Brugger, linux-wireless, netdev, devicetree,
	linux-arm-kernel, linux-kernel

From: Frank Wunderlich <frank-w@public-files.de>

LEDs can be in low-active mode, driver already supports it, but
documentation is missing. Add documentation for the dt property.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2:
- change commit message to mention that driver already support this
---
 .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index f0c78f994491..212508672979 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -112,6 +112,11 @@ properties:
     $ref: /schemas/leds/common.yaml#
     additionalProperties: false
     properties:
+      led-active-low:
+        description:
+          LED is enabled with ground signal.
+        type: boolean
+
       led-sources:
         maxItems: 1
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mt76: add active-low property for led
  2023-02-07 13:35 [PATCH v2] dt-bindings: mt76: add active-low property for led Frank Wunderlich
@ 2023-02-07 13:36 ` Krzysztof Kozlowski
  2023-03-30 17:09   ` Matthias Brugger
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 13:36 UTC (permalink / raw)
  To: Frank Wunderlich, linux-mediatek
  Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
	Shayne Chen, Sean Wang, Kalle Valo, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Matthias Brugger, linux-wireless, netdev, devicetree,
	linux-arm-kernel, linux-kernel

On 07/02/2023 14:35, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> LEDs can be in low-active mode, driver already supports it, but
> documentation is missing. Add documentation for the dt property.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mt76: add active-low property for led
  2023-02-07 13:36 ` Krzysztof Kozlowski
@ 2023-03-30 17:09   ` Matthias Brugger
  2023-03-31 14:22     ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2023-03-30 17:09 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Frank Wunderlich, linux-mediatek,
	Felix Fietkau, Kalle Valo
  Cc: Frank Wunderlich, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, linux-wireless,
	netdev, devicetree, linux-arm-kernel, linux-kernel

Hi Felix and Kalle,

On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
> On 07/02/2023 14:35, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> LEDs can be in low-active mode, driver already supports it, but
>> documentation is missing. Add documentation for the dt property.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Can you take that through your tree or are fine if I take it through mine?

Regards,
Matthias

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mt76: add active-low property for led
  2023-03-30 17:09   ` Matthias Brugger
@ 2023-03-31 14:22     ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-03-31 14:22 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Krzysztof Kozlowski, Frank Wunderlich, linux-mediatek,
	Felix Fietkau, Frank Wunderlich, Lorenzo Bianconi, Ryder Lee,
	Shayne Chen, Sean Wang, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	linux-wireless, netdev, devicetree, linux-arm-kernel,
	linux-kernel

Matthias Brugger <matthias.bgg@gmail.com> writes:

> On 07/02/2023 14:36, Krzysztof Kozlowski wrote:
>> On 07/02/2023 14:35, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> LEDs can be in low-active mode, driver already supports it, but
>>> documentation is missing. Add documentation for the dt property.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>\
>>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Can you take that through your tree or are fine if I take it through mine?

It would be safest if Felix can take this to his tree, less conflicts
the better.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-03-31 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-07 13:35 [PATCH v2] dt-bindings: mt76: add active-low property for led Frank Wunderlich
2023-02-07 13:36 ` Krzysztof Kozlowski
2023-03-30 17:09   ` Matthias Brugger
2023-03-31 14:22     ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).