From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22290CFB44D for ; Mon, 7 Oct 2024 17:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AbMEOw93QpMNA2VLo4O5BMIQ6k/dgsGjKI0UHF5F9yc=; b=WJFGkl4c9CfQUfJuRngkaMt3ZR mauMABeN1sThPmtGHWs/hK0M8aFaEq5VzmwwDQIzr+sdDR0a9DePVI25IjVMr1Sjtx/0rVfIQa4bb GH8+waR7/KkiEU8PiLVHxZq7FUF7bO0F80QjGI59Uf8iw9GznwZZPLk/jUr9IZStvboXzi9Aac1AE p9rqtEuwSYnwsoWHMI5QOx1xJ1SHqRKUZQCJNa63dEr3eMyYrtKhiMA+K2HcSBNNDzE4rO61lm/6+ cM5XcjAIjh6Yalpk5MDYQWrEVpZLvgkgftSGWXyICGoA3DgZ6qhhqoUNQv5y5rTEENGRFrUPukPeS 172EPyvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxrHS-00000003IhR-2FuP; Mon, 07 Oct 2024 17:12:22 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxrFN-00000003I6o-2uVQ for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 17:10:15 +0000 Received: from isaac-ThinkPad-T16-Gen-2.local (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 90ED1792; Mon, 7 Oct 2024 19:00:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728320401; bh=AbMEOw93QpMNA2VLo4O5BMIQ6k/dgsGjKI0UHF5F9yc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=KAx4tdC2+hP7gWXw0kQgcd/huRYwMJ6wLpgLfYLxlw+vwF770PoE01iuMG/sucTRe 19EjJgZJ8bzfgpGWIwH1YdmLmoHS85vvKnGqimzOPM3tNO/yUunbeB2ry7xWTpVoCT JZqGxArpraB98jG/B/WktnJkizqD4aXDg6jieJJY= Message-ID: <7ae0cd7774f4b3e30cc033a7e543546732dbced0.camel@ideasonboard.com> Subject: Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock From: Isaac Scott To: Marek Vasut , Alexander Stein , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , David Airlie , Fabio Estevam , Lucas Stach , "Lukas F . Hartmann" , Maarten Lankhorst , Maxime Ripard , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stefan Agner , Thomas Zimmermann , imx@lists.linux.dev, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, kieran.bingham@ideasonboard.com Date: Mon, 07 Oct 2024 18:01:33 +0100 In-Reply-To: References: <20240531202813.277109-1-marex@denx.de> <1897634.CQOukoFCf9@steina-w> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_101013_903073_A85D66F3 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: > On 6/24/24 11:19 AM, Alexander Stein wrote: > > Am Freitag, 31. Mai 2024, 22:27:21 CEST schrieb Marek Vasut: > > > In case an upstream bridge modified the required clock frequency > > > in its .atomic_check callback by setting adjusted_mode.clock , > > > make sure that clock frequency is generated by the LCDIFv3 block. > > >=20 > > > This is useful e.g. when LCDIFv3 feeds DSIM which feeds TC358767 > > > with (e)DP output, where the TC358767 expects precise timing on > > > its input side, the precise timing must be generated by the > > > LCDIF. > > >=20 > > > Signed-off-by: Marek Vasut > >=20 > > With the other rc358767 patches in place, this does the trick. > > Reviewed-by: Alexander Stein >=20 > I'll pick this up next week if there is no objection. Unfortunately, this has caused a regression that is present in v6.12- rc1 on the i.MX8MP PHYTEC Pollux using the arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts. The display is the edt,etml1010g3dra panel, as per the upstream dts. We bisected to this commit, and reverting this change fixed the screen. We then tried to retest this on top of v6.12-rc2, and found we also had to revert commit ff06ea04e4cf3ba2f025024776e83bfbdfa05155 ("clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate") alongside this. Reverting these two commits makes the display work again at -rc2. Do you have any suggestions on anything we might be missing on our end? Please let me know if there's anything you'd like me to test as I'm not sure what the underlying fault was here. Best wishes, Isaac =C2=A0