From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9885FC36000 for ; Tue, 18 Mar 2025 10:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xJcZ5SDFjX+juN//zvaUH65nPHT7KsSjhYn8IXXtq1g=; b=PI8MdQ3xa0+6IrSjJAYULJMT1i i1JtPtOiAI1UjW//QTvP4TaU8UGePCEk4l6FZpQtCpelSWcQ3VQ3ucdVNqjri8laM5TINP8Vi2JiU 3kO1QOsvu8qc97qn5wkZZUienA8rQn9Po5T/iQi72j/n75efbWgK2pzO+y/oEYycfoqiYcD4Al1SZ Y/Dd4SmUIf+bMxBPRAWDkw8dJRug1NwaJICOvQsc0PTndVi2GBoMG3zJnmyFkSLa/KBERTenwT9/5 FUlCvxDP4Rt4M5ttfB1cBS53lvimwpDXO15qKqpRH35al2v5y1aclABEeku2wUpHILO2BmChmPL+r NI+OzwZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuUMm-00000005Xj7-2JnC; Tue, 18 Mar 2025 10:40:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuUL3-00000005XO5-3wEo for linux-arm-kernel@lists.infradead.org; Tue, 18 Mar 2025 10:38:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 190C813D5; Tue, 18 Mar 2025 03:38:31 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A597F3F63F; Tue, 18 Mar 2025 03:38:18 -0700 (PDT) Message-ID: <7b0af57c-a38c-4c30-9bb7-efe511d6bd1d@arm.com> Date: Tue, 18 Mar 2025 10:38:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/9] dt-bindings: arm: qcom,coresight-static-replicator: add optional clocks To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Neil Armstrong , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Mike Leach , James Clark , Mathieu Poirier , Leo Yan , Kumar Gala , Andy Gross , "Ivan T. Ivanov" , Andy Gross , Georgi Djakov , David Heidelberg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20250317-fix-nexus-4-v1-0-655c52e2ad97@oss.qualcomm.com> <20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com> Content-Language: en-US From: Suzuki K Poulose In-Reply-To: <20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250318_033826_017690_BD43A3AC X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/03/2025 17:44, Dmitry Baryshkov wrote: nit: Subject: s/qcom,coresight-static-replicator/arm,coresight-static-replicator > As most other CoreSight devices the replicator can use either of the > optional clocks (or both). Document those optional clocks in the schema. > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/arm/arm,coresight-static-replicator.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..56e64067ed3d63c5e293a0840858f13428bacb45 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > @@ -30,6 +30,16 @@ properties: > power-domains: > maxItems: 1 > > + clocks: > + minItems: 1 > + maxItems: 2 > + For the static replicator, you don't have an APB clock, as they can't be programmed. It may have an ATB clock. So minItems 0, maxItems: 1 Suzuki > + clock-names: > + minItems: 1 > + enum: > + - apb_pclk > + - atclk > + > in-ports: > $ref: /schemas/graph.yaml#/properties/ports > additionalProperties: false >