From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A941EC5321D for ; Mon, 26 Aug 2024 10:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nXSb7P5yQsC6ZA7aZwkzK/D+oEX3tz1a/6VEPbOOF1M=; b=IMppC86JKp2OBkeVHqscVr4AMV ghHL5t64CJcECwaZBUB+u4hmz6TzvF4F2Lg1tSgPIZ3m/FSOF6C43WYNVwQiDORp5QoyoTXRBL6P0 6HJQuhWvFJFfCXPiU+RymeHNmCXSDtfW3SOIWO1TPtRdV+vb0iETpAzN/4wejN+nCGqOUpMbFXZIL vYzbOaKTWrJ1QErNCUo7GRr691aAeOFov+AKHH0jcvs5Y4UzfVST6NqfkqfP5wKVCr7+LUwl6Zdyq CqeLy/SWc8H1PTx6zSLIOpTr3WgUlEq7n808xDmwHCgOWJRXgDl4a/A8T3MK39HiJU3HKQkPTWyOB MZ3Ehuiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWsD-00000006unS-1OAp; Mon, 26 Aug 2024 10:22:57 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWlK-00000006srT-1BGG for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 10:15:52 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2f3f68dd44bso47248991fa.3 for ; Mon, 26 Aug 2024 03:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724667347; x=1725272147; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nXSb7P5yQsC6ZA7aZwkzK/D+oEX3tz1a/6VEPbOOF1M=; b=djKTjiFcGdFr7VputlJV5mJMDNED/URp3yWp8CCvN1V4FioEBZVSk1Vc8zZEkPgnrb YQ3FVrtb5i6LXXhOF8KrRKQcdeCiQiogaN0uzwZXFwIRp5H+WX/zoMvsBR3DzSDbvrE8 G6skR5VRkImrw+lJL3u1KShy1YYrEP/E/YT03I81hw5+xDRMFSFurIDsBgVSaEMz6DIE RRy9JEALmoCTohyv2L9eKEcI8msW3Ld0lLaOuS+lpR+hI3vqcHQInHuKFzOLfLdrTPoR 4m6T5JU41UIm3zhGkfk5Xy6NjRXLIE2Vep2t9nSsAT5bIoyGwonTX/0NzoNzZH8dVXoq Dy5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724667347; x=1725272147; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nXSb7P5yQsC6ZA7aZwkzK/D+oEX3tz1a/6VEPbOOF1M=; b=D6jI8nd3ufRgpXC0UapJXQG1ZW+Hjs3lmKyTk2j3jE4q0es2zKYHISwrd4L2nFpp0a txt/VrhLmksX0ccGMrp37tnpBpBEq9rHM6MAULkH81nmwbGTbMd92SHLl+mehJlu9NOe W+mBeVZnCq0FSu9gDLOne/icK3LF18E5onnvUy7vrKqmqCMeMrbgyO/Oug8b4dg7bzBf tw3OsojbWGgbsI/zMHU5wp5rVTCwZ6QfIYNFuFvT1fo1H3pNyDUO9W9m5hlC3HTkamSr ocphRayoziA95hRq5djVX7KBtTDS8XlM4UYZdq/FHYFx6wPE4XV+oygiFT6o7hAd2yRo mrrA== X-Forwarded-Encrypted: i=1; AJvYcCVAH/+KFKpFPOlcW9nz+i6k1psm07jNMFE2HjWYBFwW0ESHG0n/iB9jNQQDYL/CWxqv7EP8T5CDV3UPro7Gc8JB@lists.infradead.org X-Gm-Message-State: AOJu0YwHKtVn+fG9svvFdd7KE37XlOchLSfdnlGmNr/UNm8Fbim7qq8b +S3Dt/V/X0TxK8iYwPPOtBq6l1uUMfHBuYInHuz2dquILLH+duHeIivsnjwa9Ts= X-Google-Smtp-Source: AGHT+IGnOO+pYmBeCnoRQo4bouYucQfop3nBZsepSSurhHBVuFJ58XyC2lvaGwZIfEzC6OWNRHTbyQ== X-Received: by 2002:a05:651c:198b:b0:2f0:1a19:f3f1 with SMTP id 38308e7fff4ca-2f4f48f0feamr66567071fa.7.1724667346682; Mon, 26 Aug 2024 03:15:46 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3e8f88sm5421649a12.42.2024.08.26.03.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 03:15:46 -0700 (PDT) Message-ID: <7b16791b-0d7b-49a1-82aa-c4db99ff2bfd@tuxon.dev> Date: Mon, 26 Aug 2024 13:15:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Content-Language: en-US To: Conor Dooley Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> <0d8b1322-cf15-4ed9-b958-06516bbb64c7@tuxon.dev> <20240823-plywood-unfixed-d8d8a2d93f14@spud> <5eae2ddb-2a7b-4c1d-a7f7-41fb39058de1@tuxon.dev> <20240823-dilute-juggle-7e2d43b8b630@spud> From: claudiu beznea In-Reply-To: <20240823-dilute-juggle-7e2d43b8b630@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_031550_366032_30B21739 X-CRM114-Status: GOOD ( 26.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.08.2024 19:33, Conor Dooley wrote: > On Fri, Aug 23, 2024 at 07:26:42PM +0300, claudiu beznea wrote: >> On 23.08.2024 19:18, Conor Dooley wrote: >>> On Fri, Aug 23, 2024 at 10:54:06AM +0300, claudiu beznea wrote: >>>> Hi, Conor, >>>> >>>> On 22.08.2024 19:42, Conor Dooley wrote: >>>>> On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: >>>>>> From: Claudiu Beznea >>>>>> >>>>>> The RZ/G3S System controller has registers to control signals that need >>>>>> to be de-asserted/asserted before/after different SoC areas are power >>>>>> on/off. This signals are implemented as reset signals. For this document >>>>>> the #reset-cells property. >>>>>> >>>>>> Signed-off-by: Claudiu Beznea >>>>>> --- >>>>>> .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ >>>>>> 1 file changed, 16 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>>>> index 4386b2c3fa4d..6b0bb34485d9 100644 >>>>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >>>>>> @@ -42,12 +42,28 @@ properties: >>>>>> - const: cm33stbyr_int >>>>>> - const: ca55_deny >>>>>> >>>>>> + "#reset-cells": >>>>>> + const: 1 >>>>>> + >>>>>> required: >>>>>> - compatible >>>>>> - reg >>>>>> >>>>>> additionalProperties: false >>>>>> >>>>>> +allOf: >>>>>> + - if: >>>>>> + properties: >>>>>> + compatible: >>>>>> + contains: >>>>>> + const: renesas,r9a08g045-sysc >>>>>> + then: >>>>>> + required: >>>>>> + - "#reset-cells" >>>>> >>>>> Given this is new required property on an existing platform, I'd expect >>>>> some mention of why it used to be okay to not have this but is now >>>>> required. Did firmware or a bootloader stage take things out of reset? >>>> >>>> On previous SoCs the SYS controller has no support for controlling the >>>> signals going to different peripherals (USB, PCIE in case of RZ/G3S). >>>> I'll add a note about this on next version. >>> >>> My initial thought here wasn't about previous SoCs though, it was >>> because you didn't add the compatible in this series for /this/ SoC. >> >> RZ/G3S compatible is already present in this file: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml#n26 > > I know, first thing I did when I read the original patch was open the > file ;) > I don't care about the old SoCs, cos you're not applying the property to > them, so what's changed between SoCs isn't really relevant. It's a mention > of why, on this SoC, it is safe to add new required properties that I want. > > AFAIU the answer is that no consumer of the resets existed before, so That's true. > there's not some special state there, and I am guessing that the new > sysc driver you're adding isn't going to fail to probe if there are no > resets, That's true. it just won't register a reset controller? It will register it but, the new sysc driver is going to probe only for this SoC (RZ/G3S). On RZ/G3S we have 2 resets. These well be registered unconditionally, currently, only for RZ/G3S. If there will be no DT users for it then it should be no problem, AFAICT. SYSC variants have common features b/w different SoC variants (one of them being chip identification). The feature implemented though reset controller in this series is not common but particular to RZ/G3S. When the SYSC will be extended for other SoCs the reset driver registration would have to be adapted to not be registered. At the moment, as the SYC is compatible only with RZ/G3S and the reset driver is registered on auxiliary bus though SYSC there is no restriction, reset is registered all the time, but SYSC is only compatible with RZ/G3S. > Which is fine, cos all > devicetrees that have the new peripherals will have #reset-cells etc. > >>> What's worth noting isn't about the prior SoCs, it is about what makes >>> it okay for this one.