From: Martin Kepplinger-Novakovic <martink@posteo.de>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp: Enable gpu passive throttling
Date: Tue, 27 May 2025 06:04:27 +0000 [thread overview]
Message-ID: <7b3c24e2e99acb34b1e95e5b5dedb0ccf383162d.camel@posteo.de> (raw)
In-Reply-To: <20250508101802.489712-1-martink@posteo.de>
Am Donnerstag, dem 08.05.2025 um 10:18 +0000 schrieb Martin Kepplinger-
Novaković:
> Hook up the gpu as a passive cooling device to the thermal zones'
> alert
> trip point just like the cpu.
>
> The gpu here consists of 3D GPU, 2D GPU and NPU.
>
> One way to test would be to set one "alert" trip point low enough
> and watch the cooling device state increase:
>
> echo 10000 > /sys/class/thermal/thermal_zone0/trip_point_0_temp
> watch cat /sys/class/thermal/cooling_device*/cur_state
>
> And of course set the trip point back to its original value and watch
> the cooling device states jump to 0 again.
>
> Signed-off-by: Martin Kepplinger-Novaković <martink@posteo.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 50a07c56faffc..dea9342d071c4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -320,7 +320,10 @@ map0 {
> <&A53_0
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A53_1
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A53_2
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&A53_3
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + <&A53_3
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&gpu3d
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&gpu2d
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&npu
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
> @@ -350,7 +353,10 @@ map0 {
> <&A53_0
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A53_1
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&A53_2
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&A53_3
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + <&A53_3
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&gpu3d
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&gpu2d
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&npu
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
> @@ -2229,6 +2235,7 @@ gpu3d: gpu@38000000 {
> <&clk IMX8MP_CLK_GPU_ROOT>,
> <&clk IMX8MP_CLK_GPU_AHB>;
> clock-names = "core", "shader", "bus", "reg";
> + #cooling-cells = <2>;
> assigned-clocks = <&clk
> IMX8MP_CLK_GPU3D_CORE>,
> <&clk
> IMX8MP_CLK_GPU3D_SHADER_CORE>;
> assigned-clock-parents = <&clk
> IMX8MP_SYS_PLL2_1000M>,
> @@ -2245,6 +2252,7 @@ gpu2d: gpu@38008000 {
> <&clk IMX8MP_CLK_GPU_ROOT>,
> <&clk IMX8MP_CLK_GPU_AHB>;
> clock-names = "core", "bus", "reg";
> + #cooling-cells = <2>;
> assigned-clocks = <&clk
> IMX8MP_CLK_GPU2D_CORE>;
> assigned-clock-parents = <&clk
> IMX8MP_SYS_PLL2_1000M>;
> assigned-clock-rates = <1000000000>;
> @@ -2302,6 +2310,7 @@ npu: npu@38500000 {
> <&clk IMX8MP_CLK_ML_AXI>,
> <&clk IMX8MP_CLK_ML_AHB>;
> clock-names = "core", "shader", "bus", "reg";
> + #cooling-cells = <2>;
> power-domains = <&pgc_mlmix>;
> };
>
hi Shawn and all,
Do you have any objections or second thoughts about this?
thank you,
martin
next prev parent reply other threads:[~2025-05-27 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 10:18 [PATCH] arm64: dts: imx8mp: Enable gpu passive throttling Martin Kepplinger-Novaković
2025-05-27 6:04 ` Martin Kepplinger-Novakovic [this message]
2025-06-11 9:16 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3c24e2e99acb34b1e95e5b5dedb0ccf383162d.camel@posteo.de \
--to=martink@posteo.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox