linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: da850-lcdk: add unit name for memory node
Date: Tue, 17 Apr 2018 11:55:38 -0500	[thread overview]
Message-ID: <7b7caa27-4bb9-db73-0070-1566a4be34d5@lechnology.com> (raw)
In-Reply-To: <20180417100128.23011-3-nsekhar@ti.com>

On 04/17/2018 05:01 AM, Sekhar Nori wrote:
> Add unit name for memory node to squash the W=1 warning:
> 
> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>   arch/arm/boot/dts/da850-lcdk.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
> index a1f4d6d5a569..e80839bb071b 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -21,7 +21,7 @@
>   		stdout-path = "serial2:115200n8";
>   	};
>   
> -	memory {
> +	memory at c0000000 {
>   		device_type = "memory";

Should we drop `device_type = "memory";` since it is now specified
in da850.dtsi?

>   		reg = <0xc0000000 0x08000000>;

I wouldn't mind a comment that says that this is 128MiB. The number
is too big for me to do the hex in my head. :-)

>   	};
> 

  reply	other threads:[~2018-04-17 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 10:01 [PATCH 0/2] ARM: dts: da850: fix warnings related to memory node Sekhar Nori
2018-04-17 10:01 ` [PATCH 1/2] ARM: dts: da850: get rid of skeleton.dtsi Sekhar Nori
2018-04-17 16:52   ` David Lechner
2018-04-17 10:01 ` [PATCH 2/2] ARM: dts: da850-lcdk: add unit name for memory node Sekhar Nori
2018-04-17 16:55   ` David Lechner [this message]
2018-04-18  8:21     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b7caa27-4bb9-db73-0070-1566a4be34d5@lechnology.com \
    --to=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).