From mboxrd@z Thu Jan  1 00:00:00 1970
From: david@lechnology.com (David Lechner)
Date: Tue, 17 Apr 2018 11:55:38 -0500
Subject: [PATCH 2/2] ARM: dts: da850-lcdk: add unit name for memory node
In-Reply-To: <20180417100128.23011-3-nsekhar@ti.com>
References: <20180417100128.23011-1-nsekhar@ti.com>
 <20180417100128.23011-3-nsekhar@ti.com>
Message-ID: <7b7caa27-4bb9-db73-0070-1566a4be34d5@lechnology.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 04/17/2018 05:01 AM, Sekhar Nori wrote:
> Add unit name for memory node to squash the W=1 warning:
> 
> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>   arch/arm/boot/dts/da850-lcdk.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
> index a1f4d6d5a569..e80839bb071b 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -21,7 +21,7 @@
>   		stdout-path = "serial2:115200n8";
>   	};
>   
> -	memory {
> +	memory at c0000000 {
>   		device_type = "memory";

Should we drop `device_type = "memory";` since it is now specified
in da850.dtsi?

>   		reg = <0xc0000000 0x08000000>;

I wouldn't mind a comment that says that this is 128MiB. The number
is too big for me to do the hex in my head. :-)

>   	};
>