From: Robin Murphy <robin.murphy@arm.com>
To: Adam Van Ymeren <adam@vany.ca>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator
Date: Sat, 1 Feb 2020 10:51:12 +0000 [thread overview]
Message-ID: <7b9829b3-e2d2-95b1-03cb-1af7a3c6acad@arm.com> (raw)
In-Reply-To: <87imkryz5t.fsf@vany.ca>
Hi Adam,
On 2020-01-31 11:38 pm, Adam Van Ymeren wrote:
> With this change the kernel successfully finds the SD Card and can load
> a rootfs from it. Tested on hardware.
>
> Signed-off-by: Adam Van Ymeren <adam@vany.ca>
>
> diff -uprN -X linux-5.5/Documentation/dontdiff linux-5.5-orig/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts linux-5.5/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> --- linux-5.5-orig/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts 2020-01-26 19:23:03.000000000 -0500
> +++ linux-5.5/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts 2020-01-31 16:26:35.377075419 -0500
> @@ -44,7 +44,7 @@
>
> vcc_sdio: sdmmcio-regulator {
> compatible = "regulator-gpio";
> - gpios = <&grf_gpio 0 GPIO_ACTIVE_HIGH>;
> + gpios = <&gpio0 RK_PD1 GPIO_ACTIVE_HIGH>;
Given that the RK3328 datasheet has no mention of GPIO0_D1 existing at
all, how sure are you that this is correct - have you tested cards in
both 3.3V and 1.8V (UHS-1) signalling modes?
The ROC-RK3328-CC schematics show GPIO_MUTE being used to bias the
feedback pin of an adjustable regulator supplying the SDMMC0 I/O domain,
so it seems more likely that the pin is correct but the states (or the
polarity) are backwards.
Robin.
> states = <1800000 0x1
> 3300000 0x0>;
> regulator-name = "vcc_sdio";
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-01 10:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 23:38 [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator Adam Van Ymeren
2020-02-01 10:51 ` Robin Murphy [this message]
2020-02-01 15:41 ` Adam Van Ymeren
2020-02-01 17:46 ` Robin Murphy
2020-02-01 22:10 ` Adam Van Ymeren
2020-02-04 15:15 ` Peter Geis
2020-02-04 16:14 ` Adam Van Ymeren
2020-02-04 17:25 ` Peter Geis
2020-02-05 16:14 ` Adam Van Ymeren
2020-02-05 17:39 ` Robin Murphy
2020-02-05 18:43 ` Peter Geis
2020-02-05 19:02 ` Robin Murphy
2020-02-06 3:05 ` Thomas McKahan
2020-02-09 1:07 ` Adam Van Ymeren
2020-02-10 13:37 ` Robin Murphy
2020-02-11 21:32 ` Adam Van Ymeren
2020-02-11 21:39 ` Adam Van Ymeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9829b3-e2d2-95b1-03cb-1af7a3c6acad@arm.com \
--to=robin.murphy@arm.com \
--cc=adam@vany.ca \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox