* [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string
@ 2024-05-20 22:27 Rob Herring (Arm)
2024-05-21 13:12 ` Olivier MOYSAN
2024-05-21 14:45 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-05-20 22:27 UTC (permalink / raw)
To: Olivier Moysan, Arnaud Pouliquen, Liam Girdwood, Mark Brown,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue
Cc: alsa-devel, linux-sound, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
The compatible pattern "st,stm32-sai-sub-[ab]" is missing starting and
ending anchors, so any prefix and/or suffix would still be valid.
This also fixes a warning on the example:
Documentation/devicetree/bindings/sound/st,stm32-sai.example.dtb: /example-0/sai@4400b000/audio-controller@4400b004: failed to match any schema with compatible: ['st,stm32-sai-sub-a']
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
index 59df8a832310..f555ccd6b00a 100644
--- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
+++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
@@ -68,7 +68,7 @@ patternProperties:
properties:
compatible:
description: Compatible for SAI sub-block A or B.
- pattern: "st,stm32-sai-sub-[ab]"
+ pattern: "^st,stm32-sai-sub-[ab]$"
"#sound-dai-cells":
const: 0
--
2.43.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string
2024-05-20 22:27 [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string Rob Herring (Arm)
@ 2024-05-21 13:12 ` Olivier MOYSAN
2024-05-21 14:45 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Olivier MOYSAN @ 2024-05-21 13:12 UTC (permalink / raw)
To: Rob Herring (Arm), Arnaud Pouliquen, Liam Girdwood, Mark Brown,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue
Cc: alsa-devel, linux-sound, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On 5/21/24 00:27, Rob Herring (Arm) wrote:
> The compatible pattern "st,stm32-sai-sub-[ab]" is missing starting and
> ending anchors, so any prefix and/or suffix would still be valid.
>
> This also fixes a warning on the example:
>
> Documentation/devicetree/bindings/sound/st,stm32-sai.example.dtb: /example-0/sai@4400b000/audio-controller@4400b004: failed to match any schema with compatible: ['st,stm32-sai-sub-a']
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> index 59df8a832310..f555ccd6b00a 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> @@ -68,7 +68,7 @@ patternProperties:
> properties:
> compatible:
> description: Compatible for SAI sub-block A or B.
> - pattern: "st,stm32-sai-sub-[ab]"
> + pattern: "^st,stm32-sai-sub-[ab]$"
>
> "#sound-dai-cells":
> const: 0
Reviewed-by: Olivier Moysan <olivier.moysan@foss.st.com>
Thanks
Olivier
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string
2024-05-20 22:27 [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string Rob Herring (Arm)
2024-05-21 13:12 ` Olivier MOYSAN
@ 2024-05-21 14:45 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-05-21 14:45 UTC (permalink / raw)
To: Olivier Moysan, Arnaud Pouliquen, Liam Girdwood,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Rob Herring (Arm)
Cc: alsa-devel, linux-sound, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel
On Mon, 20 May 2024 17:27:05 -0500, Rob Herring (Arm) wrote:
> The compatible pattern "st,stm32-sai-sub-[ab]" is missing starting and
> ending anchors, so any prefix and/or suffix would still be valid.
>
> This also fixes a warning on the example:
>
> Documentation/devicetree/bindings/sound/st,stm32-sai.example.dtb: /example-0/sai@4400b000/audio-controller@4400b004: failed to match any schema with compatible: ['st,stm32-sai-sub-a']
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string
commit: 737ce4fb96206f999ddea7530145fc0e8abd5d31
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-21 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-20 22:27 [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string Rob Herring (Arm)
2024-05-21 13:12 ` Olivier MOYSAN
2024-05-21 14:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).