From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B15C433DB for ; Sun, 21 Feb 2021 11:29:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8322164EE0 for ; Sun, 21 Feb 2021 11:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8322164EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2prO02bEMiBqVlnmYyA24OYFWCL3yvSDi999DtqrnNo=; b=t7sJOQH8TbS0n+WmTm4X+Ckwy rweLQ5CIXkVeT9CQD+spri5hoRu7wLKSQgRt1Y8IJXxs/+AUSbF4V4HLR7VSzS/Dxe9R7tzRV/Z+8 E9JKBfiWVHZaWFCAyJWbV7f+wkC9toWrqbt9fVYjnG/AhNpS4fLJGkCQqG7tRi8yipdeZq/miMTzc uOmMxtew5Mx8lKXsW9OZcEoy71rGcktnZeOSgGBp1bJjNyvolv1TX88ymH+D6Sc40rrXtOFtrgral WyWrnpyzxrcEfv+2NoH1STXxSiD3EOIXgOkjXskfPyXFGTqgY4Pm0rtMJ+34SHx0NZRTcwAYM0V1q 27jrRlrRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDmuW-0004kT-SB; Sun, 21 Feb 2021 11:28:24 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDmuU-0004k7-9g for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 11:28:23 +0000 Received: by mail-lj1-x232.google.com with SMTP id g1so40724076ljj.13 for ; Sun, 21 Feb 2021 03:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XailET+Iz0kS61iHBGbLnnT1v04j2RILsJcsZVq8qik=; b=lh/3mdQ+xAZKSuK5gv22xNPa6GEkldcs0lgL5hVKw0TgzXphO7b2Fu6fUZrprxNk7H H/zP2VmHVFQkLwyy3T30wksKBWug+vwowuGfAateyeM+RpoJrH6TjD7WNyDxLGip3bAc lNvYfSR92evbcGDK3SiWwwsypGyU+7Dbk2gp60tJx5fUMJAAQoky26xlpq0YiiXLcseq V/hBgDuxM5bih1GG6nyvhtdKSTXDgRuQw7QSJXi1AFQ7zNx1/SeySh19Ujz9rZg8Bqzb brDdYuSEYnSZ90eeNZHWIA1IxWpc5SGuu0inRmdcj0k3WG3pIwX0Bj8nyt/hl5cPrp0L /X3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XailET+Iz0kS61iHBGbLnnT1v04j2RILsJcsZVq8qik=; b=uXqJJ6Ub2Hu/gjuWmlEKbpb9K7eHAB777LLN35iIxk5GKaFbo+oujBp1mA9tAa9PYd 4MP7QlHVKPRM3CNqnMLc3dcNcc0Euj4Oztc7PDABYA/yll+hdntBpowoWvapXDnUkUxH 1tEOM2GuxM6qXQcRho9HYZA/KHrfTQGS6zgGdWOOUAJzGV3HPErjlSQ/RkNmcPPjf36t sXoFusob/qvchPyKlSlXKg7pGinBRLhpY2WTzz8RBritZxe5ajtpqAsVwIrkn1/ma5n3 jcwy9im6XMjPf+VdgfgVaohlfoVJri3pCJlf1dY3ClSH3Yhp5sq3ELFGcySt7ecF0MKw LpMQ== X-Gm-Message-State: AOAM530ITxisrA96K8hAHUYovzRq4S+1SSBHKdD8X5qyPztVdXU4cym8 aopRZp3nDXHVvXXcy3MdJdw= X-Google-Smtp-Source: ABdhPJwiJy5T8cZv/11xeat3V6sbW5pu72MNEX6NOIO6KFTr9udo0S9iL6GikugUnw2/EdfL7/ypQQ== X-Received: by 2002:a05:6512:11d1:: with SMTP id h17mr10792421lfr.116.1613906898546; Sun, 21 Feb 2021 03:28:18 -0800 (PST) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id g24sm273950ljl.122.2021.02.21.03.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 03:28:18 -0800 (PST) Subject: Re: [PATCH v2 2/4] leds: Add driver for QCOM SPMI Flash LEDs To: Pavel Machek References: <20210126140240.1517044-1-nfraprado@protonmail.com> <20210126140240.1517044-3-nfraprado@protonmail.com> <20210219110227.GG19207@duo.ucw.cz> From: Jacek Anaszewski Message-ID: <7bb757c7-55af-66a4-aa12-fe646a19fcf6@gmail.com> Date: Sun, 21 Feb 2021 12:28:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210219110227.GG19207@duo.ucw.cz> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_062822_415703_19BC05C0 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, lkcamp@lists.libreplanetbr.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Russell King , Rob Herring , Bjorn Andersson , Luca Weiss , Andy Gross , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Dan Murphy , andrealmeid@collabora.com, Georgi Djakov , linux-leds@vger.kernel.org, Brian Masney Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/19/21 12:02 PM, Pavel Machek wrote: > Hi! > >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >> >> Please sort includes alphabetically. > > No need to do that. Keeping the includes sorted eliminates the risk of introducing duplicates and allows for faster lookup. What gain is in having them unsorted? >>> +#define FLASH_SAFETY_TIMER 0x40 >> >> Namespacing prefix is needed for macros, e.g. QCOM_FLASH*. > > No need for that in .c files. In general it eliminates the risk of name clash with other subsystems headers. And actually the prefix here should be QCOM_LED_FLASH to avoid ambiguity with flash memory. If you dropped the vendor prefix then you'd get possible name clash with led-class-flash.h namespace prefix. -- Best regards, Jacek Anaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel