From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCC67ECE564 for ; Tue, 10 Sep 2024 14:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FNAcMMQvErS3/HJiJVrNMz8DQTCwPMR3vMspJu0zDsA=; b=N+s01ZtEP8SX0PztmA42Tm1QRo Bjmhu5pKGhFdsYTRSHS4yyN/8HVSjD2X1T48ZbtOhjyOUBcGbgZFhffwuym1l9C6F9UTvseAR+sDh zeMc/AMiOjFtYdlPgaeEf8AfxJNsIEAiS+TVOYeJ4snJ2rOvOJnGpJTM4ZmjUHQgyHrLJ9O9trqqE ubwwOKG9KeCpnVo+87CiHu0K+yprUnYY9RNAKjIsw+z+t4gAkK3tAHaotefXrMGwY4+00I6IEi5QP YbtsitD9aG0q5fK/8mESaDVC4dphoePag7asByaE74wpRWrx/dFLRonWcnSiqDIC3UAa1ReHgtq+3 XMgu5XKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so1uE-00000005sWT-3gLD; Tue, 10 Sep 2024 14:31:46 +0000 Received: from out-189.mta1.migadu.com ([95.215.58.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so1tC-00000005sNA-1kbd for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 14:30:44 +0000 Message-ID: <7bd2dbef-643a-4258-af1c-b68bff980b22@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725978639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNAcMMQvErS3/HJiJVrNMz8DQTCwPMR3vMspJu0zDsA=; b=jNoQDvtAANjmAIDum+RAkv0SB54IPDOkc/nJ8hwH4eK8dPbhC/pwpb4WBVwHriCkdv3mSe nhkQ4SI/ehrgc21C/GOv8tnOc5jT1fswJpSEuQrqH57QDNXRjP/qV7CqTgxWJTjPb2j6lf czAFEsj3tjyQRzx5Fj/2ayGBWZShE94= Date: Tue, 10 Sep 2024 10:30:35 -0400 MIME-Version: 1.0 Subject: Re: [RFC PATCH net-next v2 0/6] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM To: "Nelson, Shannon" , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Radhey Shyam Pandey , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, Heng Qi References: <20240909235208.1331065-1-sean.anderson@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_073042_625314_8C694402 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/9/24 21:34, Nelson, Shannon wrote: > On 9/9/2024 4:52 PM, Sean Anderson wrote: >> >> To improve performance without sacrificing latency under low load, >> enable DIM. While I appreciate not having to write the library myself, I >> do think there are many unusual aspects to DIM, as detailed in the last >> patch. >> >> This series depends on [1-2] and is therefore marked RFC. This series is >> otherwise ready to merge. >> >> [1] https://lore.kernel.org/netdev/20240909230908.1319982-1-sean.anderson@linux.dev/ >> [2] https://lore.kernel.org/netdev/20240909231904.1322387-1-sean.anderson@linux.dev/ >> >> Changes in v2: >> - Add some symbolic constants for IRQ delay timer >> - Report an error for bad coalesce settings >> - Don't use spin_lock_irqsave when we know the context >> - Split the CR calculation refactor from runtime coalesce settings >>    adjustment support for easier review. >> - Have axienet_update_coalesce_rx/tx take the cr value/mask instead of >>    calculating it with axienet_calc_cr. This will make it easier to add >>    partial updates in the next few commits. >> - Get coalesce parameters from driver state >> - Don't take the RTNL in axienet_rx_dim_work to avoid deadlock. Instead, >>    calculate a partial cr update that axienet_update_coalesce_rx can >>    perform under a spin lock. >> - Use READ/WRITE_ONCE when accessing/modifying rx_irqs >> >> Sean Anderson (6): >>    net: xilinx: axienet: Add some symbolic constants for IRQ delay timer >>    net: xilinx: axienet: Report an error for bad coalesce settings >>    net: xilinx: axienet: Combine CR calculation >>    net: xilinx: axienet: Support adjusting coalesce settings while >>      running >>    net: xilinx: axienet: Get coalesce parameters from driver state >>    net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM >> >>   drivers/net/ethernet/xilinx/Kconfig           |   1 + >>   drivers/net/ethernet/xilinx/xilinx_axienet.h  |  31 +- >>   .../net/ethernet/xilinx/xilinx_axienet_main.c | 320 ++++++++++++++---- >>   3 files changed, 273 insertions(+), 79 deletions(-) >> >> -- >> 2.35.1.1320.gc452695387.dirty >> >> > > Except for a couple of comment nits pointed out in 3/6 and 6/6, this set seems reasonable. > > Reviewed by: Shannon Nelson > > Thanks. I'll address these for v3. --Sean