From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59BDBC433F5 for ; Thu, 2 Dec 2021 12:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jwrCvbdXUNMDmn1ffUmxsdnQuwR1RqW3skH8akzMQVo=; b=puX0sIN4I+E7Hls8AamcpKOhUF u1TjbEUPtGWRqgJ/HVhPUEzGADnkaJUBYy4ACfRALdauj98Ctl9VbuuRdP3s5HITs4i1AH6hNjO63 C7WRbafBQ7pRuOsE9xZFMz8ImLDsSEFm60IcEgrDqHR6ZEXwRH1H3+lBhUihynmqSNCXJqIdXDIls 1VjPiVFk11eMQ+RuTG29JQcSVfJHVtpLkVcmW4fZlTz7tkE2WrLadeuaYXmm3e2vWDr75KLkLIbdl 4b20lDsF2LmPeFt92AMvoTvZZipvga3OlmOXPpphKziTKIr2RBMShfASnOyyIXZ9tgGY30zPA8DD7 VRAzTUYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mslYl-00CO5n-AG; Thu, 02 Dec 2021 12:51:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mslYg-00CO4d-TN for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 12:51:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638449489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=deqfuKvFlU9prDfs0QlbobyXt/WvDKmo8HiTDuibat4=; b=HuZlZhKcdBBV9rWlyqiIdVHuT/QiC+WgdvDXW9IlzJeR9OWcdWNMSb8K9c89/7N4hHRYNc g4npxX9As+Zneu0kW0cqMAUgHahdaAF3l4PQUgSInGrPLpetbkepkr1goOXsAI8TTHFC4E 3jph5qmCB4BqWKyJ5T5K3czvriw5sp4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-9_d2tS_oOOSHlt8wyQUOHw-1; Thu, 02 Dec 2021 07:51:28 -0500 X-MC-Unique: 9_d2tS_oOOSHlt8wyQUOHw-1 Received: by mail-wm1-f69.google.com with SMTP id g11-20020a1c200b000000b003320d092d08so13942284wmg.9 for ; Thu, 02 Dec 2021 04:51:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=deqfuKvFlU9prDfs0QlbobyXt/WvDKmo8HiTDuibat4=; b=S4krGHlXmFZszmuf5JUoBgSTyTrE6HhrfG0zWVefsrm13iTcvgpy6KNPPh5lqUJW9Z 0vz8O31OC0LTb56H2mLcnglwvRg+PLaTG/zpokfOq4en8fhnDyP6rmVtq+AJT3giLp43 j4hzqjZ03OrmATu2RNx1MQfkQonytl1bPGVqlPLlf1sjnnIPdeExRnB20Ax0NPaZHGZc FstW7iapw1z7WIc/6E6/l1aG43AhHb9IhwXzR33gajgMr2qtLe9A4siH87Dp8WmJa//V eg7jmiD1stCt8Un6ttKp4MAOclFu87Wt/Ub4/iPbL6hNV8bLtKFF9am3nLuu+qJ+Cr/z 8y9w== X-Gm-Message-State: AOAM532r1IIPbMO0yO/2rXRWfNsgEruSDeLK3BhvRQDB1zsEDQkHF0sW G4yYDhP3AhTIcpJASvMCdCyU6HtG4/dv/ULsiUfVOuZTmk4ExXTfXmz0yfOETX+sG7+MJwZ4+pe ogaiemxYrMi7sQTH1w3zmkx53+VPQECe6Q2pkm5FGDSTjWhOolTLQX3PsfLUMxuMf+QQqvpbEsQ CQNK1bcl5R X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr14240060wrw.57.1638449487043; Thu, 02 Dec 2021 04:51:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQ4L4RACt5bxDAh35D/Rf+GaYVbUyzp4mc9eCtgosGSFiC+k8s5hy2mnjiEMXjE86duU5msA== X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr14240024wrw.57.1638449486677; Thu, 02 Dec 2021 04:51:26 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id g18sm2622717wmq.4.2021.12.02.04.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 04:51:26 -0800 (PST) Subject: Re: [RFC PATCH v3 03/29] KVM: arm64: Introduce struct id_reg_info To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will Deacon , Peter Shier , Paolo Bonzini , linux-arm-kernel@lists.infradead.org References: <20211117064359.2362060-1-reijiw@google.com> <20211117064359.2362060-4-reijiw@google.com> <57519386-0a30-40a6-b46f-d20595df0b86@redhat.com> From: Eric Auger Message-ID: <7bfd6fb8-40af-1da0-6336-8289c417d175@redhat.com> Date: Thu, 2 Dec 2021 13:51:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eauger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_045131_072343_BD874F80 X-CRM114-Status: GOOD ( 33.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/25/21 7:40 AM, Reiji Watanabe wrote: > Hi Eric, > > On Wed, Nov 24, 2021 at 1:07 PM Eric Auger wrote: >> >> Hi Reiji, >> >> On 11/17/21 7:43 AM, Reiji Watanabe wrote: >>> This patch lays the groundwork to make ID registers writable. >>> >>> Introduce struct id_reg_info for an ID register to manage the >>> register specific control of its value for the guest, and provide set >>> of functions commonly used for ID registers to make them writable. >>> >>> The id_reg_info is used to do register specific initialization, >>> validation of the ID register and etc. Not all ID registers must >>> have the id_reg_info. ID registers that don't have the id_reg_info >>> are handled in a common way that is applied to all ID registers. >>> >>> At present, changing an ID register from userspace is allowed only >>> if the ID register has the id_reg_info, but that will be changed >>> by the following patches. >>> >>> No ID register has the structure yet and the following patches >>> will add the id_reg_info for some ID registers. >>> >>> Signed-off-by: Reiji Watanabe >>> --- >>> arch/arm64/include/asm/sysreg.h | 1 + >>> arch/arm64/kvm/sys_regs.c | 226 ++++++++++++++++++++++++++++++-- >>> 2 files changed, 218 insertions(+), 9 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h >>> index 16b3f1a1d468..597609f26331 100644 >>> --- a/arch/arm64/include/asm/sysreg.h >>> +++ b/arch/arm64/include/asm/sysreg.h >>> @@ -1197,6 +1197,7 @@ >>> #define ICH_VTR_TDS_MASK (1 << ICH_VTR_TDS_SHIFT) >>> >>> #define ARM64_FEATURE_FIELD_BITS 4 >>> +#define ARM64_FEATURE_FIELD_MASK ((1ull << ARM64_FEATURE_FIELD_BITS) - 1) >>> >>> /* Create a mask for the feature bits of the specified feature. */ >>> #define ARM64_FEATURE_MASK(x) (GENMASK_ULL(x##_SHIFT + ARM64_FEATURE_FIELD_BITS - 1, x##_SHIFT)) >>> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >>> index 5608d3410660..1552cd5581b7 100644 >>> --- a/arch/arm64/kvm/sys_regs.c >>> +++ b/arch/arm64/kvm/sys_regs.c >>> @@ -265,6 +265,181 @@ static bool trap_raz_wi(struct kvm_vcpu *vcpu, >>> return read_zero(vcpu, p); >>> } >>> >>> +/* >>> + * A value for FCT_LOWER_SAFE must be zero and changing that will affect >>> + * ftr_check_types of id_reg_info. >>> + */ >>> +enum feature_check_type { >>> + FCT_LOWER_SAFE = 0, >>> + FCT_HIGHER_SAFE, >>> + FCT_HIGHER_OR_ZERO_SAFE, >>> + FCT_EXACT, >>> + FCT_EXACT_OR_ZERO_SAFE, >>> + FCT_IGNORE, /* Don't check (any value is fine) */ >>> +}; >>> + >>> +static int arm64_check_feature_one(enum feature_check_type type, int val, >>> + int limit) >>> +{ >>> + bool is_safe = false; >>> + >>> + if (val == limit) >>> + return 0; >>> + >>> + switch (type) { >>> + case FCT_LOWER_SAFE: >>> + is_safe = (val <= limit); >>> + break; >>> + case FCT_HIGHER_OR_ZERO_SAFE: >>> + if (val == 0) { >>> + is_safe = true; >>> + break; >>> + } >>> + fallthrough; >>> + case FCT_HIGHER_SAFE: >>> + is_safe = (val >= limit); >>> + break; >>> + case FCT_EXACT: >>> + break; >>> + case FCT_EXACT_OR_ZERO_SAFE: >>> + is_safe = (val == 0); >>> + break; >>> + case FCT_IGNORE: >>> + is_safe = true; >>> + break; >>> + default: >>> + WARN_ONCE(1, "Unexpected feature_check_type (%d)\n", type); >>> + break; >>> + } >>> + >>> + return is_safe ? 0 : -1; >>> +} >>> + >>> +#define FCT_TYPE_MASK 0x7 >>> +#define FCT_TYPE_SHIFT 1 >>> +#define FCT_SIGN_MASK 0x1 >>> +#define FCT_SIGN_SHIFT 0 >>> +#define FCT_TYPE(val) ((val >> FCT_TYPE_SHIFT) & FCT_TYPE_MASK) >>> +#define FCT_SIGN(val) ((val >> FCT_SIGN_SHIFT) & FCT_SIGN_MASK) >>> + >>> +#define MAKE_FCT(shift, type, sign) \ >>> + ((u64)((((type) & FCT_TYPE_MASK) << FCT_TYPE_SHIFT) | \ >>> + (((sign) & FCT_SIGN_MASK) << FCT_SIGN_SHIFT)) << (shift)) >>> + >>> +/* For signed field */ >>> +#define S_FCT(shift, type) MAKE_FCT(shift, type, 1) >>> +/* For unigned field */ >>> +#define U_FCT(shift, type) MAKE_FCT(shift, type, 0) >>> + >>> +/* >>> + * @val and @lim are both a value of the ID register. The function checks >>> + * if all features indicated in @val can be supported for guests on the host, >>> + * which supports features indicated in @lim. @check_types indicates how >>> + * features in the ID register needs to be checked. >>> + * See comments for id_reg_info's ftr_check_types field for more detail. >>> + */ >>> +static int arm64_check_features(u64 check_types, u64 val, u64 lim) >>> +{ >>> + int i; >>> + >>> + for (i = 0; i < 64; i += ARM64_FEATURE_FIELD_BITS) { >>> + u8 ftr_check = (check_types >> i) & ARM64_FEATURE_FIELD_MASK; >>> + bool is_sign = FCT_SIGN(ftr_check); >>> + enum feature_check_type fctype = FCT_TYPE(ftr_check); >>> + int fval, flim, ret; >>> + >>> + fval = cpuid_feature_extract_field(val, i, is_sign); >>> + flim = cpuid_feature_extract_field(lim, i, is_sign); >>> + >>> + ret = arm64_check_feature_one(fctype, fval, flim); >>> + if (ret) >>> + return -E2BIG; >> nit: -EINVAL may be better because depending on the check type this may >> not mean too big. > > Yes, that is correct. > > This error case means that userspace tried to configure features > or a higher level of features that were not supported on the host. > In that sense, I chose -E2BIG. > > I wanted to use an error code specific to this particular case, which > I think makes debugging userspace issue easier when KVM_SET_ONE_REG > fails, and I couldn't find other error codes that fit this case better. > So, I'm trying to avoid using -EINVAL, which is used for other failure > cases. > > If you have any other suggested error code for this, > that would be very helpful:) OK faire enought, that's a nit anyway Eric > > Thanks, > Reiji > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel