From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC7D9C5472C for ; Sat, 24 Aug 2024 15:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ts73yed3JhHDo+YK42L9Fku1808x980k6/11d2gW9QU=; b=yAJfk+iXcePZ+oWZPok5eHA02G YKVFqH5DTbZgNHY8gsFTS9We/xLvSr85yaVsMjEKZJHKUo6DkYH4l8MCCw0QbA1/m0gTnUDxtZV+h nGdwUDmHE9WsXHGnes69tdpuas7FGZjLpbJYi+iShW98zOmgSPQ1lAV4ZNlmxLra5Q7gBXmhWvT5f OC7lgeINrEbIHFGyvX0N9ntRzI3wbOzkDp864d8/4JpuLZLAAeqKFoBgToFnNdH4cLjyd5Vfp/yNc 0wolvBLzAVyPlKvdRn9OgrO6e6uLyo0BJY3svA4ByWHgC2pVk9DUwzRrh6tRPneV7FhOizF2zVgvu S3M9u1EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht5b-00000002TzM-0kXQ; Sat, 24 Aug 2024 15:54:07 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht3x-00000002Tfj-1pm3 for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2024 15:52:26 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5bb85e90ad5so2669664a12.3 for ; Sat, 24 Aug 2024 08:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724514743; x=1725119543; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ts73yed3JhHDo+YK42L9Fku1808x980k6/11d2gW9QU=; b=R6VVIz45d4Q6IIlZ5VW/s2VSU5DQ+G2TY09ioA8RZHm2YXy3brhK3z434EMzYADmPv xAnPQEWGxGcDnvGZS2shRuruvlRn27ifn9vMdDeZdGHxmooWgInEpzZSuD/4Rf5hYlaq 1+KOi5VWxT15HkTTbkbAChDwdQmSRz1R7HbAHeQROf2pdl5shYyeitboqNnvxEs0qNyw rleHZ9pOvewV5SjkD8lBIvx9ahenjpaYREFEMXFFkv0ZzfVVMamHI/NYVWEGcdUSZUqD HzncL/F4mJhbpuvRLb7jShVr3vCxsQjyCTIdkiKG2pd6H8ntDcgsNnlqZokUiwp24AOk i9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724514743; x=1725119543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ts73yed3JhHDo+YK42L9Fku1808x980k6/11d2gW9QU=; b=lBdPmgF3OLBRY9RTst5HiT+VQrWgZrIe7b8QgVOEz07mTxLtRw31eA1d3u0sftngbY qUcP/jdd3yJ3B83Gpod7BI9ND9v935t7Gez6ZEeVhWAv+yiXW5TRsrbkm8LhMs0aCxae 3tKPVCgXfGmwJ7W7RkwJUd9r3uLuClD1VVs6KQmUHu1gEHa5KSAsAcuhGWbKiV+Ay/zR AgSu0ccsomRRDlOT5RCsglfcNLDp52iRcXK2CKr2N0xMVmkrLWNySRzwH4gbYjVIPSby FUvad9osdjCT+tx4uibjL8bI6L4pDuqhEDPeP9Cq3M8WRqPZdY8JiqsBvbgclOEGX9pM 5qiw== X-Forwarded-Encrypted: i=1; AJvYcCXBV2txHNT+abBHVIjDzWz+bGkHHsfcI7Logd0kUpmkItRGMvjlQZ2LzYHbcNzgilLopSc1KzM/zIRMTslGoJo1@lists.infradead.org X-Gm-Message-State: AOJu0YwfZ6ek4+8lqbI43mbRaWRiaz7QD2ngzVu4CcOFtrIqdug+Yy3Q QDSEOiNwGMehQj8wxMpf0kzgSzW9eiElmBN6UipaSJB40rwy4ibgERI5joyWCqs= X-Google-Smtp-Source: AGHT+IEnJZtV4Ze0E6JNWBH6viCIKhoMr/dfysrAhp34zkuHnlBsykCKThEEITNVtsIYdMlwRWMDdA== X-Received: by 2002:a05:6402:84a:b0:5bf:c8:774 with SMTP id 4fb4d7f45d1cf-5c08916a0c6mr4087470a12.15.1724514743513; Sat, 24 Aug 2024 08:52:23 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ca4d2sm3434336a12.36.2024.08.24.08.52.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 08:52:23 -0700 (PDT) Message-ID: <7c06dbdf-e76c-483f-9561-9aebf8811547@tuxon.dev> Date: Sat, 24 Aug 2024 18:52:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/12] nvmem: microchip-otpc: Fix swapped 'sleep' and 'timeout' parameters Content-Language: en-US To: Alexander Dahl Cc: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-3-ada@thorsis.com> From: claudiu beznea In-Reply-To: <20240821105943.230281-3-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_085225_564115_CABAC0E9 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.08.2024 13:59, Alexander Dahl wrote: > Makes no sense to have a timeout shorter than the sleep time, it would > run into timeout right after the first sleep already. > While at it, use a more specific macro instead of the generic one, which > does exactly the same, but needs less parameters. > > Signed-off-by: Alexander Dahl Please add a Fixes tag. > --- > drivers/nvmem/microchip-otpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index 03e60b99f2c9..bd3383eabdf6 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -87,8 +87,8 @@ static int mchp_otpc_prepare_read(struct mchp_otpc *otpc, > writel_relaxed(tmp, otpc->base + MCHP_OTPC_CR); > > /* Wait for packet to be transferred into temporary buffers. */ > - return read_poll_timeout(readl_relaxed, tmp, !(tmp & MCHP_OTPC_SR_READ), > - 10000, 2000, false, otpc->base + MCHP_OTPC_SR); > + return readl_relaxed_poll_timeout(otpc->base + MCHP_OTPC_SR, tmp, > + !(tmp & MCHP_OTPC_SR_READ), 2000, 10000); > } > > /*