From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A7FC3A5A2 for ; Tue, 3 Sep 2019 08:14:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2495622CF8 for ; Tue, 3 Sep 2019 08:14:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nYbKcMLN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pleDUQLd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2495622CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5CpiGlGKQWNqyookbkTfQqcR1CsyGO5jUw0+TTLfZJs=; b=nYbKcMLNODQSlicc/rPeh6t8C EC+SKZLRMjqAvbQdeSKEbNWkEs9nLxm1g+Vbo3FR5s0tewt42+BEZ9Yoq9UnLX4ElkvAScdI9eO28 GYDijemQfvU6RMxVeAlwgx8fjZd7LHWnpPjgMSzeKdDlMJq4Cnb3QW95mHgf3vzRLFBbMklqCNIU8 En8DFN7z0qlsGuY5MJJWZ2X+SFdT2IFIU/4VlkZF2rsi46+Kyacnbjlli6dRTl0YXv8u3C4WK+4lc r3i3Fc2AjQZ4Peaex2J30hTnJ71b3tvL+Zh/aqxzsosNSaScmduAVcElcn8Uu8eEZ7dr3xM172aae 6QSrYZHXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i53xP-0000ZQ-Fl; Tue, 03 Sep 2019 08:14:31 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i53xM-0000Z7-6o for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 08:14:29 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x838ENdC065609; Tue, 3 Sep 2019 03:14:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1567498463; bh=sH7OXIfVbmynYl8JstWq7QvQsliKlzK9lycCODoHIm0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pleDUQLd+kWHZHKqaX73LsWtA+FGHiuHS6RsyS4WpWG0wch3pp3PwlYYjG9X5k086 fVyP0MgDet973l3/vz2/KA5tXw/Qb0Aks8OMZqNEaz90+vQkIb+Ljoi39gczF3lUuS z2A0LANiH8YhQxtlA31KJXRLe3WGwKcKsBmmAtxo= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x838EN7e052004 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Sep 2019 03:14:23 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 3 Sep 2019 03:14:22 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Sep 2019 03:14:22 -0500 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x838EKuv036647; Tue, 3 Sep 2019 03:14:20 -0500 Subject: Re: [PATCHv3 01/10] dt-bindings: omap: add new binding for PRM instances To: Rob Herring References: <20190830121816.30034-1-t-kristo@ti.com> <20190830121816.30034-2-t-kristo@ti.com> <20190902042631.GA22055@bogus> From: Tero Kristo Message-ID: <7c2c8a4d-d24e-ceec-afc1-04cdc4d5d952@ti.com> Date: Tue, 3 Sep 2019 11:14:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_011428_338595_F15F4A20 X-CRM114-Status: GOOD ( 21.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tony Lindgren , Philipp Zabel , Santosh Shilimkar , linux-omap , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/09/2019 11:10, Rob Herring wrote: > On Tue, Sep 3, 2019 at 8:26 AM Tero Kristo wrote: >> >> On 02/09/2019 16:39, Rob Herring wrote: >>> On Fri, Aug 30, 2019 at 03:18:07PM +0300, Tero Kristo wrote: >>>> Add new binding for OMAP PRM (Power and Reset Manager) instances. Each >>>> of these will act as a power domain controller and potentially as a reset >>>> provider. >>>> >>> >>> Converting this to schema would be nice. >> >> Do you have documentation about schema somewhere? Basically what I need >> to do to fix this. > > Documentation/devicetree/writing-schema.md (.rst in -next) > Documentation/devicetree/bindings/example-schema.yaml > >>>> Signed-off-by: Tero Kristo >>>> --- >>>> .../devicetree/bindings/arm/omap/prm-inst.txt | 31 +++++++++++++++++++ >>> >>> bindings/reset/ >> >> I did not put this under reset, because this is basically a >> multi-purpose function. Reset just happens to be the first functionality >> it is going to provide. It will be followed by power domain support >> later on. >> >> Any thoughts? > > I prefer that bindings be complete as possible even if driver support > is not there yet. Adding power domain support may only mean adding > '#power-domain-cells'. > > The location is fine then. Yeah, I assume just adding power-domain-cells should be enough. I am not too sure before I start trying this out though so did not want to add it yet. > >>>> 1 file changed, 31 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/arm/omap/prm-inst.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt >>>> new file mode 100644 >>>> index 000000000000..7c7527c37734 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt >>>> @@ -0,0 +1,31 @@ >>>> +OMAP PRM instance bindings >>>> + >>>> +Power and Reset Manager is an IP block on OMAP family of devices which >>>> +handle the power domains and their current state, and provide reset >>>> +handling for the domains and/or separate IP blocks under the power domain >>>> +hierarchy. >>>> + >>>> +Required properties: >>>> +- compatible: Must be one of: >>>> + "ti,am3-prm-inst" >>>> + "ti,am4-prm-inst" >>>> + "ti,omap4-prm-inst" >>>> + "ti,omap5-prm-inst" >>>> + "ti,dra7-prm-inst" >>> >>> '-inst' seems a bit redundant. >> >> ti,xyz-prm is already reserved by the parent node of all these. >> >> The hierarchy is basically like this (omap4 as example): >> >> prm: prm@4a306000 { >> compatible = "ti,omap4-prm"; >> ... >> >> prm_dsp: prm@400 { >> compatible = "ti,omap4-prm-inst"; >> ... >> }; >> >> prm_device: prm@1b00 { >> compatible = "ti,omap4-prm-inst"; >> ... >> }; >> >> ... >> }; > > Okay. Then you need to state this binding must be a child of PRM. The > schema would need to take this into account too, so probably best to > not convert this yet. > Ok thanks, I'll make the necessary updates and post v4. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel