From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Hongliang Yang (杨宏亮)" <hongliang.yang@cixtech.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Peter Chen" <peter.chen@kernel.org>,
"Pawel Laszczak" <pawell@cadence.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Gary Yang (杨新伟)" <Gary.Yang@cixtech.com>,
"Fugang Duan (段富刚)" <fugang.duan@cixtech.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: [PATCH v5 3/3] arm64: dts: cix: Add USB4/USB5 nodes for Sky1
Date: Wed, 4 Nov 2026 08:46:11 +0100 [thread overview]
Message-ID: <7c35c198-5202-4e02-a23f-7a86415a5bcf@kernel.org> (raw)
In-Reply-To: <20261103074929.1971195-4-hongliang.yang@cixtech.com>
On 03/11/2026 08:49, Hongliang Yang (杨宏亮) wrote:
> Add USB4 and USB5 controller nodes for the CIX Sky1 SoC. Enable USB4
> and USB5 in host mode on the Radxa Orion O6 board.
>
> The two controllers share the RCSU register region and their glue
> registers are interleaved inside it, so the region is described by a
> simple-bus container with an address-translating ranges property and
> each controller maps its registers as offsets inside that region.
>
> Signed-off-by: Hongliang Yang <hongliang.yang@cixtech.com>
> ---
> v4 -> v5:
> - Fixed continuation line indentation reported by checkpatch.
> arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 42 ++++++++++
> arch/arm64/boot/dts/cix/sky1.dtsi | 95 +++++++++++++++++++++++
> 2 files changed, 137 insertions(+)
>
No improvements, since v2. You never responded to feedback, never asked
for clarifications, just ignored it. At v4 I tried to explain it more,
you did not respond.
NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-04 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 7:49 [PATCH v5 0/3] usb: cdns3: Add CIX Sky1 USBSSP controller support Hongliang Yang (杨宏亮)
2026-11-03 7:49 ` [PATCH v5 1/3] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang (杨宏亮)
2026-11-04 7:50 ` Krzysztof Kozlowski
2026-11-03 7:49 ` [PATCH v5 3/3] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang (杨宏亮)
2026-11-04 7:46 ` Krzysztof Kozlowski [this message]
2026-11-03 7:49 ` [PATCH v5 2/3] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang (杨宏亮)
2026-11-03 8:43 ` Philipp Zabel
2026-11-04 7:54 ` Krzysztof Kozlowski
2026-11-04 7:44 ` [PATCH v5 0/3] usb: cdns3: Add CIX Sky1 USBSSP controller support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c35c198-5202-4e02-a23f-7a86415a5bcf@kernel.org \
--to=krzk@kernel.org \
--cc=Gary.Yang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=hongliang.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox