From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE74EC4167B for ; Mon, 11 Dec 2023 17:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a85eNgotCrIMjniY+8yOuH+/u1FUuN6hrOPVUrmPcZg=; b=hOCcRcJBdCebaC UMhD/aaC0LhxW3T76L6DvGi81TeiWVpJadTYlo4CE7nek/LQswn2mtDxip9juggTYF/072DikWibB zxgFmj5T3eMegExYjht3eva/6NkP2onf6qpdHpIPANCBMBxozEWVE8kB7as2b5NqfbI0GXdt2CL+o D7+vZRhKOoIh2xqC6GGrSpU8ZX4ftOm/2Wh1mWXFxz+hQrVu0zO5zdCCchJHyooCCjAIyInhPZ6c2 2iex3i71nf5UXWGinL3h7/joBrlQ0mPW5n/qk6T/7yovKCan6Dl0MKWN3sqqLuu6nRApiKeoS+kWt ItPQEsUbafhqUkm/rkAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCju2-006D5H-2f; Mon, 11 Dec 2023 17:17:10 +0000 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCjtz-006D1w-2a for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 17:17:09 +0000 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3b9fd7b14cdso843007b6e.0 for ; Mon, 11 Dec 2023 09:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1702315026; x=1702919826; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZpS7YigJlvbtafE8s+IgfD2mhqkpNW2HnzWlJXZ6u0Q=; b=TXyMU5mnyxLiFdXp5Iej6usAtb3uJEC97cdFTACD3jlAThjrPlYHMYYnygE/UBFX96 xx8boMUBQBZeds1g6SqoAm98JAZLkjuxquy1kP+cgHkACpdDKk6SlH1JBPwyWKFlsdNV 8OqeeF+tuIZKdZYsjphTd6FobujYafOeL6c4YWlTDxL7ZDplcU69jlYpf1okb/pisJyL dynl2coQFfY+wc9RQLFDcX8VDWhDllzrRGYnxdaYJmkLnjRRGf+FN9eZU7mhVRu1sOM/ 6ktHrIEcKSdYdgWKOBBuOu5AKFDApZhL7A2vvl/QLLtODN6HKHvk+5KLD+FIGXmdUxoD cO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702315026; x=1702919826; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZpS7YigJlvbtafE8s+IgfD2mhqkpNW2HnzWlJXZ6u0Q=; b=sPUnbotRmrQzHSs5v0Gw2SE/T0yKGxUkxJxu09g+08AvMNmdGTgO0VNlTJZAtYpxUM xxR3TglFLBI/dNH0f/5Xz8KCjPfGEBf1RJ1/0l3eqfRE1SfTVEgVPT4uN7SrIKkG3BV5 wtZv2t++CuVXy6QT0ySuMYdO2o7PLs4otCgdY6HDMpbvTs8984Js9y6Nh7vxvdH6umix Fb66OVmcq+qW/r/5TVlbmooErRbim+PS7dV9eCyYTh8j7d+c9tL1PD++g4RzBlUzHUfT ysOZsO/eYjck3yRngrfbVFBNKy+2Kstxqg+j7FVOaJueFbHOaCZnqs5BM7UjzS6Y7iwN Z4XA== X-Gm-Message-State: AOJu0Yz12268U76Ydp7hQAqxAfYHrfI6jzlE2OCVS4z0gKV+5iIucO4d bLnhZPOeXZshyPF4CiflxQe2ClXLWIEt5F/2P9sT3A== X-Google-Smtp-Source: AGHT+IEC8jdvAnetFbqJVF6lQQw8UXKnB/IQiMsN2t2NyqglmpS9Xy9aZsTAJAYPyNV0NsZe4DU6SA== X-Received: by 2002:a05:620a:15a8:b0:77d:855d:1b09 with SMTP id f8-20020a05620a15a800b0077d855d1b09mr6457241qkk.0.1702311148452; Mon, 11 Dec 2023 08:12:28 -0800 (PST) Received: from ?IPV6:2600:1700:2000:b002:f8a3:26ec:ac85:392e? ([2600:1700:2000:b002:f8a3:26ec:ac85:392e]) by smtp.gmail.com with ESMTPSA id a15-20020a05620a066f00b0077d78afc513sm3014865qkh.110.2023.12.11.08.12.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 08:12:28 -0800 (PST) Message-ID: <7c40dfe8-f245-413f-a424-bde52ce21b6a@sifive.com> Date: Mon, 11 Dec 2023 10:12:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/12] lib/raid6: Use CC_FLAGS_FPU for NEON CFLAGS Content-Language: en-US To: Christoph Hellwig Cc: linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-arch@vger.kernel.org References: <20231208055501.2916202-1-samuel.holland@sifive.com> <20231208055501.2916202-6-samuel.holland@sifive.com> From: Samuel Holland In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_091707_842317_311F77F1 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-12-11 10:07 AM, Christoph Hellwig wrote: >> +CFLAGS_REMOVE_neon1.o += $(CC_FLAGS_NO_FPU) >> +CFLAGS_REMOVE_neon2.o += $(CC_FLAGS_NO_FPU) >> +CFLAGS_REMOVE_neon4.o += $(CC_FLAGS_NO_FPU) >> +CFLAGS_REMOVE_neon8.o += $(CC_FLAGS_NO_FPU) > > Btw, do we even really need the extra variables for compiler flags > to remove? Don't gcc/clang options work so that if you add a > no-prefixed version of the option later it transparently gets removed? Unfortunately, not all of the relevant options can be no-prefixed: $ cat float.c int main(void) { volatile float f = 123.456; return f / 10; } $ aarch64-linux-musl-gcc float.c $ aarch64-linux-musl-gcc -mgeneral-regs-only float.c float.c: In function 'main': float.c:1:33: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types 1 | int main(void) { volatile float f = 123.456; return f / 10; } | ^ float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types 1 | int main(void) { volatile float f = 123.456; return f / 10; } | ~~^~~~ float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types float.c:1:55: error: '-mgeneral-regs-only' is incompatible with the use of floating-point types $ aarch64-linux-musl-gcc -mgeneral-regs-only -mno-general-regs-only float.c aarch64-linux-musl-gcc: error: unrecognized command-line option '-mno-general-regs-only'; did you mean '-mgeneral-regs-only'? $ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel