From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E488EC10F15 for ; Wed, 24 Apr 2024 13:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Q3WGb3GpO2lIj8TUCldtU9JD2mtwsQ/rOwkWfB188I=; b=MwpmMxkKdANN4q UsJjClZC4FlnB9V7dVgc2Ixo/l5P4ctSTG85R+FMYrl4VavbY5muzgCRffOxX0Z9spbYbxByal4DD 6ZhSEeWbzktuIe0cWM3ekW7WYVtEh6Qub/cc8uhBcfO6/cZLqHc3iuAXkA/WFfy9Hg7DTt9VJmo7E 3d//qDiOUw8+JG1/BX6rwwlzsJDQQVms/Tbwpi6OyhFprctSUUU5Cn7sNG5DePKf+e9tlIrNnfFdG 2ewdj/wgUQE8e9xJyCKjy221+ZCXqqnu9Ai3Gqd38IXvNpPZzdSPPEHmH10Cd0Vut0N1mHyNZp8cf rByeVHlWALPlfytRw2QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzcfC-00000004FfG-1zF8; Wed, 24 Apr 2024 13:27:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzcf7-00000004Fd9-2iLL for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 13:27:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 190582F; Wed, 24 Apr 2024 06:28:13 -0700 (PDT) Received: from [10.57.86.198] (unknown [10.57.86.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCF6A3F64C; Wed, 24 Apr 2024 06:27:42 -0700 (PDT) Message-ID: <7c6504dd-ebef-4809-9e1d-7151db647e2a@arm.com> Date: Wed, 24 Apr 2024 14:27:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/14] virt: arm-cca-guest: TSM_REPORT support for realms Content-Language: en-GB To: Thomas Fossati , Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Sami Mujawar , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni References: <20240412084056.1733704-1-steven.price@arm.com> <20240412084213.1733764-1-steven.price@arm.com> <20240412084213.1733764-15-steven.price@arm.com> From: Suzuki K Poulose In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_062749_907557_7581D54A X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/04/2024 14:06, Thomas Fossati wrote: > Hi Steven, Sami, > > On Fri, 12 Apr 2024 at 10:47, Steven Price wrote: >> +/** >> + * arm_cca_report_new - Generate a new attestation token. >> + * >> + * @report: pointer to the TSM report context information. >> + * @data: pointer to the context specific data for this module. >> + * >> + * Initialise the attestation token generation using the challenge data >> + * passed in the TSM decriptor. > > Here, it'd be good to document two interesting facts about challenge data: > 1. It must be at least 32 bytes, and > 2. If its size is less than 64 bytes, it will be zero-padded. Agreed ! Suzuki > > cheers! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel