From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFC71EB64D9 for ; Tue, 27 Jun 2023 12:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s+CicMGC+7+l0iyB2IuXvK1FFYsdH9mWcv3I0pq+VcI=; b=YE3/3+r+t8V0ir JkOLHJ8rOt+ikvxg53gbU0OFXvGuAjMsFZ7F2JHNLJODHevhrgMj8ntoKgrmBjnxeNXgrCLWrhMgh E4mLTG71hmtYAj8KtMw5w0pWmy3JEPolZDdLrunG+VLOpAZ7s5MCbYnF1N/bPV7EY8jIlCjtLIk8W LERS4ZMNMUMXxxS1Uu4tbawQU/D4/uUhA84PxjhqNL4MgH8OsHZRNe6r4zubi37o1q/fOurIP5RzT gd/0Ks2LyCFY2LK5DcN5vteZMg5V1QpctISujgf92Gd8LcQmPUlm6WvatHyo4NK7Y9Er/cloxoCS1 1dje7u5z/lU4MyhRAMug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE7VI-00D838-0A; Tue, 27 Jun 2023 12:09:04 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qE7VF-00D82T-2P for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 12:09:03 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-312824aa384so3923864f8f.1 for ; Tue, 27 Jun 2023 05:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687867739; x=1690459739; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XjTuTNgKEBvunVd9fAUm7Ppy6mfbSYWQcxqzB1Eo12w=; b=jMET+zhwnS5q6F2CeWL/ZvUUXDxRCD3KIZroZ3mxJHNSTe+pVHeJRDOfbPh/630Aot LOUAHMqjtu3E4Fh2Yoo/r8tatlVx6RP9Waczk9zetDUKGYgMybsikZfJXk8RtbHcaTVS OrpAQ/hULa697u9j25R98sPaSRghRYBcpag4DKF7O5A+4f5g7K4+2eeFvSyZjEWJMcHy cEwewaTPhh4epk8JRB70mg4CTANx+XtlF8iZ4lvBht/Fdo7ToGIeRIJCfgHwo8EKNvg4 RAScDKlNtoCmNueMswgykjbNZUBOOYFfWhrqaheSCJAwebY2PpxoBaJX1eZoqBVJ0KeV 8V5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687867739; x=1690459739; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XjTuTNgKEBvunVd9fAUm7Ppy6mfbSYWQcxqzB1Eo12w=; b=h0dR+4TSJ9xXo1+4wP46skD+mbyL0PL2Mqw2d3m+xNaGH0rNv4PJYm6DNpIUofBMZU AXKX8+NIJ2ugEsKHkJjhVZVjTyKVuQzy6Fygd124wdtmzRW1EiFEonEOgLqheiN6wFvn XAcAbi/Yc4k0E59Ktp8/ErM0MFYdWKQyv2/KWQDijAodgCpZis1pl3jeL7n8Dc7nzBUl K5bTV2wJfkOVKySFIhXuxMDBVlVKfFRilmZESha5KlSS7mUQYNy9tC3O/NNR20ZPi6xb 3jLvrpzUObNZIqJwfjS3N4YmPugefx6wSIQullj9x2aXjRFtPCzrHronI7my9fuEstNc 0igA== X-Gm-Message-State: AC+VfDy9/7MDNSMGZupZnFeqrn6UQvFl6kjL+0jXpyKxvUnarZwwwd5A ImZVLZwr+PT3oFmqs15W2ifNjA== X-Google-Smtp-Source: ACHHUZ4pCkteu52b9BlAo/HYL/OWS4u9cyn26HsksoVqBbTka5mDErRReBs9tDBbMMGxmHreePz3xg== X-Received: by 2002:a05:6000:118f:b0:309:4620:e155 with SMTP id g15-20020a056000118f00b003094620e155mr10664973wrx.49.1687867739301; Tue, 27 Jun 2023 05:08:59 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v10-20020a5d590a000000b0030631a599a0sm10218526wrd.24.2023.06.27.05.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 05:08:56 -0700 (PDT) Date: Tue, 27 Jun 2023 15:08:53 +0300 From: Dan Carpenter To: Andi Shyti Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] i2c: sun6i-p2wi: Fix an error message in probe() Message-ID: <7c6db53c-427d-4ba5-80b7-a069ab9322a0@kadam.mountain> References: <98afbc28-3366-459e-bd01-f77cf1a67fe9@moroto.mountain> <20230627115920.c4ms65vgrbiyekc6@intel.intel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230627115920.c4ms65vgrbiyekc6@intel.intel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_050901_803183_72CF93D9 X-CRM114-Status: GOOD ( 24.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 27, 2023 at 01:59:20PM +0200, Andi Shyti wrote: > Hi Dan, > > On Tue, Jun 27, 2023 at 10:12:36AM +0300, Dan Carpenter wrote: > > The "ret" variable is uninitialized. It was the "p2wi->rstc" variable > > that was intended. We can also use the %pe string format to print the > > error code name instead of just the number. > > > > Fixes: 75ff8a340a81 ("i2c: sun6i-p2wi: Use devm_clk_get_enabled()") > > Signed-off-by: Dan Carpenter > > --- > > drivers/i2c/busses/i2c-sun6i-p2wi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c > > index ad8270cdbd3e..fa6020dced59 100644 > > --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c > > +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c > > @@ -250,7 +250,8 @@ static int p2wi_probe(struct platform_device *pdev) > > > > p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL); > > if (IS_ERR(p2wi->rstc)) { > > - dev_err(dev, "failed to retrieve reset controller: %d\n", ret); > > + dev_err(dev, "failed to retrieve reset controller: %pe\n", > > + p2wi->rstc); > > Yes, good catch! Thanks! But I think we want to print the error > value here, so I think it should be: > > - dev_err(dev, "failed to retrieve reset controller: %d\n", ret); > + dev_err(dev, "failed to retrieve reset controller: %d\n", > + PTR_ERR(p2wi->rstc)); > The %pe which I changed it to is a cool new thing that prints: failed to retrieve reset controller: -EINVAL\n We should create a similar %e printk format that works for ints instead of error pointers. But instead of that you have people who cast error codes to pointers just to get the %pe functionality. And other people who make suggestions (this is the catagory that I'm in) but are too lazy to do the actual work. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel