From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05F1EE7AD74 for ; Tue, 3 Oct 2023 16:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VomCsl+LSa3O35zY0cqFUgzYSLOC1onWy2kTn+R6NsU=; b=3veMRFIhxVMbwi MyBJ0dpgdr1oq+zlHdFrIW8SiqlikcAYsPT/IWFritIt6+MzuTYcpYyiCnOD/PyUfgQff6JW+k1KS P7i6RlTajtFLbcdaM8B61mDkm9DwKSoVXd4Lw/QsJPeknNlzXVsYA+xwNnAnOSrMIb3s/WJi2Qxco C3RkFu9dKmFdk4HfU1DfdbeXuJIDJ0ZzGt+HPMgTGkJNcRJgLuyWZJSrYBVxcHciaZnT3DAO6AOC4 G37KQLwLAR7StSKR/FDSl3ssCiLEx+MucyoHVga/J4pqVn92VOI4mfvh/ukOA0u4fIey7fBKktVMb GG8VSgiS7V7Xy64VOm2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnhoV-00EvCI-0o; Tue, 03 Oct 2023 15:59:59 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnhoR-00EvAh-2I for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 15:59:58 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393Dtihq014212; Tue, 3 Oct 2023 15:59:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ADaA/9nF9XWLSlIH/V1+7qMot+xDTDjD4TBk10pSGI0=; b=DWL+1lhiby6lsHUzhFN+3eiWLLkHmFPnxn1CZYV/hkpFAGYQg33qauXpj3c0CczXqc8i Sy+771zoE6r9oF5jQEWtsIgHQhDgJ2sBcV9MMt8M6kKhsNf2QkSWo5ErbIBbIW3bPeD3 pF49BtILMs63wJnmcemMy7niXpYGqNasPjXhQWxqB3siJ6QsBi9Ebh5TOcNk3GapMrGS p71xpK7QktDhi1SVfGkNDFzyfeFxmifoNVTgb77vzICZKXi3evPct0UHA1tzcD/JGIQb LR1oUbCsgbhqUGiHwB1Ix5OskmPHPY4jdnu/qBV3MfuJd0XWXiy4JxQEm6TDtcv0bfYX vw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tg98rhsbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Oct 2023 15:59:47 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 393FxkvX000946 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Oct 2023 15:59:46 GMT Received: from [10.110.20.163] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 3 Oct 2023 08:59:45 -0700 Message-ID: <7c871b23-5544-6604-257d-f0c8fd5afd06@quicinc.com> Date: Tue, 3 Oct 2023 08:59:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 3/4] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Content-Language: en-US To: Sudeep Holla CC: , , , , , , , , , References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-4-quic_nkela@quicinc.com> <20231003104404.o7yxg3y7dn7uhrq4@bogus> From: Nikunj Kela In-Reply-To: <20231003104404.o7yxg3y7dn7uhrq4@bogus> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: LCfrz6QFLV8u2SOKqyuHcQWBXIMu85DO X-Proofpoint-GUID: LCfrz6QFLV8u2SOKqyuHcQWBXIMu85DO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-03_12,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310030119 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_085955_756672_FC2B5F84 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/3/2023 3:44 AM, Sudeep Holla wrote: > On Mon, Sep 11, 2023 at 12:43:58PM -0700, Nikunj Kela wrote: >> Introduce compatible "qcom,scmi-hvc-shmem" for SCMI smc/hvc >> transport channel for Qualcomm virtual platforms. >> The compatible mandates a shared memory channel. >> >> Signed-off-by: Nikunj Kela >> Acked-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/firmware/arm,scmi.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> index 8d54ea768d38..4090240f45b1 100644 >> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> @@ -45,6 +45,9 @@ properties: >> - description: SCMI compliant firmware with OP-TEE transport >> items: >> - const: linaro,scmi-optee >> + - description: SCMI compliant firmware with Qualcomm hvc/shmem transport >> + items: >> + - const: qcom,scmi-hvc-shmem > Can it be simply "qcom,scmi-smc" for 2 reasons ? > 1. We don't support SMC/HVC without shmem, so what is your argument to add > '-shmem' in the compatible here ? In our platforms, there are multiple ways to allocate memory. One is preallocated shmem as used here, another is dynamically by hypervisor APIs. shmem was to just to indicate it is preallocated. > 2. The exact conduit(SMC/HVC) used is detected runtime, so I prefer to keep > '-smc' instead of '-hvc' in the compatible just to avoid giving an illusion > that HVC is the conduit chosen here based on the compatible. It can be true > for other reason but I don't want to mislead here by using HVC. IUUC, currently, conduit comes from PSCI dt node. We have been using smc for PSCI but want to use hvc here. That being said, I am fine to explore if we can change PSCI to use hvc too. >> interrupts: >> description: >> @@ -320,6 +323,15 @@ allOf: >> required: >> - linaro,optee-channel-id >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,scmi-hvc-shmem >> + then: >> + required: >> + - shmem >> + >> examples: >> - | >> firmware { >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel