From: <Claudiu.Beznea@microchip.com>
To: <ye.xingchen@zte.com.cn>, <lee@kernel.org>
Cc: alexandre.belloni@bootlin.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()
Date: Wed, 8 Feb 2023 09:49:33 +0000 [thread overview]
Message-ID: <7c9af50a-f4b1-ed1a-5655-cc20fd880bf1@microchip.com> (raw)
In-Reply-To: <202302081731593374472@zte.com.cn>
On 08.02.2023 11:31, ye.xingchen@zte.com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/mfd/atmel-flexcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 33caa4fba6af..b52f7ffdad35 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -37,7 +37,6 @@ struct atmel_flexcom {
> static int atmel_flexcom_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> - struct resource *res;
> struct atmel_flexcom *ddata;
> int err;
>
> @@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
> ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddata->base = devm_ioremap_resource(&pdev->dev, res);
> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(ddata->base))
> return PTR_ERR(ddata->base);
>
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-08 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:31 [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-08 9:49 ` Claudiu.Beznea [this message]
2023-03-03 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9af50a-f4b1-ed1a-5655-cc20fd880bf1@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).