From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7C7C433E0 for ; Wed, 22 Jul 2020 11:40:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEA820729 for ; Wed, 22 Jul 2020 11:40:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1DQ8IP9D"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="vPN1qb5t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="DXCUBuqt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BEA820729 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O2gnVUHSUyn6qx8e+f++3sVLXXivx4tqlFepLVTdYkQ=; b=1DQ8IP9DPbJDmBiZ1/dnBeX3o Hw3eAesuI/aAVSdGjyBkULaSe7cKPR21Z+Z6mm2N04R3/qaLzCFhL4+U0tT/WnXL4VdMJoztmQ5Cp hbX0ewh8gPQK7n4G65vnm3GKjJ1IS59ypdIVINoivQWAzaPSNx8zZCy4Gxah/WID4sr2ibGR5KO4A tCaR2Ikx4eaYsNVl1r564YR1C0JtirAzogeCFIcoU4chI2emSfigQtrchRMDS4TzNmmfFQo82nwJC cmW7yMIEyhfzEaFm2MMBD13YsGdsW1wBmcmkXHBhvp/BtGpNj4OOf8zMMJo0E2/At/p1AcGTLDkL/ xkb1BJlsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyD5D-0001TR-5I; Wed, 22 Jul 2020 11:38:47 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyD5A-0001SV-55 for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 11:38:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595417923; x=1626953923; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=g8VPA+XPYOT0OIir5Y5qGh8SXdrjPCRWAUXiBcOUMJ4=; b=vPN1qb5twUXHQ9GclB1v+/6CdI0elOKLJSZkzWd2pq3GfI/+sCS1VbMG 1XL5NmziQkZ7UrQMV5Gst9NSDRxAID+ToynnhlQuNriWn8GmiPasdu3Fh NeybRKlJiW5KCG1eJShyDcpeEeZS93mRXKGu3QmtCDl7HTncpewJL/Pj2 rebeqNlfWivA8+Gq2JdHCx8Fl+jm8CzXh5Gdk8wztLSUKc8oj/UNb+/c1 uYX/0GPBpX7OjO2EyLhYMhesu/RaKQb33SZC5zk+lkY8WaI0uE1crCly8 QipUIKYPGtS9w5/eF+vZ1kozNT4ktAnZOIDtjfH7Vit8GaNfXhC8CUTSe A==; IronPort-SDR: IM/e2zjH4q8eOJt0Hipj4PAIIvR9hqxWP4iHXA7qqYtsAQOpc+xEfuYFfNq27TuYteXlTD+EGb FAHNsimc79BtvHifxDrCZu6SAlSOtHKiuFJfQkPhbz1g1+lVEZpPW1DqeQP/xv6xZPuTQdABMN 2ofUXf3J26B6O0XI0yfld8TnwDv5Xn5fgTiH8RQmDBtilqA3Ok94IFlqmaEulyjyn8ahxe5eaw F7Ow/YSb1WiQ+BtfZwPNRQggI1IadcycTYEtNklbeH+mFjDnZjStQQyj7n0+gzZZhE7eU11v7s 0B4= X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="20141114" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jul 2020 04:38:39 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 22 Jul 2020 04:38:39 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 22 Jul 2020 04:38:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9mNk6oPlEBqs0ruy8QqKSRse13LFUFM28IdOiwGNvd2hFVviwlvzAOtbGziqd87jv1E/uvz4re1mk7yo44tTiPaQwZlWjFEzSkmKek76W8qKIHH4+gYe0aJnHpg1kmp6x4+OcDEcteXjnwkti/kGkv+f8HRfmhwbWRDK6bTLEXPafThPCCidJA8tNuOxYx+3xnodeXlH9LVCPNv8+W6nql6iq81Tcp6kxicd8rMBbouM8L/jVjxWSU+kJX5zLdvCzI2Lab1GvIu1kLrYGMBulv98vVYZxmo0+xT4FFKhZTR/1HWNZCYftZFydA/WyrQpJPZN/jHrDmo31be1oyxLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8VPA+XPYOT0OIir5Y5qGh8SXdrjPCRWAUXiBcOUMJ4=; b=NXjwKeC0DFW+UEyQiQGx9yjGfWEpgi4wAR8innSK190Yn8VQcrqrB84dfDqRlMx9AJll/utm60JwkbKufIh2GOlhQ3XGkoZIylascoImGYhokHF8du/JczJNCx6CCihedz1Y342PiNGnR3pylZeaKOGfR6OVAnr+ZfqEJBkaSMLBk8kf4RQM5wzvxhT+4cH/JoirD7Vzt2n3CeRs6uOQL2TgHBnGFIuIL2uuxP6AFwt/i3h5qE0JV/TMqxJOO+pmvP6ej6xHt7lVUkwUjYWv2AGZ/SIS0dTU4ErgYENyB4vqZAS0Vpm+7Mmfvw7+Hx/Zi/E8SJSGh5U3CiwJW8W0AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8VPA+XPYOT0OIir5Y5qGh8SXdrjPCRWAUXiBcOUMJ4=; b=DXCUBuqtQ7QocrdIsQ4zLiU3W/rJ+ynfuYBJ59gA9vX/AAUGUu4dOvRM574k0zyrSSorzB7PPAre05ZPs2ZDxesGYtjsxM8ztjaMxgaRbusvyk/qYHnHYz6F9iBnpc7oZQ7edsLQujKUEJYXT7Rup0YlXn4R2fBDItV6SpU+6gA= Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SA0PR11MB4576.namprd11.prod.outlook.com (2603:10b6:806:97::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Wed, 22 Jul 2020 11:38:38 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::851c:67fc:a034:9ea0%4]) with mapi id 15.20.3216.022; Wed, 22 Jul 2020 11:38:38 +0000 From: To: , , , , Subject: Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Topic: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Index: AQHWX4JuelDTpdq80UW3XJv+RJlkGakTZ76AgAASg4A= Date: Wed, 22 Jul 2020 11:38:37 +0000 Message-ID: <7cab13f6-ac54-8f5c-c1bf-35e6c3b5d9db@microchip.com> References: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com> <0ec99957-57e9-b384-425a-ccf0e877f1a1@microchip.com> In-Reply-To: <0ec99957-57e9-b384-425a-ccf0e877f1a1@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [84.232.220.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 587e9d88-0f44-4de0-5a06-08d82e33c678 x-ms-traffictypediagnostic: SA0PR11MB4576: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f8dh3381WDPQYN3VWnVSXFpcZ3C4z67fM9wbJJuPt7SaWzmSk1mhht5cCkNBUF/myHVeG98vAVS52v1cWJ0lugpsCr9cNVtgWtC203hHy4h2Xmg1wRlS2/tuuQnfMiPmlD/EDZF0p1Rg3JwDC6PvOgPc7dfkGgOc1cXx98ae/eerI2ZWJ/2/w68tazWSFc9bLz/FRB4lxVFZNj4igUDN0K+ShhPT0DoWbX+qucxB7UlkvMEofYrmRWJh1JfNMlXoDjsmD/iktySR/yCdcLWTzyu6dhSZ6Wt0ojGaF2PrbbfTQueOC9kqFggJ4fHh7lCeFyG70hgQq2bblatgAtv6JGoaE9+OKTFAegRbJU4eAUsbhLMN/KKYfTNKHxQ/rzMy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(366004)(39860400002)(376002)(346002)(136003)(107886003)(26005)(54906003)(31696002)(316002)(110136005)(2616005)(71200400001)(8936002)(7416002)(86362001)(2906002)(5660300002)(4326008)(66446008)(6486002)(66556008)(478600001)(36756003)(6512007)(8676002)(186003)(31686004)(76116006)(91956017)(66946007)(66476007)(6506007)(53546011)(83380400001)(64756008)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: WGfC8VP5m4kkJ6D2L4ADnLQA2mRFa4fX8kUR926ZDHiqqxuxvrnlmBEPPL+DAl7uZunSjEJqLf+Nml1iuzYCV42UQqzDFWTTdmZtS3QW6O0ns9PyS2xNpLRkBZOQgx5Nh/MPh0OmzgBOQaNsAxC8f25z6SK+ZS5UPQ+2C787Vybhf5cwE6p7C0pZ9/38vbwTtn0jKlRbzesAlOYQ2Yp4joiy68CfoTcLYNpRRBF8c0g6+CSbEoHPn+WfzFCb4ztjbCAHBVv+Zsx8HkLi39f7P3hNly28A9Wv3HnoZcwc8aj9SWRs+8qeTeFTQIhCBSOuaRrYALY7LXq6C8zb9aKQ4iKIdduuE2O/AdF6txTu75N6coKXVgaTsO1DrAAE7z1lT783gqOnrMSHEUwkZJ7C6ydWhMhxAmA8kSFrZThRGYm50RadTVQInTEjlZJf4KLWQwfeZi3/7OP2hvwedpK65u01NWZdtODuMd5oMdDM4Hstjkp7WjN0dT7ou+4qTcht Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 587e9d88-0f44-4de0-5a06-08d82e33c678 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 11:38:37.9112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ux/7vJU7D3l5aq18LGNbJxbySTOqKr3rhwgzJJBGMji+Rhsn9DpJ2RmjMy4AALmkoD8j2hRxVTNQztiDb0KP4n0cJsNEivRREEcIANlmVJM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4576 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_073844_345169_0C568C43 X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, kuba@kernel.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: > > > On 21.07.2020 20:13, Codrin Ciubotariu wrote: >> Adding the PHY nodes directly under the Ethernet node became deprecated, >> so the aim of this patch series is to make MACB use an MDIO node as >> container for MDIO devices. >> This patch series starts with a small patch to use the device-managed >> devm_mdiobus_alloc(). In the next two patches we update the bindings and >> adapt macb driver to parse the device-tree PHY nodes from under an MDIO >> node. The last patches add the MDIO node in the device-trees of sama5d2, >> sama5d3, samad4 and sam9x60 boards. >> > > Tested this series on sama5d2_xplained in the following scenarios: > > 1/ PHY bindings from patch 4/7: > mdio { > #address-cells = <1>; > #size-cells = <0>; > ethernet-phy@1 { > reg = <0x1>; > interrupt-parent = <&pioA>; > interrupts = ; > }; > > 2/ PHY bindings before this series: > ethernet-phy@1 { > reg = <0x1>; > interrupt-parent = <&pioA>; > interrupts = ; > }; > > 3/ No PHY bindings at all. > > All 3 cases went OK. > > You can add: > Tested-by: Claudiu Beznea > Acked-by: Claudiu Beznea Thank you very much Claudiu! There is still one more case in my mind. macb could be a fixed-link with an MDIO DSA switch. While the macb would have a fixed connection with a port from the DSA switch, the switch could be configured using macb's MDIO. The dt would be something like: macb { fixed-link { ... }; mdio { switch@0 { ... }; }; }; To support this, in patch 3/7 I should first check for the mdio node to return of_mdiobus_register() and then check if it's a fixed-link to return simple mdiobus_register(). I will address this in v3... Thanks and best regards, Codrin > > Thank you, > Claudiu Beznea > >> Changes in v2: >> - renamed patch 2/7 from "macb: bindings doc: use an MDIO node as a >> container for PHY nodes" to "dt-bindings: net: macb: use an MDIO >> node as a container for PHY nodes" >> - added back a newline removed by mistake in patch 3/7 >> >> Codrin Ciubotariu (7): >> net: macb: use device-managed devm_mdiobus_alloc() >> dt-bindings: net: macb: use an MDIO node as a container for PHY nodes >> net: macb: parse PHY nodes found under an MDIO node >> ARM: dts: at91: sama5d2: add an mdio sub-node to macb >> ARM: dts: at91: sama5d3: add an mdio sub-node to macb >> ARM: dts: at91: sama5d4: add an mdio sub-node to macb >> ARM: dts: at91: sam9x60: add an mdio sub-node to macb >> >> Documentation/devicetree/bindings/net/macb.txt | 15 ++++++++++++--- >> arch/arm/boot/dts/at91-sam9x60ek.dts | 8 ++++++-- >> arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 16 ++++++++++------ >> arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 17 ++++++++++------- >> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 13 ++++++++----- >> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 12 ++++++++---- >> arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 ++++++++++++---- >> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 12 ++++++++---- >> drivers/net/ethernet/cadence/macb_main.c | 18 ++++++++++++------ >> 9 files changed, 86 insertions(+), 41 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel