From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 146C5C74A5B for ; Sat, 18 Mar 2023 13:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GJUL/j+uBIPc8K319sLNjR53MSbS1UUNT87BB3LNWLw=; b=4BXa12MRiIQ5S2gMxoWJuWKhon irtghin4DtIi/zi2SFXgriQ9IkZb7BFKJrrM5ktWKvARiG48IcWbiFOr2rt2z8VomqAt0j6RQFlps Xh/VP4k7nxGjjQkX+yDR1KgB0aWi4kXI2fgMzPazOGiYCJYl8Kh4E+LJJkVK3yPFlp+bTD+Pq+quk 3njoBMCMQAHTnttqeU3sH2PwOtgXD3QhoVUUXodkt7sHkQL9gn+ddqi94c+RlNJx4pLkaN6DFSNoA EqO0GKVh68t3t2YzHkFG1d9sf5sOPDj1zULNXtKSwRDfTGdDLJYghopLMXX1rjVIP4OaetB3xRyxb Oh4GNStg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdW9q-004l2v-0K; Sat, 18 Mar 2023 12:59:38 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdW9n-004l2S-2U for linux-arm-kernel@lists.infradead.org; Sat, 18 Mar 2023 12:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679144373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8tqDexaW1R0cNP270wcvWDX3I0jhzNRDxhsGsGPr4AY=; b=UC2vfoDbMb+kmXhuXfVIWAN70KpuJXotZo20pPM7F00C3MKXRFrECEK4i+8EAV9/pGLorW YGKOR1bCqSyTfoEh5Zn9FxmL6q+RSk7yHojg3poASYHlMPGBJPKhIa0HKQT/OXN5s0jlBD 5gR7nFEmV/otEMvzKdnOGn4L53Ga6BM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-qTzotVWsOEy4eL-5CNE_sQ-1; Sat, 18 Mar 2023 08:59:32 -0400 X-MC-Unique: qTzotVWsOEy4eL-5CNE_sQ-1 Received: by mail-qv1-f72.google.com with SMTP id w2-20020a0cc242000000b00583d8e55181so4149504qvh.23 for ; Sat, 18 Mar 2023 05:59:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679144372; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tqDexaW1R0cNP270wcvWDX3I0jhzNRDxhsGsGPr4AY=; b=Y9PTP8MmDbOsrm9wn5hq7emspryCdf+jyQtvfTVHHnAL5lKY+GyP0ap6Qi2iI/pjWD YzPjEECI62e3VrZPXXpBtFFv8CDC8KZ2IYGG5zckpKg0ZRaNB93Tdr2CFpIs5Ikm0SL0 +6idYU7rA6dKxXv0r2cMx5BOseEIOqD5JY0KLLsoVdFUBuVSF5qblmhERnwBaZ3+A4lU j35VthJKoJQ241VHvxbcEwAznScxbaxa0ywyP4qFCE/8P3YHe22fVXWhBvXT4Uqpl2xo zv0ToaPHaWdw0UrhNH4to7C7BcVwx+ctlgDgun3eExeVoLKpfQnOWFpYyRKMMohKgtzY Kzjg== X-Gm-Message-State: AO0yUKU4FuJ5ticUzaKOQQ8TaYdRHyFrWl98Ne8sbdW/+moBeehukAQy 6H7LJ7JIpVTMAKhfl2JW51L04tYEhShGDfb6JuSRF2tersPeKH4ijBKN9iH7Vy3fUg+/tvSYkf3 jQYHoMPjmSolKZCxHvqKRXEZuyr6UPPIIsqc= X-Received: by 2002:a05:6214:f06:b0:56e:a96a:2bdc with SMTP id gw6-20020a0562140f0600b0056ea96a2bdcmr46423992qvb.40.1679144371749; Sat, 18 Mar 2023 05:59:31 -0700 (PDT) X-Google-Smtp-Source: AK7set8CTTnO50sIImmBipYldccpFr7gf2qDGHwyz89jzJjdzdbo+0Y13fj80VnaMoC6j8knqIms5Q== X-Received: by 2002:a05:6214:f06:b0:56e:a96a:2bdc with SMTP id gw6-20020a0562140f0600b0056ea96a2bdcmr46423962qvb.40.1679144371464; Sat, 18 Mar 2023 05:59:31 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id u23-20020a37ab17000000b0071f0d0aaef7sm97543qke.80.2023.03.18.05.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Mar 2023 05:59:31 -0700 (PDT) Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused xlnx_pr_decouple_read function To: Xu Yilun Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nathan@kernel.org, ndesaulniers@google.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230317230617.1673923-1-trix@redhat.com> From: Tom Rix Message-ID: <7cab9365-6493-2de0-bcef-cd46809056a8@redhat.com> Date: Sat, 18 Mar 2023 05:59:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_055935_887691_8E88C446 X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/18/23 2:59 AM, Xu Yilun wrote: > On 2023-03-17 at 19:06:17 -0400, Tom Rix wrote: >> clang with W=1 reports >> drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function] >> static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, >> ^ >> This static function is not used, so remove it. > I prefer to move the description as the first section. If you agree, I > could do it before apply. I have no preference, that is fine. Tom > > Acked-by: Xu Yilun > >> Signed-off-by: Tom Rix >> --- >> drivers/fpga/xilinx-pr-decoupler.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >> index 2d9c491f7be9..b6f18c07c752 100644 >> --- a/drivers/fpga/xilinx-pr-decoupler.c >> +++ b/drivers/fpga/xilinx-pr-decoupler.c >> @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, >> writel(val, d->io_base + offset); >> } >> >> -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, >> - u32 offset) >> -{ >> - return readl(d->io_base + offset); >> -} >> - >> static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) >> { >> int err; >> -- >> 2.27.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel