From: Michael Riesch <michael.riesch@wolfvision.net>
To: Jonas Karlman <jonas@kwiboo.se>, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
frattaroli.nicolas@gmail.com
Subject: Re: [PATCH] arm64: dts: rockchip: fix probe of analog sound card on rock-3a
Date: Mon, 16 Jan 2023 09:41:50 +0100 [thread overview]
Message-ID: <7caeb07b-8465-6bdd-d90d-06a905b56f37@wolfvision.net> (raw)
In-Reply-To: <20230115211553.445007-1-jonas@kwiboo.se>
Hi Jonas,
On 1/15/23 22:15, Jonas Karlman wrote:
> The following was observed on my Radxa ROCK 3 Model A board:
>
> rockchip-pinctrl pinctrl: pin gpio1-9 already requested by vcc-cam-regulator; cannot claim for fe410000.i2s
> ...
> platform rk809-sound: deferred probe pending
>
> Fix this by supplying a board specific pinctrl with the i2s1 pins used
> by pmic codec according to the schematic [1].
>
> [1] https://dl.radxa.com/rock3/docs/hw/3a/ROCK-3A-V1.3-SCH.pdf
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Makes sense to me, but...
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index 00d873a03cfe..a149c8b83f94 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -573,6 +573,8 @@ &i2s0_8ch {
> };
>
> &i2s1_8ch {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s1m0_sclktx &i2s1m0_lrcktx &i2s1m0_sdi0 &i2s1m0_sdo0>;
... shouldn't this include i2s1m0_mclk as well?
For some reason this has been omitted in the pinctrl defined in
rk356x.dtsi. But then rk356x.dtsi also claims
- both i2s1m0_sdo1 and i2s1m0_sdi3
- both i2s1m0_sdo2 and i2s1m0_sdi2
- both i2s1m0_sdo3 and i2s1m0_sdi1
which are mapped to the same respective pins. Therefore it seems that
there might be something wrong with this pinctrl altogether.
Cc: Nicolas Frattaroli, maybe he can provide some clarification.
Best regards,
Michael
> rockchip,trcm-sync-tx-only;
> status = "okay";
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-16 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 21:15 [PATCH] arm64: dts: rockchip: fix probe of analog sound card on rock-3a Jonas Karlman
2023-01-16 8:41 ` Michael Riesch [this message]
2023-01-16 9:29 ` Jonas Karlman
2023-01-16 15:23 ` Michael Riesch
2023-01-16 15:14 ` Nicolas Frattaroli
2023-01-16 15:22 ` Michael Riesch
2023-01-19 11:57 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7caeb07b-8465-6bdd-d90d-06a905b56f37@wolfvision.net \
--to=michael.riesch@wolfvision.net \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox