From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74601CA0EDC for ; Thu, 14 Aug 2025 21:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cSEixDLE7xsPsFz7NBwxP7uK65MZGZKF8ZUmhrV1huw=; b=FBV5lT4MgkIFEBOYfIyx/vIp94 4a+GZANFjy5lFi7virvLYr3qmgske5DbKqBvywfDrMysyQhoHfbYomkiGi4g2c/dTPulaa3z0H2vD KmcPSoYuki3+m1l+seGYjecPZXqMuacJI7R8wfc/fCql/5fA3/Md9U6EU0oJ/MuNv7kbFd0oewsZS dYEQ2flk3x2owOay46n/CElBkwKZ7WL0RtfwfEDDnZKSvaJDDmOMi/QZ7XSz0erXtrwTw+gf0wv/K 5IYtAFedv4iDYdbCyOR9HppzcDeB290YGPCKHJOes7x9ZqJMr8PlQW2mfCej+Hj69wB6+1j/3KRAS EaPmcmZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umfPS-00000000aOm-3rO4; Thu, 14 Aug 2025 21:22:55 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umfJt-00000000Zm7-3Gv7 for linux-arm-kernel@lists.infradead.org; Thu, 14 Aug 2025 21:17:13 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250814211704euoutp024954c90a6d78c19103c5da0ab2f75889~bvsMMdn1P0772107721euoutp02B for ; Thu, 14 Aug 2025 21:17:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250814211704euoutp024954c90a6d78c19103c5da0ab2f75889~bvsMMdn1P0772107721euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1755206224; bh=cSEixDLE7xsPsFz7NBwxP7uK65MZGZKF8ZUmhrV1huw=; h=Date:Subject:From:To:Cc:In-Reply-To:References:From; b=aif0DMJNDGGyAVppTHMk6Yf+pUZiOWU0ER6evHyGiNIC4x5MUx2Uk4BrgOCHG32br v0vqia2Zf89eZKmw901sVlL+ul/Lzc6Y3ALfe83DhoHRPHhcp/U1Zx/XW7ya5K/4HA EyAA1M0g09bPOExExj4/J1IFPfi27LIby9z7wyEY= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250814211703eucas1p253cb95d05d46ff9f84c21d549f0f0098~bvsK_rr3M1788217882eucas1p2V; Thu, 14 Aug 2025 21:17:03 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250814211700eusmtip10f43f1f50846dd52289fb97bdd649f18~bvsIPXpgd2313023130eusmtip1d; Thu, 14 Aug 2025 21:17:00 +0000 (GMT) Message-ID: <7cb50c9c-ac41-43b6-8c69-5f184e7c94cf@samsung.com> Date: Thu, 14 Aug 2025 23:16:59 +0200 MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH v4 00/13] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver From: Marek Szyprowski To: Damon Ding , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com, l.stach@pengutronix.de, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Content-Language: en-US In-Reply-To: Content-Transfer-Encoding: 8bit X-CMS-MailID: 20250814211703eucas1p253cb95d05d46ff9f84c21d549f0f0098 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250814104818eucas1p2c5029f6d5997f4fafd6370f9e7fb2264 X-EPHeader: CA X-CMS-RootMailID: 20250814104818eucas1p2c5029f6d5997f4fafd6370f9e7fb2264 References: <20250814104753.195255-1-damon.ding@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250814_141710_408527_6A13BA1A X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14.08.2025 16:33, Marek Szyprowski wrote: > On 14.08.2025 12:47, Damon Ding wrote: >> PATCH 1 is a small format optimization for struct analogid_dp_device. >> PATCH 2 is to perform mode setting in &drm_bridge_funcs.atomic_enable. >> PATCH 3-6 are preparations for apply drm_bridge_connector helper. >> PATCH 7 is to apply the drm_bridge_connector helper. >> PATCH 8-10 are to move the panel/bridge parsing to the Analogix side. >> PATCH 11-12 are preparations for apply panel_bridge helper. >> PATCH 13 is to apply the panel_bridge helper. > > This series lacks 'select DRM_BRIDGE_CONNECTOR' in ExynosDP's Kconfig, > so it causes build break: > > drivers/gpu/drm/exynos/exynos_dp.c:177: undefined reference to > `drm_bridge_connector_init' > make[2]: *** [scripts/Makefile.vmlinux:91: vmlinux] Error 1 > > After adding this dependency, the Exynos DP driver stops working. On > Samsung Snow Chromebook I observed following issue: > > [    4.534220] exynos-dp 145b0000.dp-controller: failed to attach > following panel or bridge (-16) > [    4.543428] exynos-drm exynos-drm: failed to bind > 145b0000.dp-controller (ops exynos_dp_ops): -16 > [    4.551775] exynos-drm exynos-drm: adev bind failed: -16 > [    4.556559] exynos-dp 145b0000.dp-controller: probe with driver > exynos-dp failed with error -16 > > I will investigate details later in the evening. The failure is caused by trying to add plat_data->next_bridge twice (from exynos_dp's .attach callback, and from analogix' ->bind callback). Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland