From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Linus Walleij <linus.walleij@linaro.org>
Cc: bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Phil Elwell <phil@raspberrypi.com>,
Kent Gibson <warthog618@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
Date: Tue, 4 Jun 2024 09:28:45 +0200 [thread overview]
Message-ID: <7ccb2786-0c04-4058-9ea2-e611deebf1ef@broadcom.com> (raw)
In-Reply-To: <20240603181938.76047-3-wahrenst@gmx.net>
[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]
On 6/3/2024 8:19 PM, Stefan Wahren wrote:
> Use modern string_choices API instead of manually determining the
> output using ternary operator.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
LGTM but sometimes I really wonder to what degree should we invent a
helper function...
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-04 7:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 18:19 [PATCH 0/2] pinctrl: bcm2835: persist_gpio_outputs follow-up Stefan Wahren
2024-06-03 18:19 ` [PATCH 1/2] pinctrl: bcm2835: Fix permissions of persist_gpio_outputs Stefan Wahren
2024-06-04 7:57 ` Florian Fainelli
2024-06-03 18:19 ` [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator Stefan Wahren
2024-06-04 7:28 ` Florian Fainelli [this message]
2024-06-04 7:33 ` Andy Shevchenko
2024-06-17 7:51 ` [PATCH 0/2] pinctrl: bcm2835: persist_gpio_outputs follow-up Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ccb2786-0c04-4058-9ea2-e611deebf1ef@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).