From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E5ECC6FD1C for ; Mon, 20 Mar 2023 23:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8J6f0SB6aTa83SLxCZZqwn06yptqtk7VWvLXGanhToY=; b=jTcVEGjNZP1aIe89/l7SdrlVGi RqzCzgI5ji/7TN3S8dRvaAYAg3QHoqRjQAsg3HS6bkDHwbjv2oIr7kDIENzoIyROedSM46fF8PX12 U2WiEFbQkVYgOhopQdmqMggIzN8XLyN8WaFxlj1xe9nQmJkC/K846isFaGiCew4wJN9pdrxMkP67W EM29Skzv7JxqcTKq1PYRFlfofkBFCT1JTlNTIQBC5GGo1eQ4GIHr45rb4tQlMg9TkTI/VnM4756jn YdWYyxF7tdri2K0Oy9kPcSt4Y+fCja2eW86yDd0KMkNcFIGYZrbE/kxH8hIQhinveTJBb/NCf1tT6 Hkj+pHjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pePEB-00ApH4-1e; Mon, 20 Mar 2023 23:47:47 +0000 Received: from mail-dm6nam11on20714.outbound.protection.outlook.com ([2a01:111:f400:7eaa::714] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pePE7-00ApEA-0n for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 23:47:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lC7vxc0fNLszhr5m822hKOVVCgta1Z2l7H3RcIyTHW5/BZnd5SH4UjDhQYH6sdlIWZsLmgFbvBGjvwkG17rY2iVXmEX7iaL/WtB1iW1jJ8Zup6EFSDco3A2djyf9Wb2q6GxCWObKtf4JN2aBLcOB0hYywtdIlvIfX7Fy4V9Wp22xgSIqNbD3e1yyHseKN5jEUMQJvFH8mFtKORNQuehmrH13GK9hgMKPes1fY+efTqD8F2Yx+KcXmOMjR74JS/qGoBxlemjWlzFniqnWFrBAVfvAjbRL3mLfp7iP9QP1NP64qsuJuUIr4l+kNanSVYH3bol2yZBFDL4SbotnbYg0Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AnDFn6YdGVRKVAG5BgdMsdIjHU5LtQDQ4GMY1cAURcY=; b=Ih0yGWFCclhAfXYBaPuZjnHVxNV5gRn9jlesbhexi+FJ7Mn0gEeeK3wLvX29c8Oa2dsXpeeJ5oL2wsMbquY9uQX4nPLWhrXhxlFS8VAuqk9Irlm7fWWpf87KFiBw+4JZgC5ncLu9yagD3GafQWRUSa1zcWh92W7hbIQpROoxF77NxME5HggIrMoPOcCoeiDolXWmEApRqzI5A6jovmnX5Q4lEGNSaG1vHEvB+kOxGjo57p3Hi20Hv6+DnRtzPtC3qlb4l45dQ9+VNNbAPY8esQcag7mTGoHv+QhB6J22HP1YxKoT+zL85HxxjkNoxEFFKbDyi3PNWqljycDAVX/blQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AnDFn6YdGVRKVAG5BgdMsdIjHU5LtQDQ4GMY1cAURcY=; b=XNr3Nrwl/SnGgZ3EyrrXFF1aDyL1OoHlOjE6g9QOCnhQLdfVn8e6805dXq+bzHBTCQCcOxhYn9WEZZE1snsNpQda/0LpZ5vEAl2RrGhV4y8fjavYuqn1oNJ8461qwZgtcoYztju6Bnrmi10HuYWDMxe69/x1BnIzG7twhosIwS0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) by MW4PR01MB6146.prod.exchangelabs.com (2603:10b6:303:7c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.8; Mon, 20 Mar 2023 23:47:35 +0000 Received: from DM5PR0102MB3590.prod.exchangelabs.com ([fe80::4ac8:7982:7ee7:cdb2]) by DM5PR0102MB3590.prod.exchangelabs.com ([fe80::4ac8:7982:7ee7:cdb2%4]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 23:47:35 +0000 Date: Mon, 20 Mar 2023 16:47:17 -0700 (PDT) From: Ilkka Koskinen To: Robin Murphy cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, patches@amperecomputing.com Subject: Re: [PATCH] perf/arm-cmn: Move overlapping wp_combine field In-Reply-To: <629b13d5-10bd-899a-ba19-964fab9efdb5@os.amperecomputing.com> Message-ID: <7cd271db-c9d7-966a-cdc8-f4b0733f6e6a@os.amperecomputing.com> References: <20230301175540.19891-1-ilkka@os.amperecomputing.com> <0c19eb8e-6652-f688-d52e-25119a2cd058@arm.com> <629b13d5-10bd-899a-ba19-964fab9efdb5@os.amperecomputing.com> X-ClientProxiedBy: CH2PR20CA0027.namprd20.prod.outlook.com (2603:10b6:610:58::37) To DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3590:EE_|MW4PR01MB6146:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ab45524-e222-4c63-3483-08db299d7b14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MPP3pZFoIZ8lQW8niQfUTc4VLUbD77X4fzORwelaYaxlYMCLl3dSu824U/25L+8FUoloQ2W6Fcvsu4JHbBaGWa/eICUa7iWyHxJfvFhKLVHFmoCP3YnpD3uamuR4gKFgb2rlGLKX6ClBCMIE6UbphpBRoZm3KYbKWHuGO6YQazOorxxvQFWuqChnNmZUhNEOp70s9h9BDqAQMkP5vgcanZlpmCM4KgKDprAMer5lCiqFrVh7HYGjWOldln1I6z/H9Atf4bb6/2bt+98Y9Aa/O723XCxnWGw35uNqH+b5RrHgYFON9mgxddoGjtBKPUrPc6MzLmHIslpM7PVIyk+uSFaboOagvMfs8fVSHropeTX1YZVOtV+EKu42SOoB073P84ibBIpeukXqCsRYmuKMDn4VSrfGI4xfBXrN8bMokHNSB0MCYsU15K1eG504wqrKphY/uoefz+SHnfeBv4SyearDgKlxJ8AofrT5A53Jda1nyJgEymsVhSW5iTwDHpbhZsZJV0LapREsihpMJd9Ke12rPETT3/v1Cm7KLDeqdfYwPl2zTZNKyOZleTIFsjaAyek8FFUZ6nGUlT0B+ufSmMVK85J49VXjn14/lz4+NCKyl9Rr3Cngk2h7Dl11oAEzLVUzU0fjcVVdShrl86j6UyqVvJHQ4aYQdxUIuyc8osv5vVqtC0gAd+VvEY6sjbRhKBGUfsf1n7VAEjIsL2s/Mg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3590.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39850400004)(136003)(346002)(396003)(376002)(366004)(451199018)(186003)(52116002)(83380400001)(6486002)(2616005)(31686004)(38350700002)(38100700002)(2906002)(6506007)(53546011)(4326008)(107886003)(6666004)(6916009)(66946007)(6512007)(41300700001)(5660300002)(8676002)(8936002)(86362001)(66556008)(26005)(316002)(54906003)(66476007)(31696002)(478600001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hKXr3phz1Rdm03FMxNAPciuVbJJK/AiTvV0kiHlKDSuS9VeIRlcErOxLuxkm?= =?us-ascii?Q?Y5bA1VOggk/PZw+WL4408BFcKQk15eTLcFT4mAKzGthfsYNVdbyELetQ/jbM?= =?us-ascii?Q?MiwO2Kbt615QMP+Z36k4eWcUNq9taLlyFA6cyVbnaXv81PuFb4YSEY+UpUQd?= =?us-ascii?Q?7AIw6WKnEmmEmOGjFwvkEgGX+g9AneWqhqSvvY9Eim9Q28M0R6tKbnNjhCNP?= =?us-ascii?Q?LP2RsSXerJF2T4rz7n19A2kAgjxaZxRb8GWg15+Vn2d4T+8UxmwSiUYq3v8H?= =?us-ascii?Q?Zi41i/ysSnuaR9vRUzLTaO0acCXxzoteyG1sXnVCaDDg/r+NWfGkNJW4jqO3?= =?us-ascii?Q?1Tr5uopAOQpG7aS323H8arXp3N7ydUqgu9kguRQK8DuRGkDxSH0uqm6m+OwB?= =?us-ascii?Q?0kwJUGNZ5a1yhUIlHTur+rvJKNqJMbRgd4/bx9a4hHLphX5+/Ob6vBpHZwb7?= =?us-ascii?Q?XQN2eT/I03mWhmeCujE9S1W099kgLN1qpbyC1TaQKjrysh6oKcihYX8v+wO0?= =?us-ascii?Q?C8JMHyN7mKQmcH6JJL6p0xRQq2KeFJkv76GVbL0lFQN47vw15kVFFXeRI8Yv?= =?us-ascii?Q?5/8OeN7NUE1waVmljknQfoFyvnWeLd7nrQ4yAwAs6xwsQ+hw0uNDq4xrtNdu?= =?us-ascii?Q?AB8QZ0CKy8s+yZo06kUISyqglVfj6hcIFqBvfiy7RUv8PirULmVqqwNHJ1dQ?= =?us-ascii?Q?prnm66X8ZX+6QGAFKLiz4MGhtfJjsplaWv6ffY4YwFyzBEHwCHaaWKCS1Yqf?= =?us-ascii?Q?Gb9hCzGq+k1dzOfcYYRlhDYeRYBjlccLWbxb5x/lYfZqaJYAUWSBxHl2n8Ad?= =?us-ascii?Q?MLR2+Pp17+ATeknLA4Kkq0F4OZcWAuNWH51izck+ac8gBuPyRejdUSKNTNhq?= =?us-ascii?Q?CM/4Kw5Rc7LFHTrw6wlaF1jbhsAMEyCk0GV50FpKmW3o7sYIdUPQg6Pot3VI?= =?us-ascii?Q?vPRk5EoEgvluDSrxEO5vxA9FT+x50+TAYNDb1eF1U6RKAH4IhvsuKIr6Ocgr?= =?us-ascii?Q?kcEOwRkS6qxA5oPV+gwHnpjbtcedTch2rT3ETL/5vA+khgcOdxGgZr+egjJQ?= =?us-ascii?Q?fpq0zTCtsXLK++Awh4uEluqjJm1/15/BNjKE7yzfqPyXdmMzDlmd1AHHLsBS?= =?us-ascii?Q?Bl7BPfoc8UDlm0JIoOR36/jfGO/PLPoaq7fu1CUE7hn5DuwN7SWAJ6V4Yz/O?= =?us-ascii?Q?a2ZLE+M/knfICj+ib6awcBG1kmz3IEtASCIT+kM8r1oG5y3xoczAhq/V//g2?= =?us-ascii?Q?EDEAZMafuehNBHFQrDtEMPHcfuZ9oquZi4b/G2fgyO0Wq9CP6s9PVg2AzuiF?= =?us-ascii?Q?lgZjA7c21IkolPnzo5Otaw16eCmOGdrD7RShmr+VMwSAFkJe7iRYo4VWGoCk?= =?us-ascii?Q?7Q+8+KV2yge3niBZ84C6LgDK9Ng6KQRHsNo1Y47tfPm/weImGAXZhQxTPj4A?= =?us-ascii?Q?kqmmYxHgfhMqoK+cRetQHZOtzBsW++l4kRTtPMaf5RoqdWRl5ls5Dxroyhv0?= =?us-ascii?Q?0Rmwj0mhnYl1YoS5ERAGnK2/lnWroBXG+2jegVkEWT1AobFyNEGdIuCGEIG6?= =?us-ascii?Q?ZpAzpOLu14SSZdB8cf/LzWLKf6qVHyetMcuknXpA8QHTg4M9PXCajjxhRz4n?= =?us-ascii?Q?zdRqVi/9H1XsddQqmz1saHk=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab45524-e222-4c63-3483-08db299d7b14 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 23:47:35.7395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RXL8d7yq9VXotOjqcvre6lOCCskiNx5TpnVYvtQjjpr6wtnLF+MTn1F1E64olBGJTJhSrkfnjY3OrcMG/VAWvz2VXd54aHo4lhTCKH2cX0dMBfgD21d5AMOVQgojonSv X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6146 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_164743_468854_E9167559 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, On Wed, 1 Mar 2023, Ilkka Koskinen wrote: > > Hi Robin, > > On Wed, 1 Mar 2023, Robin Murphy wrote: >> On 2023-03-01 17:55, Ilkka Koskinen wrote: >>> As eventid field was expanded to support new mesh versions, it started to >>> overlap with wp_combine field. Move wp_combine to fix the issue. >> >> Watchpoint events still only strictly need 2 bits of eventid, though. Could >> you clarify whether userspace is getting confused by this, or whether it's >> just arm_cmn_event_init() falling over itself (FWIW I can see how I broke >> things there...) > > Basically, perf seems to set eventid at first and then wp_combine field into > the config argument. The problem is when arm_cmn_event_init() is doing: > > eventid = CMN_EVENT_EVENTID(event); > .... > if (eventid != CMN_WP_UP && eventid != CMN_WP_DOWN) > return -EINVAL; > > If wp_combine has any of the overlapping bits set, eventid doesn't match with > either up or down event. I probably should have also copy pasted what the format files say: $ cat format/eventid format/wp_combine config:16-26 config:24-27 So, here you can see that those two fields overlap. If wp_combine has any of the bits 24-26 set, arm_cmn_event_init() returns -EINVAL as shown in the code above. Would you need some more clarification from me? Br, Ilkka > > Cheers, Ilkka > >> >> Thanks, >> Robin. >> >>> Fixes: 23760a014417 ("perf/arm-cmn: Add CMN-700 support") >>> Signed-off-by: Ilkka Koskinen >>> --- >>> drivers/perf/arm-cmn.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c >>> index c9689861be3f..9f2edc28d16e 100644 >>> --- a/drivers/perf/arm-cmn.c >>> +++ b/drivers/perf/arm-cmn.c >>> @@ -166,7 +166,7 @@ >>> #define CMN_EVENT_BYNODEID(event) FIELD_GET(CMN_CONFIG_BYNODEID, >>> (event)->attr.config) >>> #define CMN_EVENT_NODEID(event) FIELD_GET(CMN_CONFIG_NODEID, >>> (event)->attr.config) >>> -#define CMN_CONFIG_WP_COMBINE GENMASK_ULL(27, 24) >>> +#define CMN_CONFIG_WP_COMBINE GENMASK_ULL(30, 27) >>> #define CMN_CONFIG_WP_DEV_SEL GENMASK_ULL(50, 48) >>> #define CMN_CONFIG_WP_CHN_SEL GENMASK_ULL(55, 51) >>> /* Note that we don't yet support the tertiary match group on newer IPs >>> */ >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel