From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A93BDE77188 for ; Wed, 8 Jan 2025 08:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lom+i4v3PxfHxmognsFk46EQaMmrjYMhI/xbLHGccvw=; b=FxGdDoPtqmXz97KF+Q4WcVkWzB M5/rfYrYGOElKG5bd/v+az4YpXcCsV+XKJ+qHFa5ZG9CVO+Ufak+edz3hny3evQavLY+nbi9ok7Hs tuP3+y2SAoF2/KLQC26syFaxdMOBEfpk3qB8dU35RoAjjrVwA3tCH1hOGSsdRRx4TN6HYV3rdNjEy l9QU1onq6TUlYbeo7moqaBRFwtKDHs1VGZayWGU4H+j3/KcdAIefLrZ5OpE2Ko3PTLWErpiKMIzXZ lSktQmQpKkx7wMYtCWmVZ0DA023zP7jZriGK7tOs6BJCprVyIQeZTPlTmfamT2h4BgxX5O7hIO0W5 EOISfnew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVRVg-00000007ZW5-02q3; Wed, 08 Jan 2025 08:33:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVRTC-00000007Z3M-4Alp; Wed, 08 Jan 2025 08:31:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A875312FC; Wed, 8 Jan 2025 00:31:45 -0800 (PST) Received: from [10.57.94.52] (unknown [10.57.94.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28A753F59E; Wed, 8 Jan 2025 00:31:08 -0800 (PST) Message-ID: <7cf8fa3b-799f-415a-82a1-eee6b7b2e0f5@arm.com> Date: Wed, 8 Jan 2025 09:31:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/17] x86: pgtable: convert __tlb_remove_table() to use struct ptdesc To: Qi Zheng , peterz@infradead.org, agordeev@linux.ibm.com, alex@ghiti.fr, andreas@gaisler.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <39f60f93143ff77cf5d6b3c3e75af0ffc1480adb.1736317725.git.zhengqi.arch@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <39f60f93143ff77cf5d6b3c3e75af0ffc1480adb.1736317725.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250108_003119_078137_DFED265C X-CRM114-Status: UNSURE ( 5.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/01/2025 07:57, Qi Zheng wrote: > Convert __tlb_remove_table() to use struct ptdesc, which will help to move > pagetable_dtor() to __tlb_remove_table(). > > And page tables shouldn't have swap cache, so use pagetable_free() instead > of free_page_and_swap_cache() to free page table pages. > > Signed-off-by: Qi Zheng Definitely a good idea to have split patch 11 from v4. Reviewed-by: Kevin Brodsky - Kevin