From: Krzysztof Kozlowski <krzk@kernel.org>
To: Titouan Ameline <titouan.ameline@gmail.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: alim.akhtar@samsung.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: samsung: fix stale response flag in acpm_prepare_xfer()
Date: Tue, 28 Apr 2026 11:32:25 +0200 [thread overview]
Message-ID: <7d090781-4fb2-4b54-9f6c-8e9a4ec2749a@kernel.org> (raw)
In-Reply-To: <CABvHBc71N5NvYZ29W8hn9-gjOo40eh-hgcTAP3Nn1jrAfrgr2A@mail.gmail.com>
On 27/04/2026 23:37, Titouan Ameline wrote:
> I was reading through the driver code and noticed that
> acpm_prepare_xfer() only enters the
>
> if (xfer->rxd) branch to set response = true
> with no corresponding else to reset it to false.
>
> Since seqnum slots are recycled, I traced what happens when a slot
> previously used by a response-expecting transfer gets reused by a
> fire-and-forget one
>
> -> the stale true remains and the wrong branch is taken in acpm_get_rx().
>
> Le lun. 27 avr. 2026 à 10:48, Tudor Ambarus <tudor.ambarus@linaro.org> a écrit :
>>
This seams to duplicate Tudor's earlier patches and his solution looks
more complete, so I will take his work with Reported-by credits.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-28 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 21:02 [PATCH] firmware: samsung: fix stale response flag in acpm_prepare_xfer() Titouan Ameline de Cadeville
2026-04-27 8:48 ` Tudor Ambarus
2026-04-27 21:37 ` Titouan Ameline
2026-04-28 9:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d090781-4fb2-4b54-9f6c-8e9a4ec2749a@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox